Comment 3 for bug 2050024

Revision history for this message
Frank Heimes (fheimes) wrote :

Thanky you Alexandre for the work on the new libica version.

Review check-list:
- changelog looks good with:
  - correct version string
  - code-name
  - all changes listed
  - LP bug referenced
- maintainer field ok
- existing patches got checked, no new ones
- symbols file updates
- build log looks good, no issues
- debdiff looks reasonable
- lintian (-EvIL -pedantic) on and bin DEBs are reasonable (no errors)
- sanity checks are fine, install and upgrade
- LP bug made public
- rdeps checked, and test builds done

The above covers the requested version bump.
On top I noticed two (probably legacy) issues, that I would like to solve with this upload too - if you don't mind:
  * d/libica4.symbols: Add '* Build-Depends-Package: libica-dev' lines to
    solve lintian message 'symbols-file-missing-build-depends-package-field'.
  * d/rules: Set 'DEB_BUILD_MAINT_OPTIONS to hardening=+all' to solve
    lintian message 'hardening-no-bindnow'.
Based on that I've rebuild the package (incl. it's redepends) here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp2050024
and re-validated the above checklist again.

The update looks pretty good now, I think it's ready to be uploaded ...