[FeatureFreeze Exception] New aMule 2.2.0 pre-release snapshot and build with uPnP

Bug #204928 reported by Emilio Pozuelo Monfort
10
Affects Status Importance Assigned to Milestone
amule (Ubuntu)
Fix Released
Wishlist
Emilio Pozuelo Monfort

Bug Description

Binary package hint: amule

This new snapshot contains many bugfixes, so the main reason for this exception is to enable uPnP support in aMule. It was added long time ago, after the 2.1.3, although it hasn't show the light in an official release yet. It has got some testing as post-2.1.3 tarballs have been tested widely by the community.

I'm attaching an interdiff and a Changelog diff
The debian/changelog entry is as follow:

amule (2.2.0~svn20080321-0ubuntu1) hardy; urgency=low

  * New svn snapshot from 20080321 tarball, renamed debian/ to
    debian-upstream/, with a lot of bug fixes, including:
    - Fixes an error in the Spanish translation. LP: #204600.
    - Copy ed2k links to clipboard work fine again. LP: #94231.
  * debian/amule-common.install:
    - Install the skins for the monolithic client.
  * debian/control:
    - Build-Depend on libupnp-dev
  * debian/rules:
    - Enable UPnP support. LP: #201624.
  * debian/patches/configure_ignore_gdlib-config_garbage.diff:
    - Updated to apply with the new snapshot.
  * debian/patches/removing_SVN_warning_window.diff,
    debian/series:
    - Don't show the new version dialog when starting aMule for the first
      time, as it shows a big warning due to this being a svn snapshot.
      We (and upstream) consider this stable as to ship it. LP: #197332.
      Thanks to Festor Wailon Dacoba for the patch.

 -- Emilio Pozuelo Monfort <email address hidden> Sat, 22 Mar 2008 01:40:48 +0100

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :
Revision history for this message
StefanPotyra (sistpoty) wrote :

can you please also attach a build log and install log and add some info how you tested the new version in hardy? If done so, please set the bug back to new, thanks!

Changed in amule:
status: New → Incomplete
Revision history for this message
StefanPotyra (sistpoty) wrote :

@jdong: any hints from you on this? Thanks!

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

TBH I have only tested the aMule core program. I haven't tested amulegui, amuleweb, amuled... because I consider the new upstream snapshot mainly bug-fix.

The reason for this exception is the uPnP support, which I haven't tested either. I'm ok to drop it for Hardy, but as a user asked me for it, and there might be some people out there using it, I thought it would be a good idea.

AFAIK it only affects the core program, which I have thoroughly tested this days, and found no regressions. Although if the uPnP support has important bugs, it could lead to crashes in aMule, but only for people using uPnP.

If it's too late for enabling uPnP, I'm happy to leave it for the beginning of the Intrepid cycle.

Attaching build and install log.

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :
Changed in amule:
status: Incomplete → New
Revision history for this message
Scott Kitterman (kitterman) wrote :

If you build with UPnP, is it enabled by default or does the user have to enable it?

Changed in amule:
importance: Undecided → Wishlist
status: New → Incomplete
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote : Re: [Bug 204928] Re: [FeatureFreeze Exception] New aMule 2.2.0 pre-release snapshot and build with uPnP

Scott Kitterman wrote:
> If you build with UPnP, is it enabled by default or does the user have
> to enable it?

You have to enable it on Preferences > Remote Controls

Revision history for this message
Scott Kitterman (kitterman) wrote :

On Thursday 27 March 2008 11:40, Emilio Pozuelo Monfort wrote:
> Scott Kitterman wrote:
> > If you build with UPnP, is it enabled by default or does the user have
> > to enable it?
>
> You have to enable it on Preferences > Remote Controls

Ack from me then.

Revision history for this message
StefanPotyra (sistpoty) wrote :

ACK #2, confirming. please go ahead.

Changed in amule:
status: Incomplete → Confirmed
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

FTR, I'm a bit unsure right now with the mentioned tarball. I'll test it further (and perhaps test a different tarball) before changing it, and in the meantime I'll make an upload with the other changes (uPnP, the new version dialog patch, and a patch for bug #209810).

Changed in amule:
assignee: nobody → pochu
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package amule - 2.2.0~svn20080218-0ubuntu2

---------------
amule (2.2.0~svn20080218-0ubuntu2) hardy; urgency=low

  * debian/amule-common.install:
    - Install the skins for the monolithic client.
  * debian/control:
    - Build-Depend on libupnp-dev
  * debian/rules:
    - Enable uPnP support. LP: #201624, FeatureFreeze exception
      is LP: #204928.
  * debian/patches/removing_SVN_warning_window.diff,
    debian/series:
    - Don't show the new version dialog when starting aMule for the first
      time, as it shows a big warning due to this being a svn snapshot.
      We (and upstream) consider this stable as to ship it. LP: #197332.
      Thanks to Festor Wailon Dacoba for the patch.

 -- Emilio Pozuelo Monfort <email address hidden> Tue, 01 Apr 2008 23:46:17 +0200

Changed in amule:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.