Desktop icons in Mantic doesn't honor dock margins

[Sergio Costas]

[Impact]

The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible.

[Test plan]

Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine).

In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen.

Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen.

Close the window. The dock should appear again.

Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides.

If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there.

It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel).

[Where problems could occur]

If there are problems, they can show in several ways:

- the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden

- DING might fail and no icons would be visible

- DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone.

[ Other info ]
It seems easiest to take the new upstream release (47.0.5 -> 47.0.7) which includes this single code commit, plus translation updates.

[Sergio Costas (rastersoft-gmail)]

This patch fixes the problem.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Sergio Costas (rastersoft-gmail)]

Just a little note: it's already fixed upstream with this same patch ;-)

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 46+really47.0.7-1

---------------
gnome-shell-extension-desktop-icons-ng (46+really47.0.7-1) experimental; urgency=medium

  * New upstream release
    - Fix regression that allowed desktop icons to be placed under autohidden
      Dock (LP: #2039475)

 -- Jeremy Bícha <email address hidden> Wed, 18 Oct 2023 10:04:14 -0400

[Mauricio Faria de Oliveira (mfo)]

Hi Sergio and Jeremy (sponsor),

Thanks for the great bug description/sru template, and detailed test steps!

Could you please help clarify 3 questions I had with the upload for Mantic?

1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
which seems to break backwards compatibility [2] (but I know little Desktop);
however, gnome 45 is shipped in Mantic already [3].

So, I'm curious -- is DING in the mantic-release pocket not compatible with
gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
changes are not strictly required, and DING (and this bug fix) can work fine
without this commit?

2) There are differences between the upstream changes and debdiff changes on
this micro release update (e.g., debdiff has one more translation file) [4, 5].

Can you comment on whether this is expected?

3) Some of the translation updates are changing user interface strings, right?
Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]

Sorry if these questions are basic or not too relevant; but I wanted to double
check as Other Info gave me the impression the change set would be smaller.

Thanks!
Mauricio

[1]
$ git log --oneline 47.0.5..47.0.7
d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
6303910d6902 Merge branch 'master' into 'master'
6bd9febdb86e Update Ukrainian translation #2

[2] https://gitlab.com/rastersoft/desktop-icons-ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7

[3] https://discourse.ubuntu.com/t/mantic-minotaur-release-notes/35534#gnome-footprints-16

[4]
$ git diff 47.0.5..47.0.7 | diffstat -l | sort
app/desktopManager.js
emulateX11WindowType.js
extension.js
gnomeShellOverride.js
meson.build
metadata.json
po/uk.po
prefs.js
visibleArea.js

[5]
$ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
app/meson.build
app/prefswindow.js
extension.js
po/ca.po
po/uk.po

[6] https://wiki.ubuntu.com/UserInterfaceFreeze

[7]

 #: autoAr.js:240
-#, fuzzy
 msgid "Compressing files"
-msgstr "Стиснути {0} файл"
+msgstr "Стиснення файлів"

 #: autoAr.js:315 autoAr.js:605
 msgid "Enter a password here"
-msgstr ""
+msgstr "Введіть пароль тут"

[Sergio Costas (rastersoft-gmail)]

Hi Mauricio,

sorry for the delay; traveling to Riga has been a nightmare...

El 3/11/23 a las 0:49, Mauricio Faria de Oliveira escribió:
> Hi Sergio and Jeremy (sponsor),
>
> Thanks for the great bug description/sru template, and detailed test
> steps!
>
> Could you please help clarify 3 questions I had with the upload for
> Mantic?
>
> 1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
> which seems to break backwards compatibility [2] (but I know little Desktop);
> however, gnome 45 is shipped in Mantic already [3].
>
> So, I'm curious -- is DING in the mantic-release pocket not compatible with
> gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
> changes are not strictly required, and DING (and this bug fix) can work fine
> without this commit?
Current DING version in Mantic is really 47.0.6; this is, it has the
first patch, but not the second one. Gnome 45 broke backwards
compatibility in the extensions, so all and everyone must be ported to
the new model. The problem is that the migration, accidentally, broke
the mechanism used to share the margins used by extensions; that is what
is fixed in the second patch.
> 2) There are differences between the upstream changes and debdiff changes on
> this micro release update (e.g., debdiff has one more translation file) [4, 5].
>
> Can you comment on whether this is expected?
The upstream keeps adding translations as long as they are added, so it
makes sense that there are updated translations there.
> 3) Some of the translation updates are changing user interface strings, right?
> Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]
Some changes fix translations that weren't accurate, and other just
translates some sentences that weren't previously translated in other
languages; but the original sentences (the ones in english) have not
changed from the current Mantic version to the proposed one.
> Sorry if these questions are basic or not too relevant; but I wanted to double
> check as Other Info gave me the impression the change set would be smaller.
>
> Thanks!
> Mauricio
>
> [1]
> $ git log --oneline 47.0.5..47.0.7
> d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
> e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
> 6303910d6902 Merge branch 'master' into 'master'
> 6bd9febdb86e Update Ukrainian translation #2
>
> [2]https://gitlab.com/rastersoft/desktop-icons-
> ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7
>
> [3]https://discourse.ubuntu.com/t/mantic-minotaur-release-
> notes/35534#gnome-footprints-16
>
> [4]
> $ git diff 47.0.5..47.0.7 | diffstat -l | sort
> app/desktopManager.js
> emulateX11WindowType.js
> extension.js
> gnomeShellOverride.js
> meson.build
> metadata.json
> po/uk.po
> prefs.js
> visibleArea.js
>
> [5]
> $ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
> app/meson.build
> app/prefswindow.js
> extension.js
> po/ca.po
> po/uk.po
>
> [6]https://wiki.ubuntu.com/UserInterfaceFreeze
>
> [7]
>
> #:...

[Andreas Hasenack (ahasenack)]

Hello Sergio, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons-ng into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons-ng/46+really47.0.7-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sergio Costas (rastersoft-gmail)]

I enabled proposed repo, but the package hasn't been updated...

[Andreas Hasenack (ahasenack)]

> I enabled proposed repo, but the package hasn't been updated...

You need to add "-t mantic-proposed" to the apt command line.

[Sergio Costas (rastersoft-gmail)]

Ops... you are right. Now it works.

And the patch does work too.

[Sergio Costas (rastersoft-gmail)]

Installed 46+really47.0.7-0ubuntu1 from mantic-proposed.

Set the dock to "intellihide" (hide when a window covers it, show when uncovered) and kept it in the left side. Tried to move an icon to the left border, and confirmed that it remained at a distance enough to avoid being covered by the dock, and that DING doesn't allow to move it to the zone covered by the dock.

[Sergio Costas (rastersoft-gmail)]

@ahasenack should I also change the "verification-needed" to "verification-done"? Or change only "verification-needed-mantic" (which already did)?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 46+really47.0.7-0ubuntu1

---------------
gnome-shell-extension-desktop-icons-ng (46+really47.0.7-0ubuntu1) mantic; urgency=medium

  * New upstream release
    - Fix regression that allowed desktop icons to be placed under autohidden
      Dock (LP: #2039475)

 -- Sergio Costas Rodriguez <email address hidden> Wed, 18 Oct 2023 10:04:14 -0400

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-shell-extension-desktop-icons-ng has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.