Launchpad downloads fail with "incorrect size, got X expected Y"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-dev-tools (Ubuntu) |
Fix Released
|
Medium
|
Robie Basak | ||
Focal |
Fix Released
|
Critical
|
Robie Basak | ||
Jammy |
Fix Released
|
Undecided
|
Robie Basak | ||
Kinetic |
Fix Released
|
Undecided
|
Robie Basak | ||
Lunar |
Fix Released
|
Undecided
|
Robie Basak |
Bug Description
[Impact]
src:ubuntu-
[Test Plan]
Scenario A:
python3
from ubuntutools.archive import UbuntuSourcePackage
pkg=UbuntuSourc
pkg.pull()
Actual results:
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/
self.
File "/usr/lib/
raise DownloadError(
ubuntutools.
Expected results: no output and no error and ffc_0.7.0-1.diff.gz should be 13021 bytes.
You may also want to add the lines:
import logging
logging.
logging.
to help with debugging, but it is not necessary to reproduce the problem.
With python3-ubuntutools 0.176ubuntu20.04.1 this works
With python3-ubuntutools 0.193ubuntu4~
I think 0.193ubuntu4~
Scenario B:
$ pull-lp-source ffc 0.7.0-1
Found ffc 0.7.0-1 in lucid
Downloading ffc_0.7.0-1.dsc from launchpadlibrar
[======
Public key not found, could not verify signature
Downloading ffc_0.7.
[======
Downloading ffc_0.7.0-1.diff.gz from launchpadlibrar
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "/usr/bin/
PullPkg.
File "/usr/lib/
cls(*args, **kwargs).pull()
File "/usr/lib/
srcpkg.pull()
File "/usr/lib/
self.
File "/usr/lib/
raise DownloadError(
ubuntutools.
Expected results: success and ffc_0.7.0-1.diff.gz should be 13021 bytes.
Scenario C:
Pick a package in an Unapproved queue. In this example I chose r8125 in the Jammy queue.
pull-pkg -D ubuntu --upload-queue --pull source r8125 jammy
This should result in (amongst others) an appropriately named changes file eg. r8125_9.
$ xxd r8125_9.
00000000: 466f 726d 6174 3a20 312e 380a 4461 7465 Format: 1.8.Date
[Where things could go wrong]
We're changing how we download files, so other classes of downloads could regress. To try and mitigate this, the Test Plan tries the opposing known edge cases of .diff.gz and .changes files.
Related branches
- Sebastien Bacher: Approve
-
Diff: 58 lines (+22/-4)2 files modifieddebian/changelog (+7/-2)
ubuntutools/misc.py (+15/-2)
Changed in ubuntu-dev-tools (Ubuntu): | |
assignee: | nobody → Robie Basak (racb) |
Changed in ubuntu-dev-tools (Ubuntu Focal): | |
assignee: | nobody → Robie Basak (racb) |
Changed in ubuntu-dev-tools (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubuntu-dev-tools (Ubuntu Focal): | |
status: | Triaged → In Progress |
description: | updated |
description: | updated |
Also reproduced on Mantic with 0.193ubuntu4.