| 2023-07-04 11:46:38 |
Robie Basak |
bug |
|
|
added bug |
| 2023-07-04 11:53:10 |
Robie Basak |
nominated for series |
|
Ubuntu Focal |
|
| 2023-07-04 11:53:10 |
Robie Basak |
bug task added |
|
ubuntu-dev-tools (Ubuntu Focal) |
|
| 2023-07-04 11:53:16 |
Robie Basak |
ubuntu-dev-tools (Ubuntu): importance |
Critical |
Medium |
|
| 2023-07-04 11:53:17 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Focal): status |
New |
Triaged |
|
| 2023-07-04 11:53:19 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Focal): importance |
Undecided |
Critical |
|
| 2023-07-05 10:00:03 |
Robie Basak |
ubuntu-dev-tools (Ubuntu): assignee |
|
Robie Basak (racb) |
|
| 2023-07-05 10:00:05 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Focal): assignee |
|
Robie Basak (racb) |
|
| 2023-07-05 10:00:08 |
Robie Basak |
ubuntu-dev-tools (Ubuntu): status |
Triaged |
In Progress |
|
| 2023-07-05 10:00:10 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Focal): status |
Triaged |
In Progress |
|
| 2023-07-05 11:54:34 |
Robie Basak |
description |
src:ubuntu-dev-tools 0.193ubuntu4~20.04.2 regressed behaviour in how python3-ubuntutools downloads source packages from Launchpad. This is currently breaking the git-ubuntu importer, causing it to fail to update repositories for some packages, since the git-ubuntu snap is based on Focal and has been rebuilt since. The most recent version of the git-ubuntu snap for amd64 that does not exhibit the problem is r1212.
Steps to reproduce:
python3
from ubuntutools.archive import UbuntuSourcePackage
pkg=UbuntuSourcePackage(package='ffc', version='0.7.0-1')
pkg.pull()
Actual results:
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: no output and no error.
You may also want to add the lines:
import logging
logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)
to help with debugging, but it is not necessary to reproduce the problem.
With python3-ubuntutools 0.176ubuntu20.04.1 this works
With python3-ubuntutools 0.193ubuntu4~20.04.2 this fails.
I think 0.193ubuntu4~20.04.1 was never published to focal-updates. |
src:ubuntu-dev-tools 0.193ubuntu4~20.04.2 regressed behaviour in how python3-ubuntutools downloads source packages from Launchpad. This is currently breaking the git-ubuntu importer, causing it to fail to update repositories for some packages, since the git-ubuntu snap is based on Focal and has been rebuilt since. The most recent version of the git-ubuntu snap for amd64 that does not exhibit the problem is r1212.
[Test Plan]
Scenario A:
python3
from ubuntutools.archive import UbuntuSourcePackage
pkg=UbuntuSourcePackage(package='ffc', version='0.7.0-1')
pkg.pull()
Actual results:
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: no output and no error and ffc_0.7.0-1.diff.gz should be 13021 bytes.
You may also want to add the lines:
import logging
logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)
to help with debugging, but it is not necessary to reproduce the problem.
With python3-ubuntutools 0.176ubuntu20.04.1 this works
With python3-ubuntutools 0.193ubuntu4~20.04.2 this fails.
I think 0.193ubuntu4~20.04.1 was never published to focal-updates.
Scenario B:
$ pull-lp-source ffc 0.7.0-1
Found ffc 0.7.0-1 in lucid
Downloading ffc_0.7.0-1.dsc from launchpadlibrarian.net (0.001 MiB)
[=====================================================>]100%
Public key not found, could not verify signature
Downloading ffc_0.7.0.orig.tar.gz from launchpadlibrarian.net (1.551 MiB)
[=====================================================>]100%
Downloading ffc_0.7.0-1.diff.gz from launchpadlibrarian.net (0.012 MiB)
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "/usr/bin/pull-lp-source", line 14, in <module>
PullPkg.main(distro="ubuntu", pull="source")
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 111, in main
cls(*args, **kwargs).pull()
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 461, in pull
srcpkg.pull()
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: success and ffc_0.7.0-1.diff.gz should be 13021 bytes.
Scenario C:
Pick a package in an Unapproved queue. In this example I chose r8125 in the Jammy queue.
pull-pkg -D ubuntu --upload-queue --pull source r8125 jammy
This should result in (amongst others) an appropriately named changes file eg. r8125_9.007.01-3ubuntu0.2_source.changes and the file should be uncompressed. For example:
$ xxd r8125_9.007.01-3ubuntu0.2_source.changes|head -1
00000000: 466f 726d 6174 3a20 312e 380a 4461 7465 Format: 1.8.Date |
|
| 2023-07-05 14:35:26 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~racb/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/446078 |
|
| 2023-07-06 11:58:07 |
Robie Basak |
description |
src:ubuntu-dev-tools 0.193ubuntu4~20.04.2 regressed behaviour in how python3-ubuntutools downloads source packages from Launchpad. This is currently breaking the git-ubuntu importer, causing it to fail to update repositories for some packages, since the git-ubuntu snap is based on Focal and has been rebuilt since. The most recent version of the git-ubuntu snap for amd64 that does not exhibit the problem is r1212.
[Test Plan]
Scenario A:
python3
from ubuntutools.archive import UbuntuSourcePackage
pkg=UbuntuSourcePackage(package='ffc', version='0.7.0-1')
pkg.pull()
Actual results:
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: no output and no error and ffc_0.7.0-1.diff.gz should be 13021 bytes.
You may also want to add the lines:
import logging
logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)
to help with debugging, but it is not necessary to reproduce the problem.
With python3-ubuntutools 0.176ubuntu20.04.1 this works
With python3-ubuntutools 0.193ubuntu4~20.04.2 this fails.
I think 0.193ubuntu4~20.04.1 was never published to focal-updates.
Scenario B:
$ pull-lp-source ffc 0.7.0-1
Found ffc 0.7.0-1 in lucid
Downloading ffc_0.7.0-1.dsc from launchpadlibrarian.net (0.001 MiB)
[=====================================================>]100%
Public key not found, could not verify signature
Downloading ffc_0.7.0.orig.tar.gz from launchpadlibrarian.net (1.551 MiB)
[=====================================================>]100%
Downloading ffc_0.7.0-1.diff.gz from launchpadlibrarian.net (0.012 MiB)
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "/usr/bin/pull-lp-source", line 14, in <module>
PullPkg.main(distro="ubuntu", pull="source")
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 111, in main
cls(*args, **kwargs).pull()
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 461, in pull
srcpkg.pull()
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: success and ffc_0.7.0-1.diff.gz should be 13021 bytes.
Scenario C:
Pick a package in an Unapproved queue. In this example I chose r8125 in the Jammy queue.
pull-pkg -D ubuntu --upload-queue --pull source r8125 jammy
This should result in (amongst others) an appropriately named changes file eg. r8125_9.007.01-3ubuntu0.2_source.changes and the file should be uncompressed. For example:
$ xxd r8125_9.007.01-3ubuntu0.2_source.changes|head -1
00000000: 466f 726d 6174 3a20 312e 380a 4461 7465 Format: 1.8.Date |
[Impact]
src:ubuntu-dev-tools 0.193ubuntu4~20.04.2 regressed behaviour in how python3-ubuntutools downloads source packages from Launchpad. This is currently breaking the git-ubuntu importer, causing it to fail to update repositories for some packages, since the git-ubuntu snap is based on Focal and has been rebuilt since. The most recent version of the git-ubuntu snap for amd64 that does not exhibit the problem is r1212.
[Test Plan]
Scenario A:
python3
from ubuntutools.archive import UbuntuSourcePackage
pkg=UbuntuSourcePackage(package='ffc', version='0.7.0-1')
pkg.pull()
Actual results:
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: no output and no error and ffc_0.7.0-1.diff.gz should be 13021 bytes.
You may also want to add the lines:
import logging
logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)
to help with debugging, but it is not necessary to reproduce the problem.
With python3-ubuntutools 0.176ubuntu20.04.1 this works
With python3-ubuntutools 0.193ubuntu4~20.04.2 this fails.
I think 0.193ubuntu4~20.04.1 was never published to focal-updates.
Scenario B:
$ pull-lp-source ffc 0.7.0-1
Found ffc 0.7.0-1 in lucid
Downloading ffc_0.7.0-1.dsc from launchpadlibrarian.net (0.001 MiB)
[=====================================================>]100%
Public key not found, could not verify signature
Downloading ffc_0.7.0.orig.tar.gz from launchpadlibrarian.net (1.551 MiB)
[=====================================================>]100%
Downloading ffc_0.7.0-1.diff.gz from launchpadlibrarian.net (0.012 MiB)
File ffc_0.7.0-1.diff.gz incorrect size, got 53464 expected 13021
Traceback (most recent call last):
File "/usr/bin/pull-lp-source", line 14, in <module>
PullPkg.main(distro="ubuntu", pull="source")
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 111, in main
cls(*args, **kwargs).pull()
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 461, in pull
srcpkg.pull()
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 470, in pull
self._download_file_from_urls(urls, name, int(entry["size"]), dscverify=True)
File "/usr/lib/python3/dist-packages/ubuntutools/archive.py", line 447, in _download_file_from_urls
raise DownloadError(f"Failed to download {filename}")
ubuntutools.misc.DownloadError: Failed to download ffc_0.7.0-1.diff.gz
Expected results: success and ffc_0.7.0-1.diff.gz should be 13021 bytes.
Scenario C:
Pick a package in an Unapproved queue. In this example I chose r8125 in the Jammy queue.
pull-pkg -D ubuntu --upload-queue --pull source r8125 jammy
This should result in (amongst others) an appropriately named changes file eg. r8125_9.007.01-3ubuntu0.2_source.changes and the file should be uncompressed. For example:
$ xxd r8125_9.007.01-3ubuntu0.2_source.changes|head -1
00000000: 466f 726d 6174 3a20 312e 380a 4461 7465 Format: 1.8.Date
[Where things could go wrong]
We're changing how we download files, so other classes of downloads could regress. To try and mitigate this, the Test Plan tries the opposing known edge cases of .diff.gz and .changes files. |
|
| 2023-07-06 12:21:45 |
Robie Basak |
nominated for series |
|
Ubuntu Jammy |
|
| 2023-07-06 12:21:45 |
Robie Basak |
bug task added |
|
ubuntu-dev-tools (Ubuntu Jammy) |
|
| 2023-07-06 12:21:45 |
Robie Basak |
nominated for series |
|
Ubuntu Kinetic |
|
| 2023-07-06 12:21:45 |
Robie Basak |
bug task added |
|
ubuntu-dev-tools (Ubuntu Kinetic) |
|
| 2023-07-06 12:21:45 |
Robie Basak |
nominated for series |
|
Ubuntu Lunar |
|
| 2023-07-06 12:21:45 |
Robie Basak |
bug task added |
|
ubuntu-dev-tools (Ubuntu Lunar) |
|
| 2023-07-06 12:21:58 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Jammy): status |
New |
In Progress |
|
| 2023-07-06 12:21:59 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Kinetic): status |
New |
In Progress |
|
| 2023-07-06 12:22:02 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Lunar): status |
New |
In Progress |
|
| 2023-07-06 12:22:03 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Jammy): assignee |
|
Robie Basak (racb) |
|
| 2023-07-06 12:22:05 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Kinetic): assignee |
|
Robie Basak (racb) |
|
| 2023-07-06 12:22:06 |
Robie Basak |
ubuntu-dev-tools (Ubuntu Lunar): assignee |
|
Robie Basak (racb) |
|
| 2023-07-06 12:24:49 |
Robie Basak |
ubuntu-dev-tools (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2023-07-06 13:38:29 |
Andreas Hasenack |
ubuntu-dev-tools (Ubuntu Lunar): status |
In Progress |
Fix Committed |
|
| 2023-07-06 13:38:30 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-07-06 13:38:38 |
Andreas Hasenack |
bug |
|
|
added subscriber SRU Verification |
| 2023-07-06 13:38:43 |
Andreas Hasenack |
tags |
regression-update |
regression-update verification-needed verification-needed-lunar |
|
| 2023-07-06 13:39:18 |
Andreas Hasenack |
ubuntu-dev-tools (Ubuntu Kinetic): status |
In Progress |
Fix Committed |
|
| 2023-07-06 13:39:22 |
Andreas Hasenack |
tags |
regression-update verification-needed verification-needed-lunar |
regression-update verification-needed verification-needed-kinetic verification-needed-lunar |
|
| 2023-07-06 13:39:52 |
Andreas Hasenack |
ubuntu-dev-tools (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2023-07-06 13:39:57 |
Andreas Hasenack |
tags |
regression-update verification-needed verification-needed-kinetic verification-needed-lunar |
regression-update verification-needed verification-needed-jammy verification-needed-kinetic verification-needed-lunar |
|
| 2023-07-06 13:40:21 |
Andreas Hasenack |
ubuntu-dev-tools (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2023-07-06 13:40:27 |
Andreas Hasenack |
tags |
regression-update verification-needed verification-needed-jammy verification-needed-kinetic verification-needed-lunar |
regression-update verification-needed verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-lunar |
|
| 2023-07-07 13:20:08 |
Launchpad Janitor |
ubuntu-dev-tools (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2023-07-10 10:25:44 |
Robie Basak |
tags |
regression-update verification-needed verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-lunar |
regression-update verification-done verification-done-focal verification-done-jammy verification-done-kinetic verification-done-lunar |
|
| 2023-07-10 11:02:23 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2023-07-10 11:02:38 |
Launchpad Janitor |
ubuntu-dev-tools (Ubuntu Lunar): status |
Fix Committed |
Fix Released |
|
| 2023-07-10 11:02:46 |
Launchpad Janitor |
ubuntu-dev-tools (Ubuntu Kinetic): status |
Fix Committed |
Fix Released |
|
| 2023-07-10 11:06:35 |
Launchpad Janitor |
ubuntu-dev-tools (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2023-07-10 11:28:16 |
Launchpad Janitor |
ubuntu-dev-tools (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
