Ubuntu dock is visible too early during the login animation

[Daniel van Vugt]

[ Impact ]

Ubuntu dock is visible too early during the login animation: It appears immediately, disappears, then appears again.

[ Test case ]

Run:

env GNOME_SHELL_SESSION_MODE='ubuntu' GNOME_SHELL_SLOWDOWN_FACTOR=3 \
  dbus-run-session gnome-shell --nested --wayland --unsafe-mode

Observe that the dock should be hidden while the startup animation happens, and doesn't hide and snow again

[ Regression potential ]

Dock is never shown or animation is not properly executed.

---

In jammy this problem only occurred in Xorg sessions, but in kinetic it now occurs in Wayland sessions.

[Daniel van Vugt (vanvugt)]

Maybe the same issue?;
https://github.com/micheleg/dash-to-dock/issues/1770

[Daniel van Vugt (vanvugt)]

https://github.com/micheleg/dash-to-dock/pull/1842

[Daniel van Vugt (vanvugt)]

Fixed committed to dash-to-dock: https://github.com/micheleg/dash-to-dock/pull/1846

Ubuntu Dock coming soon.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 74ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (74ubuntu2) kinetic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/control: Update maintainer to myself
  * docking: Don't try to call a null callback (LP: #1989170)
  * docking: Do not wait for dash animation two times with no overview
    (LP: #1965208)
  * docking: Ensure we perform the startup animation completely on docks updates
    (LP: #1965208, LP: #1989170)
  * docking: Use a try/catch statement on our promise to show errors in case
    (LP: #1989170)
  * windowPreviews: Take global scaling in account to set the clone sizes
    (LP: #1992843)
  * docking: Keep overview controls layout proportions when resizing it
    (LP: #1992847)
  * docking: Also reduce the app grid area when in auto-hide mode (LP: #1992847)
  * docking: Use an even width for the overview content area (LP: #1979096)
  * docking: Check if autohide or intellihide is enabled on menu closed
    (LP: #1983130)
  * appIcons: Ensure icons are animated when new instances are launched
    (LP: #1992845)
  * docking: Do not try to focus potentially undefined window
  * appSpread: Do not anything on destruction if not supported
  * docking: Ignore hover changes if overview is visible (LP: #1983130)

  [ Daniel van Vugt ]
  * docking: Handle when dash is destroyed during the login animation
    (LP: #1989170)

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 13 Oct 2022 22:00:20 +0200

[Andreas Hasenack (ahasenack)]

The bug description says the problem also occurs in kinetic wayland. Is kinetic being skipped on purpose, or will it also get an upload?

[Andreas Hasenack (ahasenack)]

Oh, sorry, I just saw the kinetic upload and release, n/m.

[Andreas Hasenack (ahasenack)]

Hello Daniel, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/72~ubuntu5.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Daniel van Vugt (vanvugt)]

Seems I can't reproduce the bug on jammy anymore. Neither real hardware nor nested are showing the bug. So I am hesitant to verify a fix for a problem I can't reproduce.

[Marco Trevisan (Treviño) (3v1n0)]

Test case ran using

❯ apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 72~ubuntu5.22.04.2
  Candidate: 72~ubuntu5.22.04.2
  Version table:
 *** 72~ubuntu5.22.04.2 400
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status

Docks shows at the right time and no regression happening.

Same using a script to simulate monitor changes during startup.

[Timo Aaltonen (tjaalton)]

Hello Daniel, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/72~ubuntu5.22.04.2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

Tested again new version, all good:

apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 72~ubuntu5.22.04.2.1
  Candidate: 72~ubuntu5.22.04.2.1
  Version table:
 *** 72~ubuntu5.22.04.2.1 400
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     72~ubuntu5.22.04.1 500
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main i386 Packages
     72~ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/main i386 Packages

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72~ubuntu5.22.04.2.1

---------------
gnome-shell-extension-ubuntu-dock (72~ubuntu5.22.04.2.1) jammy; urgency=medium

  * Keep shell overview always visible and usable (LP: #1979096):
    - docking: Do ControlsManagerLayout allocation with box-adjusted workArea
    - docking: Be more consistent in reducing the overlay layout space
    - docking: Add both bottom and top spacing when there are no workspaces

gnome-shell-extension-ubuntu-dock (72~ubuntu5.22.04.2) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/control: Update maintainer to myself
  * Ensure startup animations are performed on monitor changes (LP: #2019751):
    - utils: Ensure we destroy the Signals handler as last thing on destroy
    - docking: Do not wait for dash animation two times with no overview
    - docking: Ensure we perform the startup animation completely on docks
      updates (LP: #1965208)
    - docking: Use a try/catch statement on our promise to show errors in case
    - docking: Cleanup startup animation injections once done
    - docking: Handle monitors changed events while preparing startup animation
    - docking: Keep clip and coverPane size matching current setup
    - docking: Handle when dash is destroyed during the login animation
  * Do not hide the dock when menus are closed (LP: #1983130):
    - docking: Ignore hover changes if overview is visible (LP: #1983130)
    - docking: Check if autohide or intellihide is enabled on menu closed
  * Keep shell overview always visible and usable (LP: #1979096):
    - docking: Also reduce the app grid area when in auto-hide mode
      (LP: #1992847)
    - docking: Use an even width for the overview content area
    - docking: Keep overview controls layout proportions when resizing it
      (LP: #1992847)

  [ Daniel van Vugt ]
  * docking: Handle when dash is destroyed during the login animation
    (LP: #2019751)

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 02 Jun 2023 04:12:06 +0200