[jammy] gnome-shell memory usage spikes when deleting files in Nautilus if dash-to-dock show-trash is enabled

[Daniel van Vugt]

gnome-shell memory usage spikes when deleting files in Nautilus if dash-to-dock show-trash is enabled.

For example if I delete 1500 files in Nautilus then gnome-shell suddenly gets 15MB bigger. It does mostly come back down within about 10 seconds, but still not ideal for performance.

The same bug does not occur with upstream dash-to-dock so it looks like this has been fixed somewhere, but not yet in jammy.

WORKAROUND:
gsettings set org.gnome.shell.extensions.dash-to-dock show-trash false

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: gnome-shell-extension-ubuntu-dock 72~ubuntu3
ProcVersionSignature: Ubuntu 5.15.0-18.18-generic 5.15.12
Uname: Linux 5.15.0-18-generic x86_64
ApportVersion: 2.20.11-0ubuntu78
Architecture: amd64
CasperMD5CheckResult: pass
Date: Wed Mar 2 14:06:54 2022
InstallationDate: Installed on 2021-11-05 (116 days ago)
InstallationMedia: Ubuntu 22.04 LTS "Jammy Jellyfish" - Alpha amd64 (20211103)
PackageArchitecture: all
SourcePackage: gnome-shell-extension-ubuntu-dock
UpgradeStatus: No upgrade log present (probably fresh install)

[Daniel van Vugt (vanvugt)]

Doesn't seem to be a problem in dashtodock, only ubuntu-dock.

[Daniel van Vugt (vanvugt)]

It appears this line:

  this._monitor.set_rate_limit(UPDATE_TRASH_DELAY);

which is only used in ubuntu-dock actually doesn't work. I still get signal floods of _onTrashChange().

[Daniel van Vugt (vanvugt)]

Umm yeah, glib doesn't do anything with it:

    case PROP_RATE_LIMIT:
      /* not supported by default */
      break;

[Daniel van Vugt (vanvugt)]

Fix proposed: https://github.com/micheleg/dash-to-dock/pull/1678

[Daniel van Vugt (vanvugt)]

Bumped priority because some combination of slower systems deleting more files (than I do in testing) will result in people experiencing this as bug 1876641 again.

[Daniel van Vugt (vanvugt)]

Fix re-committed here: https://github.com/micheleg/dash-to-dock/commits/ubuntu-dock

[Daniel van Vugt (vanvugt)]

Hmm, debuild -S put the wrong (upstream) project name in the tarball. Is there a way to automate/avoid that?

[Jeremy Bícha (jbicha)]

I uploaded this to jammy unapproved for you and am unsubscribing ubuntu-sponsors.

The tarball name isn't really an issue. If we used debian/source/format 3.0 (quilt), I think the tarball would look more like what you'd expect. But it's too late to change that for jammy.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72~ubuntu4

---------------
gnome-shell-extension-ubuntu-dock (72~ubuntu4) jammy; urgency=medium

  * locations: Reintroduce manual rate limiting for trash monitoring to
    avoid large memory spikes and leaks when Nautilus deletes files
    (LP: #1962699)

 -- Daniel van Vugt <email address hidden> Tue, 12 Apr 2022 16:01:16 +0800