channel parsing is too loose

[Corey Bryant]

Hello,

I believe the following should fail due to specifying an invalid channel:

ubuntu@coreycb-bastion:~$ juju deploy ch:keystone --channel stable/yoga
Located charm "keystone" in charm-hub, revision 539

ubuntu@coreycb-bastion:~$ juju status keystone
Model Controller Cloud/Region Version SLA Timestamp
cb2 coreycb-serverstack serverstack/serverstack 2.9.23 unsupported 19:40:54Z

App Version Status Scale Charm Store Channel Rev OS Message
keystone waiting 0/1 keystone charmhub stable 539 ubuntu waiting for machine
...

There isn't a stable/yoga channel for this charm. What was deployed is the latest/stable version.
https://charmhub.io/keystone

Thanks,
Corey

[Simon Richardson (simonrichardson)]

So currently branches are correctly not supported. What you're actually seeing here is the dropping of the branch. Charmhub didn't originally support branches, so there wasn't a way to implement or verify the implementation.

I'll investigate the work required for this to happen.

[John A Meinel (jameinel)]

Do we want to support branches with just a 2 term syntax? I guess
'stable/candidate/beta/edge' are all fixed strings, so it probably isn't
ambiguous. I just wonder if it is ambiguous to users.

On Fri, Feb 18, 2022 at 7:50 AM Simon Richardson <email address hidden>
wrote:

> So currently branches are correctly not supported. What you're actually
> seeing here is the dropping of the branch. Charmhub didn't originally
> support branches, so there wasn't a way to implement or verify the
> implementation.
>
> I'll investigate the work required for this to happen.
>
> ** Changed in: juju
> Status: New => Triaged
>
> ** Changed in: juju
> Importance: Undecided => Medium
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1961107
>
> Title:
> channel parsing is too loose
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1961107/+subscriptions
>
>

[Simon Richardson (simonrichardson)]

WIP PR: https://github.com/juju/juju/pull/13765