dpkg-source should fail if maintainer is not ubuntu and DEBEMAIL contains @canonical.com
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dpkg (Debian) |
Fix Released
|
Unknown
|
|||
dpkg (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Brian Murray | ||
Impish |
Fix Released
|
Undecided
|
Brian Murray |
Bug Description
[Impact]
dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com
[Test Case]
In a source package that doesn't have XSBC-Original-
1) <email address hidden> debuild -i -I -S -d
With version of the dpkg in the release pocket you'll receive a warning, with the version of the package from -updates you'll instead receive an error.
dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-source: info: using options from sed-4.8/
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -b . subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -S -d failed
[Other Info]
Having every Ubuntu user update dpkg for a change that'll only benefit Ubuntu developers seems like a bit much. So instead we'll stage this in -proposed and in the event there is an SRU of dpkg or a security update we'll get this included.
Changed in dpkg (Debian): | |
status: | Unknown → New |
Changed in dpkg (Ubuntu): | |
importance: | Undecided → Low |
Changed in dpkg (Ubuntu Focal): | |
status: | New → In Progress |
Changed in dpkg (Ubuntu Impish): | |
status: | New → In Progress |
Changed in dpkg (Ubuntu Focal): | |
assignee: | nobody → Brian Murray (brian-murray) |
Changed in dpkg (Ubuntu Impish): | |
assignee: | nobody → Brian Murray (brian-murray) |
description: | updated |
tags: | added: block-proposed-focal block-proposed-impish |
description: | updated |
Changed in dpkg (Debian): | |
status: | New → Fix Released |
While I agree that this patch would be useful, it should be upstreamed first.