| 2021-11-23 17:39:57 |
William Wilson |
bug |
|
|
added bug |
| 2021-11-23 17:42:59 |
William Wilson |
attachment added |
|
dpkg.debdiff https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/1951988/+attachment/5542861/+files/dpkg.debdiff |
|
| 2021-11-23 17:43:40 |
William Wilson |
dpkg (Ubuntu): status |
New |
Confirmed |
|
| 2021-11-23 17:43:47 |
William Wilson |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2021-11-23 17:47:38 |
William Wilson |
summary |
dpkg-source should fail if maintainer is wrong and DEBEMAIL contains @canonical.com |
dpkg-source should fail if maintainer is not ubuntu and DEBEMAIL contains @canonical.com |
|
| 2021-11-24 22:09:15 |
William Wilson |
bug watch added |
|
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000557 |
|
| 2021-11-24 22:09:15 |
William Wilson |
bug task added |
|
dpkg (Debian) |
|
| 2021-11-27 03:36:31 |
Bug Watch Updater |
dpkg (Debian): status |
Unknown |
New |
|
| 2021-11-28 10:35:09 |
Mathew Hodson |
dpkg (Ubuntu): importance |
Undecided |
Low |
|
| 2021-12-03 10:06:35 |
Launchpad Janitor |
dpkg (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2021-12-15 19:42:29 |
Brian Murray |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2021-12-15 19:42:36 |
Brian Murray |
nominated for series |
|
Ubuntu Focal |
|
| 2021-12-15 19:42:36 |
Brian Murray |
bug task added |
|
dpkg (Ubuntu Focal) |
|
| 2021-12-15 19:42:36 |
Brian Murray |
nominated for series |
|
Ubuntu Impish |
|
| 2021-12-15 19:42:36 |
Brian Murray |
bug task added |
|
dpkg (Ubuntu Impish) |
|
| 2021-12-15 19:43:25 |
Brian Murray |
dpkg (Ubuntu Focal): status |
New |
In Progress |
|
| 2021-12-15 19:43:27 |
Brian Murray |
dpkg (Ubuntu Impish): status |
New |
In Progress |
|
| 2021-12-15 19:43:29 |
Brian Murray |
dpkg (Ubuntu Focal): assignee |
|
Brian Murray (brian-murray) |
|
| 2021-12-15 19:43:31 |
Brian Murray |
dpkg (Ubuntu Impish): assignee |
|
Brian Murray (brian-murray) |
|
| 2021-12-15 20:28:43 |
Brian Murray |
description |
dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com |
[Test Case]
In a source package that doesn't have XSBC-Original-Maintainer set run
1) DEBEMAIL=brian@canonical.com debuild -i -I -S -d
With version of the dpkg in the release pocket you'll receive a warning, with the version of the package from -updates you'll instead receive an error.
dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-source: info: using options from sed-4.8/debian/source/options: --single-debian-patch --auto-commit
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -b . subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -S -d failed
Original Description
--------------------
dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com |
|
| 2021-12-15 20:40:13 |
Brian Murray |
tags |
|
block-proposed-focal block-proposed-impish |
|
| 2021-12-15 21:05:22 |
Brian Murray |
description |
[Test Case]
In a source package that doesn't have XSBC-Original-Maintainer set run
1) DEBEMAIL=brian@canonical.com debuild -i -I -S -d
With version of the dpkg in the release pocket you'll receive a warning, with the version of the package from -updates you'll instead receive an error.
dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-source: info: using options from sed-4.8/debian/source/options: --single-debian-patch --auto-commit
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -b . subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -S -d failed
Original Description
--------------------
dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com |
[Impact]
dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com
[Test Case]
In a source package that doesn't have XSBC-Original-Maintainer set run
1) DEBEMAIL=brian@canonical.com debuild -i -I -S -d
With version of the dpkg in the release pocket you'll receive a warning, with the version of the package from -updates you'll instead receive an error.
dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-source: info: using options from sed-4.8/debian/source/options: --single-debian-patch --auto-commit
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -b . subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -S -d failed
[Other Info]
Having every Ubuntu user update dpkg for a change that'll only benefit Ubuntu developers seems like a bit much. So instead we'll stage this in -proposed and in the event there is an SRU of dpkg or a security update we'll get this included. |
|
| 2021-12-17 16:23:53 |
Brian Murray |
dpkg (Ubuntu Impish): status |
In Progress |
Fix Committed |
|
| 2021-12-17 16:23:55 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-12-17 16:23:58 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2021-12-17 16:24:01 |
Brian Murray |
tags |
block-proposed-focal block-proposed-impish |
block-proposed-focal block-proposed-impish verification-needed verification-needed-impish |
|
| 2021-12-17 16:25:11 |
Brian Murray |
dpkg (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2021-12-17 16:25:18 |
Brian Murray |
tags |
block-proposed-focal block-proposed-impish verification-needed verification-needed-impish |
block-proposed-focal block-proposed-impish verification-needed verification-needed-focal verification-needed-impish |
|
| 2022-01-05 05:36:53 |
Bug Watch Updater |
dpkg (Debian): status |
New |
Fix Released |
|
| 2022-01-21 16:37:22 |
Taihsiang Ho |
bug |
|
|
added subscriber Taihsiang Ho |
| 2022-05-26 13:37:35 |
Marc Deslauriers |
dpkg (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-05-26 13:37:39 |
Marc Deslauriers |
dpkg (Ubuntu Impish): status |
Fix Committed |
Fix Released |
|
