Submission page with french language pack

[Jonathan JUPIN]

Mahara 21.04
we tried in Linux and MacOs

When we install the french language pack, the submission page is blank and there is no error or log...

Submission page : mahara.xx/module/submissions/index.php?group=21

We saw it's because of "module.submissions.php", but we dont understand the problem.

Thank you

Jonathan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12249

[Kristina Hoeppner (kris-hoeppner)]

Hi Jonathan. Robert figured it out: The JavaScript in the template file theme/raw/plugintype/module/submissions/templates/index.tpl on line 741 used a single quote which would have to result in the escaping of the escaped backslash in the language string with the ID 'releasesubmission'. So we are fixing that up (patch for 'main' for review is at https://reviews.mahara.org/#/c/12249 and once approved will be backported to 21.04.

We think this to be a better fix than to require translators to use the following for the string:

$string['releasesubmission'] = 'Terminer l\\\'évaluation et déverrouiller le portfolio envoyé ?';

So if you want to apply the fix to your 21.04 instance and not wait until the next minor point release is out, please give it a go.

Thank you
Kristina

[Kristina Hoeppner (kris-hoeppner)]

To test:

1. Make sure the 'Submissions' plugin is not hidden.
2. Create a group and allow submissions.
3. As group member, submit a portfolio to the group. This step is technically not required, but it's good to check that everything is displayed on the page.
4. Install the French language pack and switch your language to French.
5. As group admin, go to the 'Submissions' tab in the group.

Results:
- Expected: The 'Quick filter' part is available and the submitted portfolio is displayed.
- Actual result without the patch: The 'Quick filter' part is missing and the submitted portfolio is not displayed.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12249
Committed: https://git.mahara.org/mahara/mahara/commit/bee7c07ae0509c4a74f9b7818cd4a8c53b373cee
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit bee7c07ae0509c4a74f9b7818cd4a8c53b373cee
Author: Kristina Hoeppner <email address hidden>
Date: Thu Nov 18 09:10:24 2021 +1300

Bug 1951103: Quick filter not displayed in submission

This happens when a language has an apostrophe in the language
string. Due to the JavaScript in the template file, the
apostrophe would have needed to be escaped as well. The fix
changes the code instead.

Change-Id: I7d1c51d896750f966b5894d60d8c9413b95c26a8

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12387

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12388

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12388
Committed: https://git.mahara.org/mahara/mahara/commit/64abe39517f71faf586e2f14c9e5c1b3de53ce2c
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 64abe39517f71faf586e2f14c9e5c1b3de53ce2c
Author: Kristina Hoeppner <email address hidden>
Date: Thu Nov 18 09:10:24 2021 +1300

Bug 1951103: Quick filter not displayed in submission

This happens when a language has an apostrophe in the language
string. Due to the JavaScript in the template file, the
apostrophe would have needed to be escaped as well. The fix
changes the code instead.

Change-Id: I7d1c51d896750f966b5894d60d8c9413b95c26a8
(cherry picked from commit bee7c07ae0509c4a74f9b7818cd4a8c53b373cee)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12387
Committed: https://git.mahara.org/mahara/mahara/commit/2af750e0c859f3b20dccc2dfc1512b0c66bf6732
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 2af750e0c859f3b20dccc2dfc1512b0c66bf6732
Author: Kristina Hoeppner <email address hidden>
Date: Thu Nov 18 09:10:24 2021 +1300

Bug 1951103: Quick filter not displayed in submission

This happens when a language has an apostrophe in the language
string. Due to the JavaScript in the template file, the
apostrophe would have needed to be escaped as well. The fix
changes the code instead.

Change-Id: I7d1c51d896750f966b5894d60d8c9413b95c26a8
(cherry picked from commit bee7c07ae0509c4a74f9b7818cd4a8c53b373cee)