Levovo T450 in Pro Dock: Plank is misplaced on screen

[S. W.]

[ Impact ]

 * The effect of this issue is that plank does not reset itself to the edge of the monitor when the resolution changes.
 * this can happen on one monitor when changing the resolution
 * it can happen in virtualbox (for example) when expanding/shrinking the screen which would force a resolution change
 * it also happens when connecting to a monitor with a laptop and changing the primary screen to the monitor. When the monitor is disconnected, the primary screen changes back to the laptop. If there is a resolution difference between the monitor and laptop, plank fails to relocate to the edge
 * in all cases plank either disappears from the screen, or ends up floating part way up the screen

[ Test Plan ]

 * See the impact how to reproduce this.
 * apt rdepends plank shows that plank is part of the ubuntu mate desktop as well as ubuntu budgie.
 * as such testing needs to cover both desktop environments
 * test 1: Budgie
 * choose one or more of the impacts and change the resolution of the screen via budgie-control-center / disconnect and/or reconnect monitors from a laptop or desktop
 * note - plank will disappear from the edge of the screen / reappear floating mid way in the screen.
 * Since the fix is in a patch for workspace changes, press CTRL+ALT left/right to change the workspace. Note that plank isn't impacted by changing the workspace.
 * test 2: mate
 * choose one or more of the impacts and change the resolution of the screen via mate-settings / disconnect and/or reconnect monitors from a laptop or desktop
 * note - plank reset itself correctly to the edge of the screen
 * Since the fix is in a patch for workspace changes, press CTRL+ALT left/right to change the workspace. Note that plank isn't impacted by changing the workspace.
 -
 * next install plank from the proposed repository - the following packages should be installed:
libplank1_0.11.89-4ubuntu1~22.04_amd64.deb
libplank-common_0.11.89-4ubuntu1~22.04_all.deb
plank_0.11.89-4ubuntu1~22.04_amd64.deb
 * Repeat the testing for both Mate and Budgie.
 * For Budgie in all cases plank will reset to the edge of the screen
 * For Mate in all cases plank will continue correctly to be reset to the edge of the screen - i.e. there should not be any regressions in this area of resolution changes

[ Where problems could occur ]

 * The original patch in question is one that Debian / Ubuntu specifically carries - it has not been accepted upstream (as of writing this).
 * The patch was specifically designed to fix switching workspace issues where plank did not correctly reset itself. The current patch breaks GNOME based desktops (X11) such as Budgie but fixes other desktops such as MATE.
 * The updated patch was accepted by the PR author and is now part of the overall revised patch.
 * I updated Lunar in March and thus is in both Ubuntu Mate and Ubuntu Budgie for several months now. No additional bugs have been reported to launchpad in this area.
 * This revised upload makes the plank package identical to lunar. As such the potential problems here are
 1. The same plank source behaving differently between Jammy versions of Budgie/Mate and Lunar
 2. The much wider LTS audience could find additional issues that Lunar users have not yet found
 * Given that the length of time of testing for the current lunar patch is now several months the risk is considered minimal. The regression potential of (2) is mitigated by killing plank and rerunning it.

[ Other Info ]

 * None

----

Ubuntu Budgie 21.10

When i'm using my T450 undocket everything is fine (Plank shows up in the center on the bottom of the screen).

As soon as i put my T450 in a ProDock (via propritary connector) with a 2nd monitor plank hops to about 1/3 from the top of the T450 screen (screenshot).

The 2nd monitor is placed on the right a litte bit higher than the laptop, so i arranged the Monitors in the setup alike (screenshot).

The behaviour was ok before 21.04, and still exists in 21.10.

"
[371366.276193] thinkpad_acpi: docked into hotplug port replicator
[371367.332802] usb 3-3: new SuperSpeed USB device number 9 using xhci_hcd
[371367.588987] usb 3-3: New USB device found, idVendor=17ef, idProduct=1012, bcdDevice=50.41
[371367.588993] usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[371367.588995] usb 3-3: Product: Lenovo ThinkPad Dock
[371367.588997] usb 3-3: Manufacturer: LENOVO
[371367.590685] hub 3-3:1.0: USB hub found
[371367.590815] hub 3-3:1.0: 4 ports detected
[371367.716712] usb 2-3: new high-speed USB device number 126 using xhci_hcd
[371367.870424] usb 2-3: New USB device found, idVendor=17ef, idProduct=1012, bcdDevice=50.40
[371367.870429] usb 2-3: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[371367.870431] usb 2-3: Product: Lenovo ThinkPad Dock
[371367.870432] usb 2-3: Manufacturer: LENOVO
[371367.871295] hub 2-3:1.0: USB hub found
[371367.871653] hub 2-3:1.0: 4 ports detected
[371367.981369] usb 3-3.2: new SuperSpeed USB device number 10 using xhci_hcd
[371368.044377] usb 3-3.2: New USB device found, idVendor=0bda, idProduct=0411, bcdDevice= 1.24
[371368.044383] usb 3-3.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[371368.044385] usb 3-3.2: Product: 2-Port USB 3.1 Hub
[371368.044387] usb 3-3.2: Manufacturer: Generic
[371368.051245] hub 3-3.2:1.0: USB hub found
[371368.053828] hub 3-3.2:1.0: 2 ports detected
[371368.180705] usb 2-3.2: new high-speed USB device number 127 using xhci_hcd
[371368.306805] usb 2-3.2: New USB device found, idVendor=0bda, idProduct=5411, bcdDevice= 1.24
[371368.306813] usb 2-3.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[371368.306815] usb 2-3.2: Product: 4-Port USB 2.1 Hub
[371368.306817] usb 2-3.2: Manufacturer: Generic
[371368.308055] hub 2-3.2:1.0: USB hub found
[371368.309639] hub 2-3.2:1.0: 4 ports detected
[371368.408713] usb 2-3.4: new high-speed USB device number 2 using xhci_hcd
[371368.524987] usb 2-3.4: New USB device found, idVendor=17ef, idProduct=1011, bcdDevice= 0.01
[371368.524994] usb 2-3.4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[371368.524997] usb 2-3.4: Product: Lenovo ThinkPad Dock
[371368.524998] usb 2-3.4: Manufacturer: Lenovo
[371368.525000] usb 2-3.4: SerialNumber: Rev1.2
[371368.525949] hub 2-3.4:1.0: USB hub found
[371368.526014] hub 2-3.4:1.0: 3 ports detected
[371368.608723] usb 2-3.2.4: new high-speed USB device number 3 using xhci_hcd
[371368.801511] usb 2-3.2.4: New USB device found, idVendor=174f, idProduct=1809, bcdDevice= 0.13
[371368.801517] usb 2-3.2.4: New USB device strings: Mfr=3, Product=1, SerialNumber=2
[371368.801520] usb 2-3.2.4: Product: Integrated RGB Camera
[371368.801522] usb 2-3.2.4: Manufacturer: Generic
[371368.801524] usb 2-3.2.4: SerialNumber: sdfsdf
[371368.807891] usb 2-3.2.4: Found UVC 1.10 device Integrated RGB Camera (174f:1809)
[371368.813435] input: Integrated RGB Camera: Integrat as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.2/2-3.2.4/2-3.2.4:1.0/input/input129
[371368.815145] usb 2-3.2.4: Found UVC 1.10 device Integrated RGB Camera (174f:1809)
[371368.817898] input: Integrated RGB Camera: Integrat as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.2/2-3.2.4/2-3.2.4:1.2/input/input130
[371368.824931] usb 2-3.4.1: new low-speed USB device number 4 using xhci_hcd
[371368.932599] usb 2-3.4.1: New USB device found, idVendor=05d5, idProduct=6782, bcdDevice= 1.01
[371368.932604] usb 2-3.4.1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[371368.932606] usb 2-3.4.1: Product: USB Keyboard
[371368.932608] usb 2-3.4.1: Manufacturer: ABBAHOME
[371368.949489] input: ABBAHOME USB Keyboard as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.4/2-3.4.1/2-3.4.1:1.0/0003:05D5:6782.0026/input/input131
[371369.009115] input: ABBAHOME USB Keyboard Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.4/2-3.4.1/2-3.4.1:1.0/0003:05D5:6782.0026/input/input132
[371369.009293] hid-generic 0003:05D5:6782.0026: input,hidraw1: USB HID v1.10 Keyboard [ABBAHOME USB Keyboard] on usb-0000:00:14.0-3.4.1/input0
[371369.088789] usb 2-3.4.2: new full-speed USB device number 6 using xhci_hcd
[371369.190888] usb 2-3.4.2: New USB device found, idVendor=046d, idProduct=c093, bcdDevice=53.00
[371369.190894] usb 2-3.4.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[371369.190895] usb 2-3.4.2: Product: Advanced Corded Mouse M500s
[371369.190897] usb 2-3.4.2: Manufacturer: Logitech
[371369.190898] usb 2-3.4.2: SerialNumber: sdfsdf
[371369.197350] input: Logitech Advanced Corded Mouse M500s as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.4/2-3.4.2/2-3.4.2:1.0/0003:046D:C093.0027/input/input133
[371369.256953] hid-generic 0003:046D:C093.0027: input,hidraw2: USB HID v1.11 Mouse [Logitech Advanced Corded Mouse M500s] on usb-0000:00:14.0-3.4.2/input0
[371369.258226] input: Logitech Advanced Corded Mouse M500s Keyboard as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.4/2-3.4.2/2-3.4.2:1.1/0003:046D:C093.0028/input/input134
[371369.316933] hid-generic 0003:046D:C093.0028: input,hiddev2,hidraw3: USB HID v1.11 Keyboard [Logitech Advanced Corded Mouse M500s] on usb-0000:00:14.0-3.4.2/input1
[371371.156770] usb 2-3.2.3: new full-speed USB device number 7 using xhci_hcd
[371371.508064] usb 2-3.2.3: New USB device found, idVendor=17ef, idProduct=a016, bcdDevice=80.51
[371371.508069] usb 2-3.2.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[371371.508071] usb 2-3.2.3: Product: ThinkVision T24v Wide Monitor for USB-Audio
[371371.508072] usb 2-3.2.3: Manufacturer: Lenovo
[371371.508073] usb 2-3.2.3: SerialNumber: 000000000000
[371371.579498] usb 2-3.2.3: 1:1: cannot get freq at ep 0x81
[371371.581952] usb 2-3.2.3: 2:1: cannot get freq at ep 0x1
[371371.720183] input: Lenovo ThinkVision T24v Wide Monitor for USB-Audio Consumer Control as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.2/2-3.2.3/2-3.2.3:1.3/0003:17EF:A016.0029/input/input137
[371371.777026] input: Lenovo ThinkVision T24v Wide Monitor for USB-Audio as /devices/pci0000:00/0000:00:14.0/usb2/2-3/2-3.2/2-3.2.3/2-3.2.3:1.3/0003:17EF:A016.0029/input/input138
[371371.777259] hid-generic 0003:17EF:A016.0029: input,hiddev3,hidraw4: USB HID v1.00 Device [Lenovo ThinkVision T24v Wide Monitor for USB-Audio] on usb-0000:00:14.0-3.2.3/input3
[371372.526824] usb 2-3.2.3: 1:1: cannot get freq at ep 0x81
"

[fossfreedom (fossfreedom)]

Can confirm.

This is most probably because the current plank package contains this extra patch added by Debian - dropping this patch should resolve this.

https://github.com/ricotz/plank/pull/6

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[fossfreedom (fossfreedom)]

Current workaround would be to kill plank and restart it - something like

killall plank; sleep 2; nohup plank &

That could be connected to a manually created keyboard shortcut.

[Jan Maleček (malecek)]

Can confirm, it would be probably the same with me. I have fresh install of Xubuntu 21.10.

Scenario:
- start system with display 1920x1080, plank is properly aligned on the bottom
- plug in dock with display 1920x1200, switch to this display
- plank stays in original position (120px above bottom display border; screenshot attached)

I have been using it in 20.04 and scenario above worked fine - after changing display plank was properly aligned.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[fossfreedom (fossfreedom)]

This has been resolved by the upstream pull request https://github.com/ricotz/plank/pull/6

So the plank package needs to refresh the patch 0001_changed-plank-positioning-according-to-workarea.patch

Working on this.

NOTE: I've filed a separate bug report with Debian a while back. I'll send a debdiff via this bug report for Debian's consideration

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022701

[Launchpad Janitor (janitor)]

This bug was fixed in the package plank - 0.11.89-4ubuntu1

---------------
plank (0.11.89-4ubuntu1) lunar; urgency=medium

  * refresh 0001_changed-plank-positioning-according-to-workarea.patch
    from upstream pull request
    This ensures GNOME based desktops use the original calculation to
    prevent plank misalignment issues when the resolution changes
    (LP: #1949741)
  * Packaging Changes
    d/control Update plank-dev dependency to remove obsolete dependency
     libgdk-pixbuf2.0-dev (>= 2.26.0) => libgdk-pixbuf-2.0-dev

 -- David Mohammed <email address hidden> Mon, 17 Oct 2022 09:42:39 +0100

[fossfreedom (fossfreedom)]

kinetic is EOL - marking as won't fix

[Robie Basak (racb)]

Reviewing your Jammy upload, your chosen version of 0.11.89-4ubuntu1~22.04 seems odd, especially because this isn't strictly a backport of 0.11.89-4ubuntu1 as debian/control has an unrelated change. I would have expected the version to be 0.11.89-4ubuntu0.1 or 0.11.89-4ubuntu0.22.04.1 if it was prepared/uploaded before the Kinetic EOL. Please see https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging for a scheme that works.

However, the version happens to work as is in this case so I'm not going to delay this further. Thank you for working on this!

[Robie Basak (racb)]

Hello S., or anyone else affected,

Accepted plank into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/plank/0.11.89-4ubuntu1~22.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[fossfreedom (fossfreedom)]

Testing using ubuntu budgie 22.04.3 - confirmed that changing resolution smaller/larger that plank did not reset its screen-edge.

After install v0.11.89-4ubuntu1~22.04 of plank and restarted plank repeating the same test plank correctly reset its screen-edge

[fossfreedom (fossfreedom)]

Testing using ubuntu mate 22.04.3:

Noted that the test plan instructions for ubuntu mate was incorrect - the default plank did not reset its screen-edge when changing resolutions.

After install v0.11.89-4ubuntu1~22.04 of plank and restarted plank repeating the same test plank did not again reset its screen-edge. This therefore isnt a regression and plank under mate is behaving exactly the same.

Thus I'm marking this a fixed. A separate issue should be created for plank under mate to resolve and to-do a wider check for jammy/lunar/mantic

[Launchpad Janitor (janitor)]

This bug was fixed in the package plank - 0.11.89-4ubuntu1~22.04

---------------
plank (0.11.89-4ubuntu1~22.04) jammy; urgency=medium

  * Bug-fix
    refresh 0001_changed-plank-positioning-according-to-workarea.patch
    from upstream pull request.
    This ensures GNOME based desktops use the original calculation to
    prevent plank misalignment issues when the resolution changes
    (LP: #1949741)

 -- David Mohammed <email address hidden> Wed, 26 Jul 2023 20:33:22 +0100

[Robie Basak (racb)]

The verification of the Stable Release Update for plank has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.