wrong panel size 21.10

[sles]

[Impact]

This affects users of gnome-panel which have many applets, including some applets on the center. It is a regression introduced between Hirsute and Impish.

[Test Plan]

1. Install gnome-session-flashback and gnome-applets packages and log in into the GNOME Flashback (Metacity) session.
2. Right-click on the top panel and select “Add to Panel…”.
3. Add to center some applets which occupy large space, like CPU Frequency Scaling Monitor.

Bad behavior: applets on the right side are pushed outside of the screen.

Expected behavior: applets on the center are shifted to the left to free room for the applets on the right side.

[Where problems could occur]

The fix is changing the function which computes positions of panel applets. So the regression potential will be limited to positioning.

Also the added code is not new, it was present in gnome-panel until https://gitlab.gnome.org/GNOME/gnome-panel/-/commit/9d6c76aa58ef3e9c.

[Dmitry Shachnev (mitya57)]

Can you please re-attach your screenshot without Russian letters in file name? I cannot open it because of bug 1946762.

[Alberts Muktupāvels (muktupavels)]

What is "use all screen option"?

[sles (slesru)]

Alberts, this is first option on screenshot.

[Alberts Muktupāvels (muktupavels)]

Oh, original untranslated text for that option is "Expand".

Please show output of `apt-cache policy gnome-panel`. Your screenshot is missing new setting...

[sles (slesru)]

Thank you! This screenshot is from 20.04 - my home desktop- just to illustrate option name.
Here is from 21.10.

[sles (slesru)]

apt-cache policy gnome-panel
gnome-panel:
  Установлен: 1:3.41.2-2ubuntu1
  Кандидат: 1:3.41.2-2ubuntu1
  Таблица версий:
 *** 1:3.41.2-2ubuntu1 500
        500 http://ru.archive.ubuntu.com/ubuntu impish/universe amd64 Packages
        100 /var/lib/dpkg/status

[sles (slesru)]

And here is panel screenshot with Expand on, this is right upper corner...

[Alberts Muktupāvels (muktupavels)]

Could you please post screenshot of whole desktop? Maybe also open display settings so screenshot include also your monitor configuration.

Have you tried to create new user? If not could you try that to see if problem might be related to some configuration?

[sles (slesru)]

Hello!

Here is screenshot.
I'll try with another user asap and report.
Thank you!

[sles (slesru)]

Yes, you are right. Test new user has no such problem.. Very interesting...

[sles (slesru)]

OK, problem is caused by applet with disk drives, once I removed it everything became good.
So, looks like this is applet problem. btw, I don't remember it's name :-D , so I can't restore it, will look at home desktop later.

Anyway, I think this is not bug of panel.
Thank you!

[sles (slesru)]

I found it , in translation from russian it's name is "mounting drive". I restored it and ... panel has right size! So, anyway, there is workaround for this problem...

[sles (slesru)]

No, after I moved applet I have this problem again. I'll post screenshots, I think this is panel bug.

[sles (slesru)]

applet on left, everything is fine

[sles (slesru)]

applet on the right, problem is here

[Dmitry Shachnev (mitya57)]

The applet is called drivemount, and it's part of gnome-applets.

By the way, you can use this command to use light icons which will have better contrast:

gsettings set org.gnome.desktop.interface icon-theme ubuntu-mono-dark

[sles (slesru)]

Dmitry, thank you.
I just tried different applet, namely brightness, and have the same result- moving it to the right results in too wide panel.
So this is not applet problem.
btw, I don't like contrast screen :-)

[Alberts Muktupāvels (muktupavels)]

Thanks! This does look like problem with gnome-panel.

The problem is centered applets. You have centered applet/applets that are not pushed/moved to left side to make room for all applets on the right side. You did not move back to right side, you moved it to center.

Workaround might be to try to move/reorder applets to ensure they are on right side without centered applets. Use Alt + Right click on disk applet move closer to right side. This should make applet from centered to right side applet. Repeat with next applet that is closer to center until you reorder applets in order you want.

Next release will have new tab that will show added applets on panel grouped by applets side (left, center, right) - https://gitlab.gnome.org/GNOME/gnome-panel/-/merge_requests/41. But that will be available only in 22.04.

Please open upstream bug here - https://gitlab.gnome.org/GNOME/gnome-panel/-/issues. I will try to fix this when I have more time and then Dmitry will try to add patch to 21.10.

[sles (slesru)]

Thank you, I created issue.

[sles (slesru)]

Alberts, thank you for fixing this upstream. I hope this fix will be in 22.04 :-)

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-panel - 1:3.42.0-1ubuntu1

---------------
gnome-panel (1:3.42.0-1ubuntu1) jammy; urgency=medium

  * Merge with Debian unstable, remaining changes:
    - debian/changelog:
      + Use an epoch in version number.
    - debian/control.in:
      + Recommend indicator-applet.
      + Use Ubuntu VCS fields.
    - debian/rules:
      + Explicitly build without -Bsymbolic-functions flag.
    - debian/patches/40_unset_menuproxy.patch:
      + Make sure panel and applets do not pick up menu proxies.
    - debian/ubuntu.layout, debian/gnome-panel-data.*:
      + Add the layout file for Ubuntu.
      + Make it default using a gsettings-override file.
  * New release fixes regression that caused applets to be pushed out of
    the panel (LP: #1947553).

 -- Dmitry Shachnev <email address hidden> Sun, 24 Oct 2021 13:42:10 +0300

[sles (slesru)]

Thank you! Is there plan to backport fix to 21.10?
Really, I rearranged applets and now I have good combination which works for me :-)

[Dmitry Shachnev (mitya57)]

Maybe next weekend. I don't have much time this week.

[Alberts Muktupāvels (muktupavels)]

In meantime you can try update bug description to match this template - https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template. This will be requirement for update.

[Brian Murray (brian-murray)]

Hello sles, or anyone else affected,

Accepted gnome-panel into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-panel/1:3.41.2-2ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[sles (slesru)]

Hello!
Thank you!
Unfortunately my work desktop is out of my reach for next several days, so I will be able to do test only at Monday :-(
Minin and Pozharsky and, definitely, Poland's intervention are still delaying us ;-)

[Dmitry Shachnev (mitya57)]

Haha. No problem, the package won't be moved to updates before November 10th anyway (7 days should pass).

[sles (slesru)]

LANG=C dpkg -l gnome-panel
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-=================-============-==========================================
ii gnome-panel 1:3.41.2-2ubuntu2 amd64 traditional panel, used in GNOME Flashback

fixed problem.
moved around applets and panel size is always right.

[Robie Basak (racb)]

The verification of the Stable Release Update for gnome-panel has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-panel - 1:3.41.2-2ubuntu2

---------------
gnome-panel (1:3.41.2-2ubuntu2) impish; urgency=medium

  * Backport upstream patch to shift applets to the left in case center
    applets push right side applets outside (LP: #1947553).

 -- Dmitry Shachnev <email address hidden> Sun, 31 Oct 2021 21:18:53 +0300