plf-colony simple.cc test fails with "stderr: dis_syslink(ppc)(theInstr)" on ppc64el with glibc 2.33

[Frank Heimes]

The simple.cc test of plf-colony fails on ppc64el with "stderr: dis_syslink(ppc)(theInstr)" if glibc 2.33 is in use (hence on hirsute).

The test doesn't break entirely, but two lines are written to stderr that make the overall test to fail:
"
autopkgtest [06:59:07]: test simple-gcc-valgrind:
dis_syslink(ppc)(theInstr)
dis_syslink(ppc)(theInstr)
 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
"

This turned out to be the root problem for the blocked transition of valgrind:
valgrind | 1:3.16.1-1ubuntu3 | hirsute-proposed
https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#valgrind
The autopackage test fails for ppc64el only:
"autopkgtest for plf-colony/6.12-1: amd64: Pass, arm64: Pass, armhf: Pass, ppc64el: Regression ♻ , s390x: Pass"

And the logs point to the above mentioned issue:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/ppc64el/p/plf-colony/20210224_065926_061e7@/log.gz
"
autopkgtest [06:59:07]: test simple-gcc-valgrind: g++ -Wall -o "$AUTOPKGTEST_TMP"/⁊ debian/tests/simple.cc && valgrind --error-exitcode=1 -q "$AUTOPKGTEST_TMP"/⁊ autopkgtest [06:59:07]: test simple-gcc-valgrind: [-----------------------
dis_syslink(ppc)(theInstr)
dis_syslink(ppc)(theInstr)
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 autopkgtest [06:59:09]: test simple-gcc-valgrind: -----------------------] autopkgtest [06:59:10]: test simple-gcc-valgrind: - - - - - - - - - - results - - - - - - - - - - simple-gcc-valgrind FAIL stderr: dis_syslink(ppc)(theInstr) autopkgtest [06:59:10]: test simple-gcc-valgrind: - - - - - - - - - - stderr - - - - - - - - - - dis_syslink(ppc)(theInstr) dis_syslink(ppc)(theInstr) autopkgtest [06:59:11]: @@@@@@@@@@@@@@@@@@@@ summary simple-gcc PASS simple-clang PASS simple-gcc-valgrind FAIL stderr: dis_syslink(ppc)(theInstr)
"

This is not a regression in the updated valgrind package itself (3.16.1-1ubuntu3) since it also happens on groovy if one just upgrades glibc to 2.33 (taken from hirsute).

Ideally this should be fixed in glibc 2.33, but due to the complexity a different approach will be taken and the simple.cc test in plf-colony adjusted like this:
# g++ -Wall -o "$AUTOPKGTEST_TMP"/⁊ debian/tests/simple.cc && valgrind --error-exitcode=1 -q "$AUTOPKGTEST_TMP"/⁊ 2>/dev/null
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
(by making sure that the return code is still valid and true)

[Florian Weimer (fweimer)]

This is a valgrind bug: https://bugs.kde.org/show_bug.cgi?id=431157

[Frank Heimes (fheimes)]

Since this is going to be solved (in a better way) by picking the valgrind commit
ea98cccb4 "Filter out unsupported instructions from HWCAP2 on powerpc" (thx to Florian)
in valgrind package 3.16.1-1ubuntu4, which is already in hirsute-proposed (thx to Dimitri)
I'm marking the plf-colony entry as Invalid.

[Launchpad Janitor (janitor)]

This bug was fixed in the package valgrind - 1:3.16.1-1ubuntu4

---------------
valgrind (1:3.16.1-1ubuntu4) hirsute; urgency=medium

  * Add powerpc fixes. LP: #1916749

valgrind (1:3.16.1-1ubuntu3) hirsute; urgency=medium

  * No change rebuild with fixed ownership.

valgrind (1:3.16.1-1ubuntu2) hirsute; urgency=medium

  * debian/patches/lp-1825343-Bug-404076-s390*.patches
    adding support for IBM z14 instructions to Valgrind
    backported three commits from valgrind > v3.16.1
    Thanks to Andreas Arnez (LP: #1825343)

 -- Dimitri John Ledkov <email address hidden> Thu, 25 Feb 2021 16:11:02 +0000