[SRU] ruby2.5 DEP-8 tests are failing in Bionic
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ruby2.5 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
The ruby2.5 DEP-8 tests are failing since ever, so there is no good way to caught regressions automatically (via autopkgtest). This impacts our ability to provide updates to this package more reliably.
Below is a list of the failing tests and the reason:
* run-all: This DEP-8 test runs upstream tests. Some tests are failing because the tzdata package was updated in Bionic, a couple of upstream patches need to be backported to fix this, they are:
https:/
https:/
Take a look at this upstream bug: https:/
* bundled-gems: This DEP-8 test checks if some gems supposed to be bundled with the interpreter (in our case they are separate packages) are available in the system with the expected version constraints. Some gems were shipped in Bionic with versions not expected by the ruby upstream maintainers, and they are making this test to fail:
- power_assert: upstream expects version >= 1.1.1. Bionic has version 0.3.0-1 but actually it contains 0.2.7, look at the gemspec: /usr/share/
- test-unit: upstream expects version >= 3.2.7. Bionic has version 3.2.5-1.
- xmlrpc: upstream expects version >= 0.3.0. This package is not available in Bionic, just from Focal onwards.
We should ignore them since there is nothing we can do at this point. AFAIK there is no severe issue caused by those versions mismatch.
* rubyconfig: This DEP-8 test checks for the ruby config. Currently it fails because of a call to dpkg-architecture which is printing a warning to stderr:
$ dpkg-architecture -qDEB_HOST_
dpkg-architecture: warning: cannot determine CC system type, falling back to default (native compilation)
x86_64-linux-gnu
An allow-stderr restriction can be added to fix this.
[Test Case]
At the moment ruby2.5 FTBFS in Bionic, so first apply the fix proposed in LP #1903902 and then run autopkgtest against it:
$ dget -u https:/
$ cd ruby2.5-2.5.1
# Add tzdata as a build dependency
$ autopkgtest -U . -- lxd ubuntu-daily:bionic
Here is the autopkgtest output: https:/
With the fixes proposed above the tests pass successfully.
[Potential Regression]
There is no regression since the tests have been failing. The proposed changes are all related to tests only, except the TZ patches but they fix some covered issues with a very specific TZ (Kiritimati). So if there is room for a regression it will be related to TZ.
Related branches
- Bryce Harrington (community): Approve
- Canonical Server: Pending requested
- git-ubuntu developers: Pending requested
-
Diff: 397 lines (+331/-1)8 files modifieddebian/changelog (+19/-0)
debian/control (+1/-0)
debian/patches/0029-Backport-upstream-patch-to-fix-Kiritimati-TZ-test-1-.patch (+58/-0)
debian/patches/0030-Backport-upstream-patch-to-fix-Kiritimati-TZ-test-2-.patch (+46/-0)
debian/patches/arm64-optimizations.patch (+179/-0)
debian/patches/series (+3/-0)
debian/tests/bundled-gems (+24/-1)
debian/tests/control (+1/-0)
Changed in ruby2.5 (Ubuntu): | |
status: | New → Fix Released |
Hello Lucas, or anyone else affected,
Accepted ruby2.5 into bionic-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ ruby2.5/ 2.5.1-1ubuntu1. 7 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification- needed- bionic to verification- done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- bionic. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.