Regression: landscape-config fails to surface registration error

[Simon Poirier]

When attempting to register with invalid info, landscape-config simply timeouts without return the server error or status:

# landscape-config --log-level=debug --silent -p foo -a foobar
Created symlink /etc/systemd/system/multi-user.target.wants/landscape-client.service → /lib/systemd/system/landscape-client.service.
Please wait...
Traceback (most recent call last):
Failure: landscape.lib.amp.MethodCallError: timeout
#echo $?
0

In the broker logs, we can clearly see the request was rejected by the server

2020-07-29 14:57:47,766 DEBUG [PoolThread-twisted.internet.reactor-0] Sending payload:
{'accepted-types': b'\xbfx\xda\xf36\x9bK\x84\xe5P\x07p\xd7\x97\xf6\xb0',
 'client-accepted-types': ['accepted-types',
                           'add-group',
                           'add-group-member',
                           'add-user',
                           'apt-sources-replace',
                           'change-package-locks',
                           'change-packages',
                           'edit-group',
                           'edit-user',
                           'lock-user',
                           'package-ids',
                           'registration',
                           'release-upgrade',
                           'remove-group',
                           'remove-group-member',
                           'remove-user',
                           'resynchronize',
                           'set-id',
                           'set-intervals',
                           'shutdown',
                           'signal-process',
                           'unknown-id',
                           'unlock-user'],
 'client-api': b'3.8',
 'messages': [{'account_name': 'foobar',
               'api': b'3.3',
               'computer_title': 'simpoir-pad',
               'container-info': '',
               'hostname': 'moosey.she.simpoir.com',
               'registration_password': 'foo',
               'tags': None,
               'timestamp': 1596049067,
               'type': 'register',
               'vm-info': b''}],
 'next-expected-sequence': 4,
 'sequence': 1,
 'server-api': b'3.3',
 'total-messages': 1}
2020-07-29 14:57:47,766 INFO [MainThread] Message exchange completed in 0.56s.
2020-07-29 14:57:48,378 INFO [PoolThread-twisted.internet.reactor-0] Sent 778 bytes and received 141 bytes in 0.61s. 2020-07-29 14:57:48,378 DEBUG [PoolThread-twisted.internet.reactor-0] Received payload:
{'messages': [{'info': b'unknown-account', 'type': b'registration'}],
 'server-api': '3.3',
 'server-uuid': b'f1a65772-c771-11ea-927a-0017a48f36ae'}

This looks like a regression of (LP: #271759). I suspect it has been there almost as long as python3 support in landscape-client.

[Simon Poirier (simpoir)]

https://github.com/CanonicalLtd/landscape-client/pull/87

[Launchpad Janitor (janitor)]

This bug was fixed in the package landscape-client - 23.02-0ubuntu1

---------------
landscape-client (23.02-0ubuntu1) lunar; urgency=medium

  * New upstream release 23.02:
    - Preventing the generation of large messages and logs that can overwhelm
      Landscape Server (LP: #1995775)
    - Improved MOTD slowdown on machines with many tap network interfaces
      (LP: #2006396)
    - No longer using deprecated apt-key when storing trusted GPG keys
      (LP: #1973202)
    - Fixed issue recognising Parallels VMs as Virtual Machine clients
      (LP: #1827909)
    - Fixes for incorrect logfile rotation config (LP: #1968189)
    - Client-side backoff handling to moderate traffic to Landscape Server
      during high load (LP: #1947399)
    - Avoid sending empty messages when catching up to expected next message
      (LP: #1917540)
    - --is-registered CLI option to quickly check if client is registered
      (LP: #1912516)
    - Can now report Ubuntu Pro attachment information if the version of
      Landscape Server it is registered to supports this (LP: #2006401)
    - Packages installed as dependencies as part of package profiles are now
      appropriately autoremovable (LP: #1878957)
    - Registration timeouts give an error instead of timing out (LP: #1889464)
    - RHEV hypervisor VMs are now recognized as virtual machines (LP: #1884116)
    - Doing a Landscape-driven release upgrade from a release running python 2
      to one running python 3 no longer hangs forever (LP: #1943291)

 -- Mitch Burton <email address hidden> Wed, 08 Feb 2023 10:23:31 -0800