curtin install hook fails with No closing quotation on new 20.04 install

[Shawn Weeks]

While doing a new install of 20.04 Server to Software Raid 1 the installation fails while running one of the curtin hooks related to udevadm_info. I'm including the complete crash log.

[Shawn Weeks (absolutesantaja)]

Here is the output from udevadm info --query=property --export /dev/sdc1. Note /dev/sdc1 is the USB Drive being used to install ubuntu.

[Shawn Weeks (absolutesantaja)]

It looks like the issue is SanDisk is including quotes in their device names. Not sure who's problem this actually is. udevadm?

[Shawn Weeks (absolutesantaja)]

This failure doesn't happen on the same usb drive for 18.04

[Shawn Weeks (absolutesantaja)]

https://stackoverflow.com/questions/57483794/python-shlex-no-closing-quotations-error-how-to-deal-with

[Ubuntu Foundations Team Bug Bot (crichton)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1875085/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

[Shawn Weeks (absolutesantaja)]

Using ioreg on MacOS also shows that SanDisk used a quote in the USB Vendor Name. I have around 30 of these drives and everyone I've checked has that quote in the vendor name.

Cruzer Fit@14620000 <class AppleUSBDevice, id 0x1000012a8, registered, matched, active, busy 0 (0 ms), ret$
{
  "sessionID" = 13159280608063
  "idProduct" = 21873
  "iManufacturer" = 1
  "bDeviceClass" = 0
  "bMaxPacketSize0" = 64
  "bcdDevice" = 256
  "iProduct" = 2
  "iSerialNumber" = 3
  "bNumConfigurations" = 1
  "Bus Power Available" = 250
  "USB Address" = 13
  "Built-In" = No
  "locationID" = 341966848
  "bDeviceSubClass" = 0
  "bcdUSB" = 512
  "USB Product Name" = "Cruzer Fit"
  "PortNum" = 2
  "non-removable" = "yes"
  "AppleUSBAlternateServiceRegistryID" = 4294972070
  "bDeviceProtocol" = 0
  "IOCFPlugInTypes" = {"9dc7b780-9ec0-11d4-a54f-000a27052861"="IOUSBHostFamily.kext/Contents/PlugIns/IOUSBL$
  "IOPowerManagement" = {"DevicePowerState"=0,"CurrentPowerState"=3,"CapabilityFlags"=65536,"MaxPowerState"$
  "kUSBCurrentConfiguration" = 1
  "Device Speed" = 2
  "USB Vendor Name" = "SanDisk'"
  "idVendor" = 1921
  "uid" = "USB:07815571190118216300"
  "IOGeneralInterest" = "IOCommand is not serializable"
  "USB Serial Number" = "4C530000190118216300"
  "IOClassNameOverride" = "IOUSBDevice"
}

[Ryan Harper (raharper)]

Thanks for the bug report and pointer to the shlex.quote().

[Server Team CI bot (server-team-bot)]

This bug is fixed with commit 9b99e4bf to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=9b99e4bf

[Launchpad Janitor (janitor)]

This bug was fixed in the package curtin - 19.3-68-g6cbdc02d-0ubuntu1

---------------
curtin (19.3-68-g6cbdc02d-0ubuntu1) groovy; urgency=medium

  * New upstream snapshot.
    - Makefile: make adjustments to call lint/style tools via python module
    - block-discover: ignore invalid id_serial/id_wwn values (LP: #1876848)
    - Fix handing of reusing msdos partitions and flags (LP: #1875903)
    - block.detect_multipath: ignore fake "devices" from /proc/mounts
      [Michael Hudson-Doyle] (LP: #1876626)
    - udev: use shlex.quote when shlex.split errors on shell-escape chars
      (LP: #1875085)
    - lvm: don't use vgscan --mknodes
    - vmtest: rsync don't cross filesystem boundaries when copying
      (LP: #1873909)
    - vmtest: basic/basic_scsi adjust collect/tests for unstable device names
      (LP: #1874100)
    - Add unittests for partition_handler calc_[dm]_part_info and kpartx paths
    - multipath: attempt to enforce /dev/mapper/mpath files are symlinks
    - block-meta: device mapper partitions may be block devices not links
    - Default to dm_name being id if empty earlier in dm_crypt_handler()
      [Łukasz 'sil2100' Zemczak] (LP: #1874243)
    - storage: correct declared schema draft version for storage schema
    - test_clear_holders: add missing zfs mock
    - Mock out zfs_supported to prevent attempting to load kernel modules
    - block-meta: skip wipe device paths if not present (LP: #1869075)
    - unittest: do not allow util.subp by default (LP: #1873913)
    - curthooks: support multiple ESP on UEFI bootable systems
    - block-discover: handle missing multipath 'path' data, use DM_NAME
      (LP: #1873728)
    - lvm-over-multipath: handle lookups of multipath members (LP: #1869075)
    - block-meta: don't filter preserve=true devices, select by wipe
      (LP: #1837214)
    - vmtest: basic use dname to lookup disk with multiple partitions
    - block-meta: Don't check the ptable type of a disk with no ptable
    - curthooks: always use ChrootableTarget.subp when calling efibootmgr
    - storage: enable and use multipath during storage configuration
      (LP: #1869075)
    - block-discover: detect nvme multipath devices (LP: #1868109)
    - clear-holders: Tolerate vgchange errors during discovery (LP: #1870037)
    - block-meta: handle preserve with vtoc ptable (LP: #1871158)
    - vmtest: use -partition file for TestReuseRAIDMemberPartition class
    - format: extra_options should be a list type
    - tox: add pyflakes to the default tox run [Paride Legovini]
    - storage_config: Add 'extra_options' parameter to allow custom mkfs
      (LP: #1869069)
    - Add support for installing Ubuntu Core 20 images
    - tox.ini: Fix issues with newer tox on focal
    - vmtest: Fix test_basic.py to run on s390x (LP: #1866663)
    - vmtest: use util.load_file for loading collect files
    - block-meta: refactor storage_config preserve and wipe settings
      (LP: #1837214)
    - block-discover: skip 'multipath' key in blockdevice if mpath name is None
    - tox: all py27 environments should use the base py27 deps
    - uefi: refactor efibootmg handling to support removing duplicate entries
      (LP: #1864257)
    - tox: pi...