Intel NVMe drive filesystems should be created with 'nodiscard'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin |
Fix Released
|
Medium
|
Ryan Harper |
Bug Description
Per public documentation at: https:/
Filesystem Recommendations
IMPORTANT: Do not discard blocks in filesystem usage.
Be sure to turn off the discard option when making your Linux filesystem. You want to allow the SSD manage
blocks and its activity between the NVM (non-volatile memory) and host with more advanced and consistent
approaches in the SSD Controller.
Core Filesystems:
• ext4 – the default extended option is not to discard blocks at filesystem make time, retain this, and do not
add the “discard” extended option as some information will tell you to do.
• xfs – with mkfs.xfs, add the –K option so that you do not discard blocks.
However, in the current curtin filesystem configuration, it is not possible to specify the 'nodiscard' option at creation time. Instead a workaround must be used to create the filesystems in early_commands, and then to preserve the existing filesystem.
Ideally, 'nodiscard' becomes an option (semantically) to the filesystem creation logic and implies the two changes mentioned above for ext4 and xfs. That would allow operators to avoid very lengthy filesystem creation times on Intel NVMe (86 minutes v. 9 minutes with SSD).
Related branches
- Scott Moser (community): Disapprove
- Chad Smith: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 147 lines (+45/-2)6 files modifiedcurtin/block/mkfs.py (+8/-2)
curtin/block/schemas.py (+1/-0)
doc/topics/storage.rst (+20/-0)
examples/tests/filesystem_battery.yaml (+1/-0)
tests/unittests/test_block_mkfs.py (+8/-0)
tests/vmtests/test_fs_battery.py (+7/-0)
Changed in curtin: | |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in curtin: | |
assignee: | nobody → Ryan Harper (raharper) |
This bug is fixed with commit 8a2fbf0c to curtin on branch master. /git.launchpad. net/curtin/ commit/ ?id=8a2fbf0c
To view that commit see the following URL:
https:/