Comments block not displaying as expected in HTML / PDF export

[Robert Lyon]

Reported that this is not working - so needs some testing to make sure

Test as
1) full export of user
2) export of a page/collection

[Lisa Seeto (lisaseeto)]

The patch found here: https://reviews.mahara.org/#/c/10910/1/htdocs/export/lib.php made it possible for comments to be included in pdf exports. Currently on a page containing a comment block both the HTML and PDF export is displaying the comments in the comment block AND in the page comments.

If the includefeedback flag is true, and a comment block is encountered, either we display the comment block and not the page comments or we skip the block and only display the page comments.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10922

[Robert Lyon (robertl-9)]

We still need to check if we respect the include comments switch when a comment block is on a page

if 'include comments' is false we should not display the comments block

[Robert Lyon (robertl-9)]

Using 3 different images
I added a user and set their profile icon to a new image (image 1)
I made 2 pages, one with an image block (image 2) and comment block, and the other just with an image block (image 3)
I added the 2 pages I made to a new collection
I then went into the collection and commented on both of the pages

I did an export of the collection only and set 'Include comments' to 'Yes'

Things that I noticed that need fixing:

1) Both the html and pdf results have a broken profile icon image for the commenter
- also the block version is missing the alt text for the image

2) The block version is displaying the 'edit' button if you export with a few seconds of making the comment (the base version doesn't) so the edit button needs to not be seen in export

I did an export of the collection only and set 'Include comments' to 'No'

The page with comments at base did not show comments (this is correct)
The page with comments in the block did show comments - I believe this is not correct - when one chooses not to include comments then the content of the comment block should be either empty or have some text mentioning that comments were not exported

[Lisa Seeto (lisaseeto)]

It was decided that issue 1) of comment #4 concerning profile icon images would be addressed here:
https://bugs.launchpad.net/mahara/+bug/1874341

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10922
Committed: https://git.mahara.org/mahara/mahara/commit/395d4e890104d4d22407e04dc839b62554f4805b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 395d4e890104d4d22407e04dc839b62554f4805b
Author: Lisa Seeto <email address hidden>
Date: Wed Apr 22 15:28:07 2020 +1200

Bug 1873122: Comments block not displaying as expected in HTML / PDF export

- added feedback->position conditional to export template
- add exporting to comment options to prevent editing form on exported page
- add check for exporter->includefeedback for comment block & alter .tpl

Change-Id: I4d651f17b31a83078f69df5a6d470647ee27d105
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10928

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10928
Committed: https://git.mahara.org/mahara/mahara/commit/8afe70132c8a4961efaf6e32a3097ba31dbb8714
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 8afe70132c8a4961efaf6e32a3097ba31dbb8714
Author: Lisa Seeto <email address hidden>
Date: Wed Apr 22 15:28:07 2020 +1200

Bug 1873122: Comments block not displaying as expected in HTML / PDF export

- added feedback->position conditional to export template
- add exporting to comment options to prevent editing form on exported page
- add check for exporter->includefeedback for comment block & alter .tpl

Change-Id: I4d651f17b31a83078f69df5a6d470647ee27d105
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 395d4e890104d4d22407e04dc839b62554f4805b)

[Robert Lyon (robertl-9)]

The profile icon issue is not specific to comments but a generic issue with exports and is handled by https://bugs.launchpad.net/mahara/+bug/1874341