Profile icon image not being exported in html/pdf export

Bug #1874341 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

If we don't set a profile icon the all is fine as the 'nouserphoto' exists in the export

But if we set a profile icon image as our avatar then we don't get that image in the export.

We will need to handle things so that profile icons for the exporter and any comment profile icons appear in the export

Also will need to handle gravatar icons as well

Robert Lyon (robertl-9)
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10984

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

How to test:

1. with an uploaded profile picture

- have two users, userA and userB
- set a profile image for both of them
- userA creates a page and adds a comment to it
- userB leaves a comment in userA's page
- userA exports the page

result
the profile icon to the left of the comments should be displayed in html and pdf export for both comments

2. with gravatar

- have two users, userA and userB
- set up userB to use an email that has an account on gravatar
- set up the image in gravatar for that email
- enable the use of gravatar on the site: Site options-> Account settings->Display remote avatars
- userA creates a page and adds a comment to it
- userB leaves a comment in userA's page
- userA exports the page

result
the gravatar profile icon to the left of the comments should be displayed in html and pdf export

Changed in mahara:
milestone: none → 20.10.0
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10984
Committed: https://git.mahara.org/mahara/mahara/commit/eeb06097b6e13606499a241cf3116ebd74f8ff1f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit eeb06097b6e13606499a241cf3116ebd74f8ff1f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 21 10:28:30 2020 +1200

Bug 1874341: adding profile icon for comments in export

behatnotneeded

Change-Id: I8d4a483f424911d7ef6efd897b631dd52ff5c3a6

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.