Angular: Local Admin Cash Reports UI Port

Bug #1859701 reported by Kyle Huckins
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen: master

We’ll be porting the Cash Reports UI from DOJO to Angular. This is effectively two grids filtered by a date range, and by Org Unit. Desk Payments refers to payments registered by an admin(for example, through the Patron → Bills UI), while User Payments refers to payments registered by a patron. I am not certain how a user payment would be made via the UI - more information needed there, but mock data might suffice for demo purposes.

Revision history for this message
John Amundson (jamundson) wrote :

Just noting that as part of LP bug #1858448, I discovered the Cash Reports is no longer calculating correctly due to the new aged_payment table in 3.4+.

My understanding, too, is that desk payments are "actual" payments - cash, check, credit card. These payments register a workstation. User payments are "fake" payments - forgive, goods, etc. These payments only register an accepting user.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I thought User Payments were those made through the OPAC via credit card and/or third-party self-check machines? I may be entirely wrong.

Revision history for this message
John Amundson (jamundson) wrote :

I've attached an example of the Cash Report screen on our production server. The "User" column under User Payments list staff logins, and you can see that the only payment types listed are non-money related: Credit,Forgive, Work, Goods.

Revision history for this message
Lindsay Stratton (lstratton) wrote :

I don't understand why a) non-monetary payments are handled via a completely separate table, and b) why non-monetary payments are associated with the staff user account rather than the "payment" accepting workstation.

That user payments are recorded by the staff username is a HUGE problem when staff work at multiple libraries. User payments appear on the cash report of the library that is the "home" or first registered library of the staff person REGARDLESS of what library actually processed the transaction.

This is a common and frustrating problem for our libraries in Westchester.

Revision history for this message
Zavier (zavierbanks) wrote :

This branch is ready for review. However the functionality for disabled orgs is dependent on bug #1863168.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/zbanks/lp1859701-cash-reports

tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Terran McCanna (tmccanna) wrote :

This one appears to need a bit more work. The Desk Payments tab is close, but the line at the bottom which has the totals is showing too many places after the decimal (see attached screenshot). It's also not clear that that line is showing totals - when I first pulled it up, I thought it was a mistake. Is it possible to label or display the total line differently than the workstation lines?

The User Payments tab isn't displaying any of the forgive/goods/work payments I enter (see attached screenshot, which should have several entries).

Revision history for this message
Terran McCanna (tmccanna) wrote :
Revision history for this message
Blake GH (bmagic) wrote :

FYI - Merge conflict with master (bugsquashing week)

tags: added: needsrepatch
removed: pullrequest
Revision history for this message
Kyle Huckins (khuckins) wrote :

I've pushed a rebased branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1859701-cash-reports

Note that this does not currently address the issues noted in Terran's test, simply rebased to facilitate further feedback.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Adding pullrequest back due to rebase in #9, but may need another rebase in order to test now.

tags: added: pullrequest
removed: needsrepatch
Revision history for this message
Ruth Frasur Davis (redavis) wrote :

I tested this by adding a cash payment for overdue fines. There seem to be duplicate entries being added.

Revision history for this message
Ruth Frasur Davis (redavis) wrote :

This is happening with the user payments as well.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I added another cash payment and it looks like the bottom line is totalling up the other rows. I like that, but it definitely needs some sort of visual indication that that is what it is doing.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Also, the total line at the bottom should format the sums in the same money format that the rows above it are formatted.

tags: added: needsrepatch
tags: removed: pullrequest
tags: added: needswork
removed: needsrepatch
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

New branch here, rebased against master, and with one bugfix and replacing the "totals" row with a dedicated totals area above each grid. Top 3 commits.

collab/phasefx/lp1859701-cash-reports

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1859701-cash-reports

tags: added: pullrequest
removed: needswork
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Revision history for this message
Jason Etheridge (phasefx) wrote :

Pushed a 4th commit for a release note blurb

Revision history for this message
Jason Etheridge (phasefx) wrote :

To speak to Kyle's initial musings about user payments, user payments vs desk payments depend on the specific payment type selected in the staff interface, though I'm not sure offhand how payments made through the OPAC show up. One thing I tripped over when testing was that I forgot that the "location" of user payments is based on the home library of the accepting user, and I was testing with the stock admin account that has a home library of CONS.

Revision history for this message
Terran McCanna (tmccanna) wrote :

>>I'm not sure offhand how payments made through the OPAC show up<<

They don't show up in Cash Reports at all. We need to run reports to get them.

Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.next
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: 3.next → 3.10-beta
Revision history for this message
Bill Erickson (berick) wrote :

New branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1859701-angular-cash-reports

1. Contains additional sign-offs
2. Adds one more commit to do these:

* Avoid manual currency data formatting when it can happen in the template.
* Replace ngbTab with ngbNav. ngbTab is deprecated.
* Tweak date filter form layout to fix some obscured fields.
* Remove no longer needed view child static specifiers
* Use 2-space "tabs" in HTML consistent w/ other angular components.
* Remove unused code / css styles
* ng lint

--

Also, curious about the patron data dialog, when the data could have been displayed directly in the grid (easier to view/export/print).

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

I pushed another commit to the branch mentioned in my previous comment:

* Display patron info in the User Payments grid inline with the grid instead of requiring an additional click to open a separate dialog.

* Make patron barcode a link so the patron can be opened in a new tab.

* Adds grid persist keys and pref workstation settings.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Susan Morrison (smorrison425) wrote (last edit ):

Tested with each type of desk and user payment* and found a few things:
- The totals under both tabs do not populate.
- In the Desk Payments tab, the column/field for debit payments is missing, so this type of payment was not recorded.
- In the User Payments tab, the patron information populates with the staff/user information instead of the patron information.
- In the User Payments, printing full grid and download csv do not show the patron card linked field

*could not get a patron credit to work properly to see if the credit payments populated correctly but other fields populated just fine, and the amount formatting was consistent

Revision history for this message
Elizabeth Davis (elidavis) wrote :

I am seeing my desk payments, but I'm not seeing my user payments displaying on https://terran-testbox.gapines.org/. I'm logged in at SL1 and paying bills with a billing location of BR3.

Revision history for this message
Terran McCanna (tmccanna) wrote :

My testing results:

Note: I had also forgotten that user payments were tied to the home library of the staff user, so my initial testing of forgive/work/goods didn't show up as I expected. I feel very strongly that they should be tied to the workstation's branch, particularly because library staff members may work at more than one branch, or may have a home library that is unrelated to the branch where they work. However, that's an issue that is separate from this work. See also: https://bugs.launchpad.net/evergreen/+bug/1354482

(When I did work, forgive, and goods payments with a staff user of the same branch, they did show up.)

1) I confirm Susan's report of the totals not calculating on either tab.
2) I confirm Susan's report of the Debit Card payments not appearing anywhere.
3) I confirm that the User column under User Payments show the staff person when I would expect it to be the patron - can that column label be changed to say "Staff User" instead?
4) I confirm Susan's report that print full grid and download CSV are missing the patron card number.

tags: added: needswork
removed: pullrequest
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

Terran, do you think we should go extra crazy and say "Staff User Payments (by staff home library)"?

Revision history for this message
Jason Etheridge (phasefx) wrote :

For the related grid, I'm relabeling all those Patron columns as well to Staff Card, Staff Email, etc.

Revision history for this message
Jason Etheridge (phasefx) wrote :

Though now I'm wondering if there are any situations where a non-staff user might show up in the "Staff" User Payments grid.

Revision history for this message
Jason Etheridge (phasefx) wrote :

So the missing Patron Card (well, soon to be Staff Card) column for Print Full Grid and Download Full CSV, that seems to be a more general bug for egGrid whenever we use cellTemplate. For an example, see /eg2/en-US/staff/sandbox, the grid that has a test column with a lot of HELLO World's. When printed or downloaded, you see HELLO universe's instead, which is the original data for that field (based on a textGenerator, but still). Not a shower stopped for this branch, I think.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Hmm, the only thing I can think of where there would be a non-staff user making a payment would be when the payment is made through a third party vendor (Stripe, etc.) and I don't *think* there are any times when those would show up in this interface. But possibly there are scenarios that we just don't encounter in PINES?

Revision history for this message
Jason Etheridge (phasefx) wrote :

So here's a freshly rebased branch that should address everything but the print/CSV issue:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/phasefx/lp1859701-angular-cash-reports

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
tags: added: pullrequest
removed: needswork
Revision history for this message
Terran McCanna (tmccanna) wrote :

Re #27: I agree, that seems like it is worth a separate bug report.

Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This is looking good to me! Rebased signoff branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1859701-angular-cash-reports (it also includes a small commit to remove some unused imports).

I got tripped up by the same issue as Terran mentioned in #23 (staff home org unit vs. workstation org unit). I broke it off into its own bug here: https://bugs.launchpad.net/evergreen/+bug/1991544

tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

Pushed to master for inclusion in Release 3.10.

Thanks Kyle, Zavier, Jason, Bill and Jane!

One issue I'll report in a separate bug, the columns in DOJO are sortable, sort of, the Angular grid are not, but the added print and download features in Angular more than make up for that.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.