check for kolla_ansible being installed does not take into account it's ansible that has to see it

[Radosław Piliszek]

Since we now ship ansible filters at the package level, kolla_ansible has to be installed along ansible.

Recently we have been getting reports that the check is too lenient and does not consider the fact that people run ansible from a different venv than that with kolla_ansible installed leading to errors later running playbooks (most notably 'kolla_address' being missing).

[Mark Goddard (mgoddard)]

Radoslaw, are you sure it's not just that people are running a version prior to the fix for https://bugs.launchpad.net/kolla-ansible/+bug/1854049?

[Radosław Piliszek (yoctozepto)]

Sure, some have OS-installed ansible and kolla-ansible in venv. They don't see each other then.

[Radosław Piliszek (yoctozepto)]

OS = Operating System

[Mark Goddard (mgoddard)]

Ok, makes sense.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/723021

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/723021
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=32fc2599a665e01b47c74588cdc2b547dc208874
Submitter: Zuul
Branch: master

commit 32fc2599a665e01b47c74588cdc2b547dc208874
Author: Radosław Piliszek <email address hidden>
Date: Fri Apr 24 21:38:15 2020 +0200

    Check that used Ansible can see Kolla Ansible

    Fix-feature following up on the original check [1] to make it
    test the correct interpreter.

    Additionally, this change removes last, unneeded call to
    random python - getting script directory is perfectly
    doable in bash.

    All checks are done from Python, not Ansible, due to its
    performance. Python version feels snappy (0.2 s to check),
    compared to sluggish Ansible (2.0 s to check).
    What is more, relying on Ansible would require hacky solutions
    to e.g. prevent custom config from interfering with it.
    We might be willing to steer Ansible from Python in the future
    anyhow.

    [1] Icf0399d21b3fde8d530d73e6e7ee4a57665da276

    Change-Id: Ib8f2e6b6672e7c06aa94bc226c4d72640d25d8c2
    Closes-Bug: #1856346

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/730592

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/730593

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/730595

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/730595
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=57605db6dd44985a59da4add80a8a72314a84dce
Submitter: Zuul
Branch: stable/stein

commit 57605db6dd44985a59da4add80a8a72314a84dce
Author: Radosław Piliszek <email address hidden>
Date: Fri Apr 24 21:38:15 2020 +0200

    Check that used Ansible can see Kolla Ansible

    Fix-feature following up on the original check [1] to make it
    test the correct interpreter.

    Additionally, this change removes last, unneeded call to
    random python - getting script directory is perfectly
    doable in bash.

    All checks are done from Python, not Ansible, due to its
    performance. Python version feels snappy (0.2 s to check),
    compared to sluggish Ansible (2.0 s to check).
    What is more, relying on Ansible would require hacky solutions
    to e.g. prevent custom config from interfering with it.
    We might be willing to steer Ansible from Python in the future
    anyhow.

    [1] Icf0399d21b3fde8d530d73e6e7ee4a57665da276

    Change-Id: Ib8f2e6b6672e7c06aa94bc226c4d72640d25d8c2
    Closes-Bug: #1856346
    (cherry picked from commit 32fc2599a665e01b47c74588cdc2b547dc208874)
    (cherry picked from commit 1f16c04a50e0c6e9614ede128736c2c97d4efe1d)
    (cherry picked from commit 3af97a2e8ff1feae07849ab26bcc3c1a382dc9e5)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/730593
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=cfc1ba2c33c9f473a151c9ecaa3d5a726934c775
Submitter: Zuul
Branch: stable/train

commit cfc1ba2c33c9f473a151c9ecaa3d5a726934c775
Author: Radosław Piliszek <email address hidden>
Date: Fri Apr 24 21:38:15 2020 +0200

    Check that used Ansible can see Kolla Ansible

    Fix-feature following up on the original check [1] to make it
    test the correct interpreter.

    Additionally, this change removes last, unneeded call to
    random python - getting script directory is perfectly
    doable in bash.

    All checks are done from Python, not Ansible, due to its
    performance. Python version feels snappy (0.2 s to check),
    compared to sluggish Ansible (2.0 s to check).
    What is more, relying on Ansible would require hacky solutions
    to e.g. prevent custom config from interfering with it.
    We might be willing to steer Ansible from Python in the future
    anyhow.

    [1] Icf0399d21b3fde8d530d73e6e7ee4a57665da276

    Change-Id: Ib8f2e6b6672e7c06aa94bc226c4d72640d25d8c2
    Closes-Bug: #1856346
    (cherry picked from commit 32fc2599a665e01b47c74588cdc2b547dc208874)
    (cherry picked from commit 1f16c04a50e0c6e9614ede128736c2c97d4efe1d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/730592
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1f16c04a50e0c6e9614ede128736c2c97d4efe1d
Submitter: Zuul
Branch: stable/ussuri

commit 1f16c04a50e0c6e9614ede128736c2c97d4efe1d
Author: Radosław Piliszek <email address hidden>
Date: Fri Apr 24 21:38:15 2020 +0200

    Check that used Ansible can see Kolla Ansible

    Fix-feature following up on the original check [1] to make it
    test the correct interpreter.

    Additionally, this change removes last, unneeded call to
    random python - getting script directory is perfectly
    doable in bash.

    All checks are done from Python, not Ansible, due to its
    performance. Python version feels snappy (0.2 s to check),
    compared to sluggish Ansible (2.0 s to check).
    What is more, relying on Ansible would require hacky solutions
    to e.g. prevent custom config from interfering with it.
    We might be willing to steer Ansible from Python in the future
    anyhow.

    [1] Icf0399d21b3fde8d530d73e6e7ee4a57665da276

    Change-Id: Ib8f2e6b6672e7c06aa94bc226c4d72640d25d8c2
    Closes-Bug: #1856346
    (cherry picked from commit 32fc2599a665e01b47c74588cdc2b547dc208874)