kolla_ansible python module check is non-fatal

Bug #1854049 reported by Mark Goddard
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Mark Goddard
Train
Fix Released
Medium
Radosław Piliszek
Ussuri
Fix Released
Medium
Mark Goddard

Bug Description

The kolla-ansible script now (Train+) checks whether the kolla_ansible python module is installed, and emits the following message if not:

ERROR: kolla_ansible has to be available in the PYTHONPATH (e.g. installed)

It is supposed to exit 1 if this check fails, but does not.

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/696077

Changed in kolla-ansible:
assignee: nobody → Mark Goddard (mgoddard)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/696077
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=692d176cd5e716ad24e6f4fe57f2c345417c0793
Submitter: Zuul
Branch: master

commit 692d176cd5e716ad24e6f4fe57f2c345417c0793
Author: Mark Goddard <email address hidden>
Date: Tue Nov 26 12:42:36 2019 +0000

    Fix kolla_ansible python module check

    The kolla-ansible script now (Train+) checks whether the kolla_ansible
    python module is installed, and emits the following message if not:

    ERROR: kolla_ansible has to be available in the PYTHONPATH (e.g.
    installed)

    It is supposed to exit 1 if this check fails, but does not.

    This change fixes this by removing a subshell from the kolla-ansible
    script.

    Change-Id: I2c1a7398f2b8f876abcf2508874835154cb4ce57
    Closes-Bug: #1854049

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/696281

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/696281
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=7ecba94dd5d7ef21a37055e7b221b7a913509821
Submitter: Zuul
Branch: stable/train

commit 7ecba94dd5d7ef21a37055e7b221b7a913509821
Author: Mark Goddard <email address hidden>
Date: Tue Nov 26 12:42:36 2019 +0000

    Fix kolla_ansible python module check

    The kolla-ansible script now (Train+) checks whether the kolla_ansible
    python module is installed, and emits the following message if not:

    ERROR: kolla_ansible has to be available in the PYTHONPATH (e.g.
    installed)

    It is supposed to exit 1 if this check fails, but does not.

    This change fixes this by removing a subshell from the kolla-ansible
    script.

    Change-Id: I2c1a7398f2b8f876abcf2508874835154cb4ce57
    Closes-Bug: #1854049
    (cherry picked from commit 692d176cd5e716ad24e6f4fe57f2c345417c0793)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.0.0.0rc2

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc2 release candidate.

Revision history for this message
XiaojueGuan (xiaojuegaun) wrote :

according to this https://github.com/openstack-exporter/openstack-exporter
we should add some like below
clouds:
 default:
   region_name: {{ openstack_region_name }}
   identity_api_version: 3
   identity_interface: internal
   auth:
     username: {{ keystone_admin_user }}
     password: {{ keystone_admin_password }}
     project_name: {{ keystone_admin_project }}
     project_domain_name: 'Default'
     user_domain_name: 'Default'
     auth_url: {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3
     cacert: |
            ---- BEGIN CERTIFICATE ---
      ...
    verify: true | false // disable || enable SSL certificate verification

Revision history for this message
XiaojueGuan (xiaojuegaun) wrote :

sorry about above confusing. I do think we should add a delete button and api.

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

Xiaojue, I don't think it's the right report you are replying too...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.