Comment 11 for bug 1856346

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/730593
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=cfc1ba2c33c9f473a151c9ecaa3d5a726934c775
Submitter: Zuul
Branch: stable/train

commit cfc1ba2c33c9f473a151c9ecaa3d5a726934c775
Author: Radosław Piliszek <email address hidden>
Date: Fri Apr 24 21:38:15 2020 +0200

    Check that used Ansible can see Kolla Ansible

    Fix-feature following up on the original check [1] to make it
    test the correct interpreter.

    Additionally, this change removes last, unneeded call to
    random python - getting script directory is perfectly
    doable in bash.

    All checks are done from Python, not Ansible, due to its
    performance. Python version feels snappy (0.2 s to check),
    compared to sluggish Ansible (2.0 s to check).
    What is more, relying on Ansible would require hacky solutions
    to e.g. prevent custom config from interfering with it.
    We might be willing to steer Ansible from Python in the future
    anyhow.

    [1] Icf0399d21b3fde8d530d73e6e7ee4a57665da276

    Change-Id: Ib8f2e6b6672e7c06aa94bc226c4d72640d25d8c2
    Closes-Bug: #1856346
    (cherry picked from commit 32fc2599a665e01b47c74588cdc2b547dc208874)
    (cherry picked from commit 1f16c04a50e0c6e9614ede128736c2c97d4efe1d)