[SRU] Custom keyboard shortcuts occasionally stop working

[fossfreedom]

This (master) SRU request is to resolve a number of usability and crashes reported to the UB team through various channels.

The key issue is LP: #1824102 which will allow the outstanding bionic mutter SRU LP: #1811900 to migrate. Further details specific to this is covered by LP: #1824102

Other linked SRU requests under this two target uploads are

LP: #1729947 resolve polkit dialog crashes

LP: #1825050 Close raven when workspace switching.

Changelog summary for Bionic and Cosmic SRU - also see the debdiffs for cosmic and bionic

This SRU patch correctly manage custom keys and hence resolve custom keys not
occasionally working on logon

[Impact]

 * Issue 2: Correctly manage custom keys and hence resolve custom keys not
occasionally working on logon.

   This backports a disco patch to both series targets. Testing over a couple of months during the 19.04 cycle shows that custom keyboard shortcuts are reliably available after a logout/login or reboot.

[Test Case]

 * Issue 2: This bug is very difficult to pin down and reliably reproduce. For a test case, pressing CTRL+ALT+T to open a terminal, Super + E to open a file-manager window should always work after a full reboot & login
   Recommend repeat the above for 10 reboots or more after budgie-desktop is upgraded

[Regression Potential]

 * Issue 2: The likelihood of regression is negligable since the handling of custom keys is now how the maintainer of gnome-settings-daemon recommends (upstream https://github.com/solus-project/budgie-desktop/issues/1763). In any-case, there is a potential that custom key handling will still occur to be not available after a reboot, requiring a user to continue using the current workaround of logging out and logging in again.

[Other Info]

N/A

[Brian Murray (brian-murray)]

To have a log of this, it'd be easier if there one was bug per issue in the bug description. As an SRU team member its complicated for me to track multiple issues in one bug report as for me to verify the SRU verification was done properly I'm going to have to look through the bug with a mental checklist of all the issues and look for verification of each separate issue which is painful.

[Łukasz Zemczak (sil2100)]

Confirmed that the fix is present in the disco version.

[Łukasz Zemczak (sil2100)]

Hello fossfreedom, or anyone else affected,

Accepted budgie-desktop into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello fossfreedom, or anyone else affected,

Accepted budgie-desktop into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[fossfreedom (fossfreedom)]

Followed the test case for 64bit Bionic and 64bit Cosmic.

Repeated the test case for 32bit Bionic.

In all cases (including logging out and in/ repeated reboots) workspace navigation (which is a custom shortcut key) as well as opening a terminal (which is not) worked correctly.

Note - checked that a fully uptodate bionic + budgie upgrade works. Then repeated testing with the new mutter (libmutter-2-0 mutter-common) packages to doubly check all was well.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-desktop - 10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2

---------------
budgie-desktop (10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2) cosmic; urgency=medium

  * cherrypick upstream commits
     - 0009-Polkit-Correctly-handle-the-user-dismissing-the-auth.patch
       Hopefully resolve fix polkit crashes reported on errors.ubuntu.com due
       to Polkit dialogs still having an open process when dismissed
       (LP: #1729947)
     - cleanup-keygrab.patch
       Correcly manage custom keys and hence resolve custom keys not
       occasionally working on logon (LP: #1824229)
     - close-raven-on-workspace-switch.patch
       Usability patch to correctly dismiss raven if opened when a workspace
       is switched (LP: #1825050)
     - Ensure animations remain working with newer versions of mutter
       (LP: #1824102) animations.patch
  * Packaging Changes
    - budgie-desktop.gsettings-override remove disabling animation override

 -- David Mohammed <email address hidden> Wed, 10 Apr 2019 22:14:25 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for budgie-desktop has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-desktop - 10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2

---------------
budgie-desktop (10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2) bionic; urgency=medium

  * cherrypick upstream commits
     - 0009-Polkit-Correctly-handle-the-user-dismissing-the-auth.patch
       Hopefully resolve fix polkit crashes reported on errors.ubuntu.com due
       to Polkit dialogs still having an open process when dismissed
       (LP: #1729947)
     - cleanup-keygrab.patch
       Correcly manage custom keys and hence resolve custom keys not
       occasionally working on logon (LP: #1824229)
     - close-raven-on-workspace-switch.patch
       Usability patch to correctly dismiss raven if opened when a workspace
       is switched (LP: #1825050)
     - Ensure animations remain working with newer versions of mutter
       (LP: #1824102) animations.patch
  * Packaging Changes
    - control: Bump StandardsVersion; no changes required
    - copy budgie-core-dev.lintian-overrides from disco package to resolve
      lintian warnings
    - copy budgie-core.lintian-overrides from disco package to resolve
      lintian errors

 -- David Mohammed <email address hidden> Wed, 10 Apr 2019 20:39:16 +0100