/usr/bin/budgie-polkit-dialog:11:g_data_set_internal:g_datalist_id_set_data_full:g_object_unref:_vala_main:__libc_start_main

Bug #1729947 reported by errors.ubuntu.com bug bridge
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
budgie-desktop (Ubuntu)
Fix Released
Medium
fossfreedom
Bionic
Fix Released
Medium
fossfreedom
Cosmic
Fix Released
Medium
fossfreedom

Bug Description

This SRU request is to resolve a number of budgie-polkit-dialog crashes reported to the UB team through https://errors.ubuntu.com/problem/64efb30df94e62a4f216cfdb387d6e2d3eb12048.

Changelog summary for Bionic and Cosmic SRU - also see the debdiffs for cosmic and bionic in the master SRU LP: #1824229

[Impact]

 * Issue 1: Aim to resolve a number of polkit crashes reported on errors.ubuntu.com due
to Polkit dialogs still having an open process when dismissed

   This backports a disco patch to both series targets. Whilst ack that 19.04 has not been released, examining errors.ubuntu.com (https://errors.ubuntu.com/problem/64efb30df94e62a4f216cfdb387d6e2d3eb12048) shows just one reported polkit issues to-date.

[Test Case]

 * Issue 1: polkit crashes. This bug is very difficult to pin down and reliably reproduce.
   It is surmised by examining the crash reports that the budgie polkit process is crashing due to window close down and memory cleanup areas.
   - Run pkexec gnome-calculator from a terminal.
   - Press cancel on the authentication dialog. Note that the terminal prompt is not redisplayed indicating that the polkit dialog is still active but hidden. Press CTRL+C to force a quit.
   - To upgrade budgie-desktop on 18.04 - Enable the proposed channel. Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0
   - To upgrade budgie-desktop on 18.10 - Enable the proposed channel. Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0 libbudgie-private0
   - Repeat pkexec gnome-calculator and press cancel. The terminal prompt is redisplayed indicating that the polkit dialog has been successfully closed.

[Regression Potential]

 * Issue 1: Due to the nature of the crashes observed (unexplained crashes in glib, wnck libraries), it is highly unlikely that this fix alone will resolve all polkit issues. In terms of regression the number of "system error" prompts with a polkit headline after a reboot and login will be either the same or reduced - but such messages can be ticked by a user via the system error dialog to not appear again.

[Other Info]

N/A

[Original report]

The Ubuntu Error Tracker has been receiving reports about a problem regarding budgie-desktop. This problem was most recently seen with package version 10.4-1ubuntu4, the problem page at https://errors.ubuntu.com/problem/64efb30df94e62a4f216cfdb387d6e2d3eb12048 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

Revision history for this message
fossfreedom (fossfreedom) wrote :

possibly this upstream bug report - I need access to the error tracker to confirm

https://github.com/budgie-desktop/budgie-desktop/issues/1201

description: updated
Changed in budgie-desktop (Ubuntu Cosmic):
assignee: nobody → fossfreedom (fossfreedom)
Changed in budgie-desktop (Ubuntu Bionic):
assignee: nobody → fossfreedom (fossfreedom)
Changed in budgie-desktop (Ubuntu):
assignee: nobody → fossfreedom (fossfreedom)
Changed in budgie-desktop (Ubuntu Cosmic):
importance: Undecided → Medium
Changed in budgie-desktop (Ubuntu Bionic):
importance: Undecided → Medium
Changed in budgie-desktop (Ubuntu):
importance: Undecided → Medium
Changed in budgie-desktop (Ubuntu):
status: New → Incomplete
status: Incomplete → In Progress
Changed in budgie-desktop (Ubuntu Bionic):
status: New → In Progress
Changed in budgie-desktop (Ubuntu Cosmic):
status: New → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Confirmed that the fix is present in the disco version.

Changed in budgie-desktop (Ubuntu):
status: In Progress → Fix Released
Changed in budgie-desktop (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted budgie-desktop into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted budgie-desktop into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in budgie-desktop (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed-cosmic
Revision history for this message
fossfreedom (fossfreedom) wrote :

Followed the test case for 64bit Bionic and 64bit Cosmic.

Repeated the test case for 32bit Bionic.

In all cases, pkexec dialog was correctly cancelled after upgrading budgie.

tags: added: verification-done verification-done-bionic verification-done-cosmic
removed: verification-needed verification-needed-bionic verification-needed-cosmic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package budgie-desktop - 10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2

---------------
budgie-desktop (10.4+git20180830.02.f2dbc215fdb-2ubuntu0.2) cosmic; urgency=medium

  * cherrypick upstream commits
     - 0009-Polkit-Correctly-handle-the-user-dismissing-the-auth.patch
       Hopefully resolve fix polkit crashes reported on errors.ubuntu.com due
       to Polkit dialogs still having an open process when dismissed
       (LP: #1729947)
     - cleanup-keygrab.patch
       Correcly manage custom keys and hence resolve custom keys not
       occasionally working on logon (LP: #1824229)
     - close-raven-on-workspace-switch.patch
       Usability patch to correctly dismiss raven if opened when a workspace
       is switched (LP: #1825050)
     - Ensure animations remain working with newer versions of mutter
       (LP: #1824102) animations.patch
  * Packaging Changes
    - budgie-desktop.gsettings-override remove disabling animation override

 -- David Mohammed <email address hidden> Wed, 10 Apr 2019 22:14:25 +0100

Changed in budgie-desktop (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for budgie-desktop has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package budgie-desktop - 10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2

---------------
budgie-desktop (10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2) bionic; urgency=medium

  * cherrypick upstream commits
     - 0009-Polkit-Correctly-handle-the-user-dismissing-the-auth.patch
       Hopefully resolve fix polkit crashes reported on errors.ubuntu.com due
       to Polkit dialogs still having an open process when dismissed
       (LP: #1729947)
     - cleanup-keygrab.patch
       Correcly manage custom keys and hence resolve custom keys not
       occasionally working on logon (LP: #1824229)
     - close-raven-on-workspace-switch.patch
       Usability patch to correctly dismiss raven if opened when a workspace
       is switched (LP: #1825050)
     - Ensure animations remain working with newer versions of mutter
       (LP: #1824102) animations.patch
  * Packaging Changes
    - control: Bump StandardsVersion; no changes required
    - copy budgie-core-dev.lintian-overrides from disco package to resolve
      lintian warnings
    - copy budgie-core.lintian-overrides from disco package to resolve
      lintian errors

 -- David Mohammed <email address hidden> Wed, 10 Apr 2019 20:39:16 +0100

Changed in budgie-desktop (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.