use same line seperator for output as input in dkimsign
Bug #1808686 reported by
meeuw
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dkimpy |
Fix Released
|
Low
|
Scott Kitterman |
Bug Description
Hi, I'm using dkimsign to sign my mail but it forces <cr><lf> when the input has only <lf> line separators. I've created this patch to fix it:
https:/
(I cannot find how git push to launchpad)
Changed in dkimpy: | |
milestone: | none → 0.9.2 |
assignee: | nobody → Scott Kitterman (kitterman) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in dkimpy: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
On Sunday, December 16, 2018 12:19:55 PM you wrote: /github. com/meeuw/ dkimpy/ compare/ linesep? expand= 1
> Public bug reported:
>
> Hi, I'm using dkimsign to sign my mail but it forces <cr><lf> when the
> input has only <lf> line separators. I've created this patch to fix it:
>
> https:/
>
> (I cannot find how git push to launchpad)
You push to a new branch in your own account namespace and then you can make a tuxdiary. com/2015/ 05/02/launchpad -git/
merge request. It looks like http://
has some hints.
I'm fine with the concept, but I think it needs more work.
As far as the change in dkimsign.py, I'd rather see '\r\n' the default of the
check. As an example, a single long line with no newline at the end should be
folded the same as before the change.
Arcsign.py will need the same changes.
For the internal dkim/__init__.py changes, I'm fine with the API extension, object) , it should be added to the @param list (I
but for class DomainSigner(
know there are others missing too, but let's not make it worse).
Finally, it needs a test case in dkim/tests/ test_dkim. py, so we know this
works. It needs to pass on at least python2.7, python3.6, and python3.7.
Testing python3.3 - 3.5 would be nice.
Thanks,
Scott K