Comment 1 for bug 1808686

On Sunday, December 16, 2018 12:19:55 PM you wrote:
> Public bug reported:
>
> Hi, I'm using dkimsign to sign my mail but it forces <cr><lf> when the
> input has only <lf> line separators. I've created this patch to fix it:
>
> https://github.com/meeuw/dkimpy/compare/linesep?expand=1
>
> (I cannot find how git push to launchpad)

You push to a new branch in your own account namespace and then you can make a
merge request. It looks like http://tuxdiary.com/2015/05/02/launchpad-git/
has some hints.

I'm fine with the concept, but I think it needs more work.

As far as the change in dkimsign.py, I'd rather see '\r\n' the default of the
check. As an example, a single long line with no newline at the end should be
folded the same as before the change.

Arcsign.py will need the same changes.

For the internal dkim/__init__.py changes, I'm fine with the API extension,
but for class DomainSigner(object), it should be added to the @param list (I
know there are others missing too, but let's not make it worse).

Finally, it needs a test case in dkim/tests/test_dkim.py, so we know this
works. It needs to pass on at least python2.7, python3.6, and python3.7.
Testing python3.3 - 3.5 would be nice.

Thanks,

Scott K