RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable not passed to dist-upgrader tarball
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-release-upgrader (Ubuntu) |
Fix Released
|
High
|
Brian Murray | ||
Bionic |
Fix Released
|
Medium
|
Unassigned | ||
Cosmic |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Impact
------
It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be.
Test Case
---------
The change is in do-release-upgrade and DistUpgradeFetc
1) Run RELEASE_
2) Choose to proceed with the upgrade
With the version of ubuntu-
There is no need to complete the full upgrade.
Regression Potential
-------
With the pkexec change we are only passing the RELEASE_
[Original Description]
ubuntu-
Its possible to confirm the fix for this bug by looking at /var/log/
2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
Related branches
- Ubuntu Core Development Team: Pending requested
-
Diff: 474 lines (+120/-30)6 files modifiedDistUpgrade/DistUpgradeCache.py (+19/-7)
DistUpgrade/DistUpgradeController.py (+25/-5)
DistUpgrade/DistUpgradeFetcherCore.py (+1/-1)
debian/changelog (+14/-2)
do-release-upgrade (+12/-0)
tests/test_sources_list.py (+49/-15)
tags: | added: rls-dd-incoming |
tags: | added: bionic cosmic |
Changed in ubuntu-release-upgrader (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Brian Murray (brian-murray) |
tags: | added: id-5b5b2ceb30bee3278544fe94 |
Changed in ubuntu-release-upgrader (Ubuntu Bionic): | |
status: | New → Triaged |
Changed in ubuntu-release-upgrader (Ubuntu Cosmic): | |
status: | New → Triaged |
Changed in ubuntu-release-upgrader (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in ubuntu-release-upgrader (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
This bug was fixed in the package ubuntu- release- upgrader - 1:19.04.7
--------------- release- upgrader (1:19.04.7) disco; urgency=medium
ubuntu-
[ Brian Murray ] DistUpgradeCach e.py: When calculating free space needed for UPRADER_ ALLOW_THIRD_ PARTY DistUpgradeCach e.py: When calculating free space needed for UPRADER_ ALLOW_THIRD_ PARTY DistUpgradeCont roller. py: When rewriting sources.list entries UPGRADER_ ALLOW_THIRD_ PARTY via pkexec and sudo. (LP: #1807032) DistUpgradeCach e.py: improve messaging regarding failures to DistUpgradeCach e.py: in the event there is a failure to log/dist- upgrade. (LP: #1771387)
* DistUpgrade/
mount points don't use a negative number as the buffer. (LP: #1786484)
* fix more typos re RELEASE_
* DistUpgrade/
mount points don't use a negative number as the buffer. (LP: #1786484)
* fix more typos re RELEASE_
* DistUpgrade/
check to see if the source provides packages for the release to which the
upgrade is occurring. If it doesn't the entry is disabled thereby
improving upgrades with PPAs. (LP: #1807043)
* do-release-upgrade: add a parameter to allow third party mirrors and
repositories, additionally pass along the environmental variable
RELEASE_
* DistUpgrade/
calculate the upgrade and suggest using ppa-purge if PPAs are an issue.
* DistUpgrade/
calculate the upgrade provide information about the log files in
/var/
[ Jeremy Bicha ]
* autopkgtest: Update dependency from gir1.2-webkit-3.0 to gir1.2-webkit2-4.0
-- Brian Murray <email address hidden> Tue, 11 Dec 2018 15:35:34 -0800