Activity log for bug #1807032

Date Who What changed Old value New value Message
2018-12-05 22:44:35 Brian Murray bug added bug
2018-12-05 22:44:44 Brian Murray tags rls-dd-incoming
2018-12-05 22:56:40 Brian Murray tags rls-dd-incoming bionic cosmic rls-dd-incoming
2018-12-05 23:13:09 Brian Murray ubuntu-release-upgrader (Ubuntu): status New In Progress
2018-12-05 23:13:13 Brian Murray ubuntu-release-upgrader (Ubuntu): importance Undecided High
2018-12-05 23:13:18 Brian Murray ubuntu-release-upgrader (Ubuntu): assignee Brian Murray (brian-murray)
2018-12-06 13:34:06 Francis Ginther tags bionic cosmic rls-dd-incoming bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming
2018-12-11 00:28:53 Launchpad Janitor branch linked lp:~brian-murray/ubuntu-release-upgrader/improve-upgrade-failure-messages
2018-12-13 15:43:07 Launchpad Janitor ubuntu-release-upgrader (Ubuntu): status In Progress Fix Released
2018-12-14 18:47:00 Brian Murray nominated for series Ubuntu Cosmic
2018-12-14 18:47:00 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Cosmic)
2018-12-14 18:47:00 Brian Murray nominated for series Ubuntu Bionic
2018-12-14 18:47:00 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Bionic)
2018-12-14 18:47:07 Brian Murray ubuntu-release-upgrader (Ubuntu Bionic): status New Triaged
2018-12-14 18:47:09 Brian Murray ubuntu-release-upgrader (Ubuntu Cosmic): status New Triaged
2018-12-14 18:47:12 Brian Murray ubuntu-release-upgrader (Ubuntu Bionic): importance Undecided Medium
2018-12-14 18:47:15 Brian Murray ubuntu-release-upgrader (Ubuntu Cosmic): importance Undecided Medium
2018-12-21 19:53:04 Brian Murray description ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeController so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
2018-12-21 19:54:13 Brian Murray description Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeController so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
2018-12-21 19:58:29 Brian Murray description Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- With the pkexec change we are only passing the RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable on to the release upgrade process but with the do-release-upgrade (DistUpgradeFetcherCore.py / sudo) one we are passing all existing environment variables on which could cause an issue for the release upgrade process. [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
2019-01-08 16:29:50 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Cosmic): status Triaged Fix Committed
2019-01-08 16:29:52 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-01-08 16:29:53 Łukasz Zemczak bug added subscriber SRU Verification
2019-01-08 16:29:55 Łukasz Zemczak tags bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-needed verification-needed-cosmic
2019-01-10 19:42:44 Brian Murray description Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- With the pkexec change we are only passing the RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable on to the release upgrade process but with the do-release-upgrade (DistUpgradeFetcherCore.py / sudo) one we are passing all existing environment variables on which could cause an issue for the release upgrade process. [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader/check-new-release-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log/dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- With the pkexec change we are only passing the RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable on to the release upgrade process but with the do-release-upgrade (DistUpgradeFetcherCore.py / sudo) one we are passing all existing environment variables on which could cause an issue for the release upgrade process. [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log/dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
2019-01-10 20:06:06 Brian Murray attachment added bug1807032-verification.png https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1807032/+attachment/5228389/+files/bug1807032-verification.png
2019-01-10 20:13:45 Brian Murray tags bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-needed verification-needed-cosmic bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-done verification-done-cosmic
2019-01-15 23:48:41 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Cosmic): status Fix Committed Fix Released
2019-01-15 23:49:00 Chris Halse Rogers removed subscriber Ubuntu Stable Release Updates Team
2019-01-22 17:46:18 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Bionic): status Triaged Fix Committed
2019-01-22 17:46:20 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-01-22 17:46:25 Łukasz Zemczak tags bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-done verification-done-cosmic bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-done-cosmic verification-needed verification-needed-bionic
2019-01-23 14:36:26 Brian Murray tags bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-done-cosmic verification-needed verification-needed-bionic bionic cosmic id-5b5b2ceb30bee3278544fe94 rls-dd-incoming verification-done verification-done-bionic verification-done-cosmic
2019-01-31 09:20:22 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Bionic): status Fix Committed Fix Released