[FFe] Update gnome-terminal to 3.30.0 and vte to 0.54

[Marco Trevisan (Treviño)]

gnome-terminal in cosmic is still a 3.28, while vte is at 0.52.

Prepared packages are at https://bileto.ubuntu.com/#/ticket/3410

vte upstream changes (0.52 -> 0.54):

In short:
 - New parser
 - Vte widget separated from terminal
 - Deprecated some functions
 - One more symbol: vte_terminal_get_color_background_for_draw

 AUTHORS | 2 +-
 COPYING.GPL3 | 675 +++
 COPYING => COPYING.LGPL2 | 0
 COPYING.LGPL3 | 165 +
 HACKING | 11 -
 Makefile.am | 4 +-
 README | 10 -
 configure.ac | 28 +-
 doc/Makefile.am | 3 +-
 doc/openi18n/Makefile.am | 7 -
 doc/openi18n/UTF-8.txt | 18 -
 doc/openi18n/cursor.c | 57 -
 doc/openi18n/wrap.txt | 1 -
 doc/readme.txt | 10 -
 doc/reference/Makefile.am | 28 +-
 doc/reference/vte-docs.xml | 4 +
 doc/reference/vte-sections.txt | 9 +-
 doc/vttest.tar.gz | Bin 100593 -> 0 bytes
 m4/ax_cxx_compile_stdcxx.m4 | 4 +-
 po/POTFILES.in | 1 -
 po/cs.po | 64 +-
 po/da.po | 37 +-
 po/de.po | 35 +-
 po/el.po | 36 +-
 po/es.po | 25 +-
 po/fi.po | 38 +-
 po/fr.po | 32 +-
 po/fur.po | 24 +-
 po/gl.po | 34 +-
 po/hu.po | 36 +-
 po/id.po | 26 +-
 po/it.po | 36 +-
 po/kk.po | 36 +-
 po/ko.po | 70 +-
 po/lt.po | 31 +-
 po/lv.po | 33 +-
 po/oc.po | 33 +-
 po/pl.po | 24 +-
 po/pt_BR.po | 37 +-
 po/ro.po | 28 +-
 po/sl.po | 38 +-
 po/sv.po | 28 +-
 po/tr.po | 33 +-
 po/zh_CN.po | 27 +-
 po/zh_TW.po | 25 +-
 src/Makefile.am | 196 +-
 src/app/app.cc | 66 +-
 src/buffer.h | 1 +
 src/caps-list.hh | 320 --
 src/{vterowdata.h => cell.hh} | 81 +-
 src/chunk.cc | 65 +
 src/chunk.hh | 80 +
 src/debug.cc | 49 +-
 src/debug.h | 35 +-
 src/interpret.cc | 272 --
 src/iso2022.cc | 201 -
 src/iso2022.h | 44 -
 src/iso2022.txt | 15 -
 src/matcher.cc | 221 -
 src/matcher.hh | 88 -
 src/modes-ecma.hh | 201 +
 src/modes-private.hh | 845 ++++
 src/modes-test.cc | 90 +
 src/modes.hh | 250 ++
 src/parser-arg.hh | 186 +
 src/parser-c01.hh | 73 +
 src/parser-cat.cc | 547 +++
 src/parser-charset-tables.hh | 230 +
 src/parser-charset.hh | 306 ++
 src/parser-cmd.hh | 330 ++
 src/parser-csi.hh | 212 +
 src/parser-dcs.hh | 47 +
 src/parser-esc.hh | 70 +
 src/parser-glue.hh | 1002 +++++
 src/parser-osc.hh | 100 +
 src/parser-reply.hh | 68 +
 src/parser-string.hh | 138 +
 src/parser-test.cc | 1484 ++++++
 src/parser.cc | 1334 ++++++
 src/parser.hh | 193 +
 src/refptr-test.cc | 135 +
 src/refptr.hh | 38 +
 src/ring.cc | 1036 ++---
 src/ring.h | 129 -
 src/ring.hh | 263 ++
 src/table.cc | 761 ----
 src/table.hh | 54 -
 src/tabstops-test.cc | 234 +
 src/tabstops.hh | 222 +
 src/utf8-test.cc | 349 ++
 src/utf8.cc | 47 +
 src/utf8.hh | 83 +
 src/vte.cc | 2969 ++++++------
 src/vte.sh | 4 +-
 src/vte/vtedeprecated.h | 21 +
 src/vte/vteglobals.h | 6 +
 src/vte/vteterminal.h | 19 +-
 src/vteconv.cc | 788 ----
 src/vteconv.h | 52 -
 src/vtedefines.hh | 17 +-
 src/vtedraw.cc | 22 -
 src/vtedraw.hh | 1 -
 src/vtegtk.cc | 281 +-
 src/vteinternal.hh | 552 ++-
 src/vterowdata.cc | 12 +-
 src/vterowdata.hh | 83 +
 src/vteseq-list.hh | 157 -
 src/vteseq.cc | 9748 +++++++++++++++++++++++++++++++---------
 src/vtetypes.hh | 5 +
 src/widget.cc | 364 ++
 src/widget.hh | 168 +
 vte.doap | 5 +-
 112 files changed, 21239 insertions(+), 8729 deletions(-)

Installing the packages:

$ LANG=C sudo dpkg -i ../DEB-build-area/*_0.54.0-1ubuntu1.deb
(Reading database ... 113067 files and directories currently installed.)
Preparing to unpack .../gir1.2-vte-2.91_0.54.0-1ubuntu1_amd64.deb ...
Unpacking gir1.2-vte-2.91:amd64 (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../libvte-2.91-0_0.54.0-1ubuntu1_amd64.deb ...
Unpacking libvte-2.91-0:amd64 (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../libvte-2.91-common_0.54.0-1ubuntu1_all.deb ...
Unpacking libvte-2.91-common (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../libvte-2.91-dev_0.54.0-1ubuntu1_amd64.deb ...
Unpacking libvte-2.91-dev:amd64 (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../libvte-2.91-doc_0.54.0-1ubuntu1_all.deb ...
Unpacking libvte-2.91-doc (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Setting up libvte-2.91-common (0.54.0-1ubuntu1) ...
Installing new version of config file /etc/profile.d/vte-2.91.sh ...
Setting up libvte-2.91-doc (0.54.0-1ubuntu1) ...
Setting up libvte-2.91-0:amd64 (0.54.0-1ubuntu1) ...
Setting up gir1.2-vte-2.91:amd64 (0.54.0-1ubuntu1) ...
Setting up libvte-2.91-dev:amd64 (0.54.0-1ubuntu1) ...
Processing triggers for libc-bin (2.27-3ubuntu1)

=============================================================

gnome-terminal upstream changes (3.28.0 -> 3.30.0):

In short:
 - bugfixes (memory related mostly)
 - removal of deprecated code/features (nautilus and settings migrations)
 - Added desktop actions for preferences and new window
 - Updated translations

 configure.ac | 31 +-
 gnome-terminal.doap | 3 +-
 help/es/es.po | 596 +++-----
 help/fr/fr.po | 2418 +++++++++++++++---------------
 help/ko/ko.po | 2222 +++++++++++++++++-----------
 org.gnome.Terminal.desktop.in.in | 9 +
 po/POTFILES.in | 1 -
 po/ar.po | 91 +-
 po/ca.po | 180 +--
 po/de.po | 330 ++---
 po/el.po | 478 +++---
 po/nl.po | 128 +-
 po/oc.po | 2836 +++++++++++++++++++++---------------
 po/pa.po | 2740 ++++++++++++++++++----------------
 po/pl.po | 266 ++--
 po/ro.po | 2 +-
 po/sl.po | 103 +-
 po/zh_TW.po | 292 ++--
 src/Makefile.am | 42 +-
 src/migration.c | 686 ---------
 src/org.gnome.Terminal.gschema.xml | 2 +-
 src/profile-editor.c | 111 +-
 src/server.c | 4 +
 src/terminal-accels.c | 2 +-
 src/terminal-app.c | 62 +-
 src/terminal-encoding.c | 2 +-
 src/terminal-nautilus.c | 209 +--
 src/terminal-notebook-menu.ui | 5 +
 src/terminal-notebook.c | 72 -
 src/terminal-options.c | 18 +-
 src/terminal-options.h | 1 +
 src/terminal-pcre2.h | 8 +-
 src/terminal-screen.c | 76 +-
 src/terminal-screen.h | 2 -
 src/terminal-search-popover.c | 4 +-
 src/terminal-window.c | 78 -
 src/terminal.c | 53 +-
 37 files changed, 6988 insertions(+), 7175 deletions(-)

$ LANG=C sudo dpkg -i ../DEB-build-area/gnome-terminal*.deb
(Reading database ... 113093 files and directories currently installed.)
Preparing to unpack .../gnome-terminal_3.30.0-1ubuntu1_amd64.deb ...
Unpacking gnome-terminal (3.30.0-1ubuntu1) over (3.28.2-1ubuntu1) ...
Preparing to unpack .../gnome-terminal-data_3.30.0-1ubuntu1_all.deb ...
Unpacking gnome-terminal-data (3.30.0-1ubuntu1) over (3.28.2-1ubuntu1) ...
Setting up gnome-terminal-data (3.30.0-1ubuntu1) ...
Setting up gnome-terminal (3.30.0-1ubuntu1) ...
Processing triggers for desktop-file-utils (0.23-1ubuntu3.18.04.1) ...
Processing triggers for mime-support (3.60ubuntu1) ...
Processing triggers for libglib2.0-0:amd64 (2.56.1-2ubuntu1) ...
Processing triggers for man-db (2.8.3-2ubuntu0.1) ...

=============

Installing from bileto PPA:

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Reading package lists...
Building dependency tree...
Reading state information...
Calculating upgrade...
The following packages will be upgraded:
  gir1.2-vte-2.91 gnome-terminal gnome-terminal-data libvte-2.91-0
  libvte-2.91-common nautilus-extension-gnome-terminal
6 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 400 kB of archives.
After this operation, 43,0 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 libvte-2.91-common all 0.54.0-1ubuntu1 [4.908 B]
Get:2 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 libvte-2.91-0 amd64 0.54.0-1ubuntu1 [169 kB]
Get:3 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 gir1.2-vte-2.91 amd64 0.54.0-1ubuntu1 [8.628 B]
Get:4 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 nautilus-extension-gnome-terminal amd64 3.30.0-1ubuntu1 [23,9 kB]
Get:5 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 gnome-terminal amd64 3.30.0-1ubuntu1 [161 kB]
Get:6 http://ppa.launchpad.net/ci-train-ppa-service/3410/ubuntu cosmic/main amd64 gnome-terminal-data all 3.30.0-1ubuntu1 [32,3 kB]
Fetched 400 kB in 2s (213 kB/s)
(Reading database ... 286551 files and directories currently installed.)
Preparing to unpack .../0-libvte-2.91-common_0.54.0-1ubuntu1_all.deb ...
Unpacking libvte-2.91-common (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../1-libvte-2.91-0_0.54.0-1ubuntu1_amd64.deb ...
Unpacking libvte-2.91-0:amd64 (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../2-gir1.2-vte-2.91_0.54.0-1ubuntu1_amd64.deb ...
Unpacking gir1.2-vte-2.91:amd64 (0.54.0-1ubuntu1) over (0.52.2-1ubuntu1) ...
Preparing to unpack .../3-nautilus-extension-gnome-terminal_3.30.0-1ubuntu1_amd64.deb ...
Unpacking nautilus-extension-gnome-terminal (3.30.0-1ubuntu1) over (3.28.2-1ubuntu1) ...
Preparing to unpack .../4-gnome-terminal_3.30.0-1ubuntu1_amd64.deb ...
Unpacking gnome-terminal (3.30.0-1ubuntu1) over (3.28.2-1ubuntu1) ...
Preparing to unpack .../5-gnome-terminal-data_3.30.0-1ubuntu1_all.deb ...
Unpacking gnome-terminal-data (3.30.0-1ubuntu1) over (3.28.2-1ubuntu1) ...
Processing triggers for mime-support (3.60ubuntu1) ...
Processing triggers for desktop-file-utils (0.23-3ubuntu1) ...
Processing triggers for libglib2.0-0:amd64 (2.58.0-2) ...
Setting up gnome-terminal-data (3.30.0-1ubuntu1) ...
Processing triggers for bamfdaemon (0.5.3+18.04.20180207.2-0ubuntu1) ...
Rebuilding /usr/share/applications/bamf-2.index...
Setting up libvte-2.91-common (0.54.0-1ubuntu1) ...
Installing new version of config file /etc/profile.d/vte-2.91.sh ...
Processing triggers for libc-bin (2.28-0ubuntu1) ...
Processing triggers for man-db (2.8.4-2) ...
Processing triggers for gnome-menus (3.13.3-11ubuntu2) ...
Setting up libvte-2.91-0:amd64 (0.54.0-1ubuntu1) ...
Setting up gnome-terminal (3.30.0-1ubuntu1) ...
Setting up nautilus-extension-gnome-terminal (3.30.0-1ubuntu1) ...
Setting up gir1.2-vte-2.91:amd64 (0.54.0-1ubuntu1) ...
Processing triggers for libc-bin (2.28-0ubuntu1) ...

---

Package has been tested, no regression found as per normal usage:
  - https://i.imgur.com/QWvc9un.png

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Iain Lane (laney)]

What are the new features? Especially those that might be risky? And is the update tested and ready to go?

https://wiki.ubuntu.com/FreezeExceptionProcess#FeatureFreeze_for_new_upstream_versions

[Marco Trevisan (Treviño) (3v1n0)]

Yeah, I was aware I had to do these steps, just didn't had the time to finish it last friday, but I wanted the bug number to add it to the debian/changelog :).

[Iain Lane (laney)]

okey dokey

[Łukasz Zemczak (sil2100)]

At first I was slightly worried about the 'deprecated functions', but then I saw deprecation != removal (as per symbols files). This seems fairly safe I suppose. Just seeing that vte has quite a lot of reverse-dependencies, please test a few of those besides gnome-terminal just-in-case.

FFe for both vte2.91 and gnome-terminal approved.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vte2.91 - 0.54.0-1ubuntu1

---------------
vte2.91 (0.54.0-1ubuntu1) cosmic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * Merge with debian (LP: #1791373). Remaining changes:
    - debian/rules:
      + Use --without-pcre2
    - Add revert-pcre2.patch:
      + Revert changes that require PCRE2 since it's not in main
        (see MIR #1636666)
    - Add 91_keep_fds.patch since gdebi still requires it (LP: #1756238)
    - 0001-Add-the-style-context-provider-with-FALLBACK-priorit.patch:
      + Keep as it is required for the Ubuntu theming
  * Rebased debian/patches
    + d/p/revert-pcre2.patch:
      - Updated to work with Terminal class

  [ Iain Lane ]
  * 0001-Add-the-style-context-provider-with-FALLBACK-priorit.patch: Add an
    upstream bug reference.

vte2.91 (0.54.0-1) unstable; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * New upstream release
  * Update symbols file

  [ Jeremy Bicha ]
  * Update debian/gbp.conf
  * Release to unstable

vte2.91 (0.53.0-1) experimental; urgency=medium

  * Team upload
  * New upstream development release
  * d/watch: Watch for development versions
  * d/copyright: Update
  * Set Rules-Requires-Root to no
  * Stop installing AUTHORS file, which just points to git history
  * Stop installing README, which no longer exists
  * Standards-Version: 4.2.0
  * Refresh patch series
  * d/libvte-2.91-0.symbols: Ignore C++ symbols.
    These are template instantiations, and are not part of vte's
    public ABI.

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 12 Sep 2018 15:29:35 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-terminal - 3.30.0-1ubuntu1

---------------
gnome-terminal (3.30.0-1ubuntu1) cosmic; urgency=medium

  * Merge with debian (LP: #1791373), remaining changes:
    + gnome-terminal.wrap, debian/rules:
      - Add a wrapper script to restore command line compatibility.
    + debian/control.in:
      - gnome-terminal depends on python3, python3-gi and gir1.2-glib-2.0 for
        the wrapper script.
      - Don't Build-Depend on PCRE2
    + Add 0001-Restore-transparency.patch:
      - Restore transparency support
    + Add 0001-Add-style-classes-and-CSS-names-to-some-of-our-widge.patch:
      - Add CSS names and style classes so we can theme things more easily.
    + Add 0001-screen-window-Extra-padding-around-transparent-termi.patch:
      - Fix transparency on Wayland. Patch by Owen Taylor, via Debarshi Ray @
        Fedora (LP: #1650395)
    + Add 52_support_apturl.patch:
      - Support apt: urls.
    + Add 60_add_lp_handler.patch:
      - Add a handler for launchpad bug URLs.
    + Add scrollbar-background-theming.patch:
      - Draw background under the scrollbar that matches the actual terminal
        background color. This allows proper theming.
    + Add debian/patches/revert-pcre2.patch:
      - Revert changes that require PCRE2 since it's not in main
        (see MIR #163666)
  * Keep 006-fix-invalid-appstream-metadata.patch:
    - Ubuntu's AppStream versions and http://appstream.ubuntu.com/
      don't support gnome-terminal's syntax yet
  * Refreshed Patches:
    + debian/patches/50_add_unity_quicklist.patch:
      - Dropped as upstream includes this feature now
  * debian/rules:
    - Stop installing compatibility version of gnome-terminal.desktop
      (LP: #1739263)

gnome-terminal (3.30.0-1) unstable; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * New upstream release 3.30 (LP: #1791373)
  * Refresh patches

  [ Jeremy Bicha ]
  * Bump minimum libvte-2.91-dev to 0.54.0
  * Cherry-pick app-Make-new-terminal-menu-a-hidden-pref.patch
    - unified New Terminal menu item can be set via gsettings (LP: #1747171)
  * Add debian/gnome-shell.gsettings-override to disable unified New Terminal
  * debian/rules: Drop obsolete build option to disable unified New Terminal
  * debian/rules: Drop obsolete --disable-migration configure flag
  * Update debian/gbp.conf

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 12 Sep 2018 15:30:08 +0100

[Egmont Koblinger (egmont-gmail)]

Hi guys,

- Due to a change in vte-0.54 around the child-exited signal, unfortunately lxterminal (LP: #1794440) and sakura (LP: #1790317) now crash when a tab is closed by clicking on the X button. Luckily, a fix is available for both of them. Could you please make sure to apply those fixes?

- I know that normally you update to the .1 minor release, I'd just like to point out that vte-0.54.1 fixes a segfault around encoding switches, so please indeed make sure not to miss this update.

Thanks!