Crash with vte-0.54

[Egmont Koblinger]

VTE changed certain things internally, and in turn Sakura crashes whenever its originally created tab is closed.

We think this is a bug in Sakura rather than VTE.

Please see https://gitlab.gnome.org/GNOME/vte/issues/32 for details.

(vte-0.54.0 will be released in about 2-3 days, until then you can see the crash with 0.53.92 or git master.)

[David Gómez (dabisu)]

Thanks for the report, Egmont. I’ll look it into it ASAP (unfortunately that means two weeks :-/)

[Egmont Koblinger (egmont-gmail)]

Here's a draft patch. Needs thorough testing, and checking with older VTEs (maybe ifdefs or so).

The problem is a circular dependency, manually destroying (or removing from the hierarchy) the widget now emits child-exited, and on child-exited sakura removes it from the tree. This loop is broken by explicitly uninstalling the child-exited handler when Sakura initiates the removal of the widget.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "draft fix" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Jeremy Bícha (jbicha)]

Egmont, thanks for testing sakura. Could you please forward this patch to Debian since sakura is maintained there? Debian has vte 0.54.0.

[Jeremy Bícha (jbicha)]

When you do have patches for Ubuntu, please subscribe ~ubuntu-sponsors so that the bug will automatically be added to http://reqorts.qa.ubuntu.com/reports/sponsoring/

[David Gómez (dabisu)]

Sorry for the delay. I've applied the patch to the main branch. Tests with vte 0.52 doesn't show any problems.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Egmont Koblinger (egmont-gmail)]

Debian report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909744.

[Jeremy Bícha (jbicha)]

This bug was fixed in the package sakura - 3.6.0-3

---------------
sakura (3.6.0-3) unstable; urgency=medium

  * Refresh patches
  * Add patch to fix building with libvte 0.54 (Closes: #909744)

 -- Andreas Rönnquist <email address hidden> Thu, 27 Sep 2018 19:40:14 +0200

sakura (3.6.0-2) unstable; urgency=medium

  * Build-dep on libpcre2-dev (Closes: #906984)
  * Remove a newline at end of d/changelog

 -- Andreas Rönnquist <email address hidden> Wed, 22 Aug 2018 22:20:27 +0200