Translations not updated from upstream

Bug #1734545 reported by Ask Hjorth Larsen
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-sudoku (Ubuntu)
Fix Released
High
Unassigned

Bug Description

The Danish translation of gnome-sudoku lacks many strings as it has not been synchronized with upstream for years:

https://translations.launchpad.net/ubuntu/+source/gnome-sudoku

Meanwhile gnome-sudoku is and has always been completely translated upstream. Indeed it has been fully translated for every release of GNOME ever since it forked out of gnome-games. Take for example current master:

https://l10n.gnome.org/vertimus/gnome-sudoku/master/po/da

It seems there are rather grave problems with translation imports in Launchpad. I reported a similar issue recently for util-linux:

https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1730793

Who knows how many other packages are affected, and in what languages. I think Launchpad translations should be disabled entirely for all source packages - the translations belong upstream, with the project.

Thanks to scootergrisen for making me aware of this problem.

Tags: patch
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I think this is going to be solved via the fix of bug #1688994. Once the other bug is fixed, gnome-sudoku needs to be re-built.

Changed in gnome-sudoku (Ubuntu):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

pkgbinarymangler has been fixed, so this will be fixed next time gnome-sudoku is uploaded.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-sudoku - 1:3.27.3-1

---------------
gnome-sudoku (1:3.27.3-1) experimental; urgency=medium

  * New upstream development release (LP: #1734545)

 -- Jeremy Bicha <email address hidden> Tue, 13 Feb 2018 22:49:42 -0500

Changed in gnome-sudoku (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Through this upload the source package's po/gnome-sudoku.pot (created 2017-12-10) was imported by Launchpad, which is a step in the right direction. However, the .po files were not imported, even if they are present here:

https://launchpad.net/ubuntu/bionic/+upload/17593515/+files/gnome-sudoku_3.27.3-1_amd64_translations.tar.gz

Import queue:

https://translations.launchpad.net/ubuntu/bionic/+source/gnome-sudoku/+imports

The .po files have the old Project-Id-Version "gnome-games". Can that have something to do with it?

The buildlog says: "'gnome-sudoku.pot' is up to date.". Does the build need to include a recreation of the template to trigger LP imports of the .po files?

Changed in gnome-sudoku (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Gunnar,

cs.po has this in its header
"Project-Id-Version: gnome-sudoku master\n"

and its translation was updated in December 2017, but it wasn't imported either. Anyway, Project-Id-Version doesn't seem very important.

I mean one "solution" here might be to convert gnome-sudoku to meson. I'm a bit concerned that there may be other main apps that also have this bug though.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Jeremy: I talked with Sebastien about it on IRC, and he noticed that there was an upstream translation sharing link, so I removed that. Seb said he would re-build, but probably forgot, so I'd suggest that someone (you?) upload a no-change rebuild as a first measure to see if the removal of that link makes a difference.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

The fact that the files are present in the tarball indicates an LP issue rather than a packaging one.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-sudoku - 1:3.27.3-1build1

---------------
gnome-sudoku (1:3.27.3-1build1) bionic; urgency=medium

  * No-change rebuild to try to fix translations issue (LP: #1734545)

 -- Jeremy Bicha <email address hidden> Mon, 19 Feb 2018 21:31:12 -0500

Changed in gnome-sudoku (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

And only templates again. :(

Next step proposed by Sebastien is to ask e.g. William Grant for help.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

No .po files in tarball:

https://launchpad.net/ubuntu/bionic/+upload/17626887/+files/gnome-sudoku_3.27.3-1build1_amd64_translations.tar.gz

I see now that there were no .po file in tarball last time either:

https://launchpad.net/ubuntu/bionic/+upload/17593515/+files/gnome-sudoku_3.27.3-1_amd64_translations.tar.gz

So maybe I was wrong - may there is some moment in the build which fails or is not enabled, after all.

Jeremy Bícha (jbicha)
Changed in gnome-sudoku (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Many of the .po files are huge, since they include strings from gnome-games, and many of them have not been merged with the template for years. So one idea is to upload with .po files which are consistent with po/gnome-sudoku.pot. Attached please find a patch which could be used for the purpose.

tags: added: patch
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I was wrong in comment #10 - checked apparently the wrong files.

All the stuff from the -proposed build is in the tarball.

https://launchpad.net/ubuntu/bionic/+upload/17626717/+files/gnome-sudoku_3.27.3-1build1_amd64_translations.tar.gz

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-sudoku - 1:3.27.3-1build2

---------------
gnome-sudoku (1:3.27.3-1build2) bionic; urgency=medium

  * Yet another no change rebuild after unsetting translations sharing on
    launchpad, that should allow the translations to be imported
    (lp: #1734545)

 -- Sebastien Bacher <email address hidden> Thu, 22 Feb 2018 10:25:46 +0100

Changed in gnome-sudoku (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Seems not to have helped. Nothing new in the translation import queue.

Changed in gnome-sudoku (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

The import has been done now and it resolves the issue described
https://translations.launchpad.net/ubuntu/bionic/+source/gnome-sudoku/+pots/gnome-sudoku/da/+details
The danish locale includes 100% translations and 0% launchpad changes over them which looks correct

Changed in gnome-sudoku (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.