dh-translations: cannot build POT without intltool

[Jeremy Bícha]

Excerpt from gnome-sudoku 17.04 build log
-----------------------------------

dh_translations
Use of uninitialized value $domain in concatenation (.) or string at /usr/bin/dh_translations line 93.
Does not use intltool and po/Makefile does not define GETTEXT_PACKAGE, cannot build POT automatically at /usr/bin/dh_translations line 113.

https://launchpad.net/ubuntu/+source/gnome-sudoku/1:3.24.0-0ubuntu1/+build/12150568

Other Info
----------
GNOME is porting many modules from intltool to use gettext directly

https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Sebastien Bacher (seb128)]

dh_translations does
$domain = $1 if /^GETTEXT_PACKAGE\s*=\s*(\S*)/;

which work for most projects which have a configure.ac with
GETTEXT_PACKAGE=<domain>
AC_SUBST(GETTEXT_PACKAGE)

but gnome-sudoku has
AC_SUBST([GETTEXT_PACKAGE], [gnome-sudoku])

it should be easy enough to add a case/regexp for that syntax

[AsciiWolf (asciiwolf)]

Any news? GNOME Calendar looks to be still missing the translations in Ubuntu 17.10.

[Jeremy Bícha (jbicha)]

AsciiWolf, please open a new bug for that issue. I can confirm the bug by the way but it is not happening with other meson apps like nautilus or totem.

[Jeremy Bícha (jbicha)]

AsciiWolf, the gnome-calendar bug should be fixed in 3.26.1. I'll work on packaging that now.

[Jeremy Bícha (jbicha)]

I think I'm just going to wait for 3.26.2 which should be released by the end of the week.

[AsciiWolf (asciiwolf)]

Thanks!

[Gunnar Hjalmarsson (gunnarhj)]

Modified patch uploaded after review by Sebastien Bacher and Didier Roche.

[Gunnar Hjalmarsson (gunnarhj)]

The upload failed in bionic. Attaching a third patch which works around the problem. Might be an alternative awaiting the real fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package pkgbinarymangler - 134

---------------
pkgbinarymangler (134) bionic; urgency=medium

  * Updated tests for the new dpkg which is generating files in the
    .tar.xz format instead of .tar.gz

 -- Sebastien Bacher <email address hidden> Fri, 09 Feb 2018 11:07:45 +0100

[Gunnar Hjalmarsson (gunnarhj)]

No such warning message in the buildlog from the latest upload of gnome-sudoku, which ought to confirm that this bug is fixed. (Bug #1734545 is still open for other reasons.)