SRU: Budgie-Welcome to support 2.18 series of webkit2gtk
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
budgie-welcome (Ubuntu) |
Fix Released
|
High
|
fossfreedom | ||
Zesty |
Fix Released
|
High
|
fossfreedom | ||
Artful |
Fix Released
|
High
|
fossfreedom |
Bug Description
[Impact]
In discussion with Jeremy Bicha (https:/
During artful testing, budgie-welcome segmentation faulted when running with the webkit2gtk 2.18 betas (2.17.*).
An initial workaround fix was applied to artful (LP: #1713210). Later discussions with upstream webkit2gtk indicated that the real reason why the segmentation fault occurred was due to calling GTK+ calls whilst inside a python thread. All GTK+ calls must be performed on the main loop thread.
The impact of this issue is that the initial workaround fix for artful is no longer required and can be rewritten as recommended by upstream.
The additional impact of this issue is that the 17.04 version of budgie-welcome would be similarly affected once new SRU'd version of webkit2gtk enters the archive.
[Test Case]
The code streams have slightly diverged so its not possible to cherry-pick the same patch from artful to zesty.
Thus the debdiffs are subtly different between the two versions of budgie-welcome. The same principles have occurred to make the two debdiff's - searching for direct webkit calls and converting these to equivalent calls but on the main thread.
Artful testcase: As per this bug-report, perform the following actions that are known to end with a segmentation fault.
1. open the recommendation page
2. open the budgie-applets page
3. open the getting started page
4. Install and remove a web-browser from the getting started page
5. Install an application from the recommendation page
6. Install and remove a budgie-applet from the budgie-applets page
Zesty testcase: With the current 2.16 series of webkit2gtk, perform the following actions to ensure they continue to work - i.e. regression tests
1. open the recommendation page
2. open the getting started page
3. Install and remove a web-browser from the getting started page
4. Install an application from the recommendation page
Upgrade Zesty with a backported version of the current artful 2.18 series of webkit2gtk (i.e. the version that would cause segmentation faults).
Repeat the above Zesty test case to ensure that segmentation faults do not occur
[Regression Potential]
It is possible that not all GTK+ based calls from a thread have been converted correctly and thus segmentation faults will still occur.
The mitigation here is that Artful is still in its beta test phase and any further issues can be addressed and analysis of the zesty code-stream can be performed to confirm if the same issue is likely and thus can be fixed before webkit2gtk is SRU'd
[Original Description]
On first login to Ubuntu Budgie, budgie-welcome is run.
This crashes immediately.
This has only started to occur since the new version of webkit2gtk was uploaded on Friday libwebkit2gtk-
to reproduce - login to Ubuntu Budgie. Delete the "firstrun" file and then run budgie-welcome
i.e.
dad@dad-
dad@dad-
1 0x7fcb99d8a287 /usr/lib/
2 0x7fcb9aceccca /usr/lib/
3 0x7fcb9ace182c /usr/lib/
4 0x7fcb9aeb9463 /usr/lib/
5 0x7fcba93d9e18 /usr/lib/
6 0x7fcba93d987a /usr/lib/
7 0x7fcba9b6f9cc /usr/lib/
8 0x7fcba9b714b8 /usr/lib/
9 0x7fcba9b65209 /usr/lib/
10 0x4591b3 /usr/bin/
11 0x54e607 /usr/bin/python3() [0x54e607]
12 0x552f9b /usr/bin/
13 0x54e4b1 /usr/bin/python3() [0x54e4b1]
14 0x54e73d /usr/bin/python3() [0x54e73d]
15 0x552f9b /usr/bin/
16 0x54da88 /usr/bin/python3() [0x54da88]
17 0x55772e /usr/bin/
18 0x459531 /usr/bin/
19 0x458fbe /usr/bin/
20 0x551497 /usr/bin/
21 0x54da88 /usr/bin/python3() [0x54da88]
22 0x54e9e6 /usr/bin/python3() [0x54e9e6]
23 0x552f9b /usr/bin/
24 0x54da88 /usr/bin/python3() [0x54da88]
25 0x54e9e6 /usr/bin/python3() [0x54e9e6]
26 0x552f9b /usr/bin/
27 0x54da88 /usr/bin/python3() [0x54da88]
28 0x55772e /usr/bin/
29 0x459531 /usr/bin/
30 0x458fbe /usr/bin/
31 0x58db52 /usr/bin/python3() [0x58db52]
Segmentation fault
dad@dad-
ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: libwebkit2gtk-
ProcVersionSign
Uname: Linux 4.12.0-11-generic x86_64
ApportVersion: 2.20.6-0ubuntu6
Architecture: amd64
CurrentDesktop: Budgie:GNOME
Date: Mon Aug 21 11:22:08 2017
InstallationDate: Installed on 2017-08-21 (0 days ago)
InstallationMedia: Ubuntu-Budgie 17.10 "Artful Aardvark" - Alpha amd64 (20170820)
SourcePackage: webkit2gtk
UpgradeStatus: No upgrade log present (probably fresh install)
no longer affects: | webkit2gtk (Ubuntu) |
Changed in budgie-welcome (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → fossfreedom (fossfreedom) |
summary: |
- Segmentation fault when logging in for the first time + SRU: Budgie-Welcome to support 2.7 series of webkit2gtk |
description: | updated |
Changed in budgie-welcome (Ubuntu Zesty): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in budgie-welcome (Ubuntu): | |
importance: | Undecided → High |
summary: |
- SRU: Budgie-Welcome to support 2.7 series of webkit2gtk + SRU: Budgie-Welcome to support 2.18 series of webkit2gtk |
Changed in budgie-welcome (Ubuntu Zesty): | |
assignee: | nobody → fossfreedom (fossfreedom) |
Changed in budgie-welcome (Ubuntu Artful): | |
status: | In Progress → Fix Committed |
Changed in budgie-welcome (Ubuntu Zesty): | |
status: | Triaged → In Progress |
Also seen when subsequently run budgie-welcome and click the getting-started button i.e. this is the wizard that would normally be seen on first logon.