Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

[Hồng Quân]

As found by https://github.com/gtimelog/gtimelog/issues/81#issuecomment-170923964, Ambiance theme doesn't respect Gtk3's GtkTextView::monospace. It causes issues on some apps. Gitg is affected as well.

My temporary workaround: https://quan.hoabinh.vn/blog/2017/6/46-fix-gitg-doesn-t-use-monospace-font-in-ubuntu

Please fix it.

[Juraj (ojura)]

I have already reported this in #1694303 and unfortunately nobody responded.
There is another issue mentioned there -- the commit description in gitg is unreadable, because it's white-on-white. Can someone take a look at that theming issue as well?

[Carlo Lobrano (c-lobrano)]

Hi Juray, I replied in 1694303

[Juraj (ojura)]

By the way, if you right click on the diff in gitg, the menu font is monospaced, although it shouldn't be. Not sure if related.

[Carlo Lobrano (c-lobrano)]

Do you mean, using the proposed patch?

[Juraj (ojura)]

Without the proposed patch.

[Juraj (ojura)]

Sorry, I messed up. With the proposed patch.

[Juraj (ojura)]

I mitigated this by clearing the property from children (such as the pop-up menu):

/* Fix Gitg source view */
.monospace {
    font-family: "Monospace";
}

.monospace * {
    font-family: initial;
}

[Juraj (ojura)]

Carlo, now I remember why I got confused. It happens in gedit (when right clicking the text area), with or without Hồng's patch.

[Carlo Lobrano (c-lobrano)]

Ok, I think this should have been discussed in patch's code review here

  https://code.launchpad.net/~c-lobrano/ubuntu-themes/fix-1700218/+merge/327422

however, the original patch should already take into account the context-menu's font style, at least in gitg it does. Let me have a look into gedit, maybe it uses a different class

[Juraj (ojura)]

Sorry, I haven't seen your patch, I see that you have done the same thing there as me above (I was referring to Hồng's original patch).

[Carlo Lobrano (c-lobrano)]

No worries. About gedit, I can't reproduce the issue. I changed gedit's font to Ubuntu regular (initially it was Ubuntu Mono, so a monospace context menu was expected, I guess) and the context menu is not in monospace.

However, if you're still able to reproduce the issue with a not monospace font, could you please open a dedicated bug?

[Juraj (ojura)]

I disagree that a monospace context menu is expected - this is not the case anywhere in the rest of the OS, it shouldn't matter that the text editing font is monospaced. But sure, that can be moved to a separate issue.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-themes - 16.10+17.10.20170918-0ubuntu1

---------------
ubuntu-themes (16.10+17.10.20170918-0ubuntu1) artful; urgency=medium

  [ Carlo Lobrano ]
  * Added support for GtkTextView::monospace (LP: #1700218)
  * Fixes support GtkTreeView separators (LP: #1701512)
  * Made dimmed text more visible in Gnome Boxes with Ambiance (LP:
    #1700100)
  * Added support for vertically linked buttons (LP: #1708141)

  [ Marco Trevisan (Treviño) ]
  * Radiance: use proper button border-image-source for headerbar
    elements (LP: #1692925)
  * Ambiance, Radiance: ignore titlebutton theming for appmenu
  * Ambiance, Radiance: add better definition for button destructive-
    action (LP: #1697900)

 -- Marco Trevisan (Treviño) <[e-mail]> Mon, 18 Sep 2017 18:25:27 +0000