Unnecessary ForModel use when retrieving controller addresses

[Menno Finlay-Smits]

The State.controllerAddresses() unnecessarily uses ForModel which is highly inefficient and unnecessary in this case. GetCollectionFor can be used in this case instead.

[Menno Finlay-Smits (menno.smits)]

Lowering priority of this as it appears that this code only gets called by tests.

[John A Meinel (jameinel)]

Sounds like a time bomb of someone just waiting to update something and use
a test as a starting point / finding a function that sounds like it does
just what they want.

John
=:->

On Jun 19, 2017 05:30, "Menno Finlay-Smits" <email address hidden>
wrote:

> Lowering priority of this as it appears that this code only gets called
> by tests.
>
> ** No longer affects: juju/2.2
>
> ** Changed in: juju
> Importance: High => Medium
>
> ** Changed in: juju
> Status: Triaged => In Progress
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1698703
>
> Title:
> Unnecessary ForModel use when retrieving controller addresses
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1698703/+subscriptions
>

[Menno Finlay-Smits (menno.smits)]

> Sounds like a time bomb of someone just waiting to update
> something and use a test as a starting point / finding a
> function that sounds like it does just what they want.

For sure - I will put up a fix shortly. I dropped the priority to highlight it's not as critical as some of the other ForModel misuses (and not important for 2.2.1).

[Menno Finlay-Smits (menno.smits)]

https://github.com/juju/juju/pull/7516