fanatic disable-fan fails without docker installed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-fan (Ubuntu) |
Fix Released
|
Medium
|
Stefan Bader | ||
Xenial |
In Progress
|
Medium
|
Stefan Bader | ||
Yakkety |
Fix Released
|
Medium
|
Stefan Bader | ||
Zesty |
Fix Released
|
Medium
|
Stefan Bader |
Bug Description
Release: 17.04/Zesty
Version: 0.12.2
When disabling fan, the code tries to check whether docker is configured. However that test is attempting to decide which docker version is installed (in order to handle the new network options). This fails but is incorrectly evaluated as docker being configured. And that prevents fan from being de-configured.
Fix: Test for docker being installed and if not return false to the configured check.
SRU Justification:
Impact: The function which does docker config updates/tests currently does not check for the presence of the docker command itself. And while there are error messages to stderr a call to check for fan being configured for docker accidentally results in returning true.
Fix: Adding a check for the docker command being present early in the function and return an error in that case (which is a false in the is-docker-
Testcase:
- [docker is not installed]
- fanatic enable-fan ...
- fanatic disable-fan ...
tags: | added: patch |
Changed in ubuntu-fan (Ubuntu Zesty): | |
importance: | Undecided → Medium |
status: | New → Fix Committed |
description: | updated |
Changed in ubuntu-fan (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in ubuntu-fan (Ubuntu Yakkety): | |
status: | New → In Progress |
Changed in ubuntu-fan (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in ubuntu-fan (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in ubuntu-fan (Ubuntu Xenial): | |
assignee: | nobody → Stefan Bader (smb) |
Changed in ubuntu-fan (Ubuntu Yakkety): | |
assignee: | nobody → Stefan Bader (smb) |
Changed in ubuntu-fan (Ubuntu Zesty): | |
assignee: | nobody → Stefan Bader (smb) |
Changed in ubuntu-fan (Ubuntu Yakkety): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-yakkety removed: verification-done |
Changed in ubuntu-fan (Ubuntu Yakkety): | |
status: | Incomplete → Fix Committed |
SRU Justification:
Impact: The function which does docker config updates/tests currently does not check for the presence of the docker command itself. And while there are error messages to stderr a call to check for fan being configured for docker accidentally results in returning true.
Fix: Adding a check for the docker command being present early in the function and return an error in that case (which is a false in the is-docker- configured case). Since the function should really always fail if there is no docker present the risk of regressions should be low.
Testcase:
- [docker is not installed]
- fanatic enable-fan ...
- fanatic disable-fan ...