| 2017-05-17 14:17:42 |
Stefan Bader |
bug |
|
|
added bug |
| 2017-05-17 14:23:41 |
Stefan Bader |
attachment added |
|
0001-fanatic-Prevent-error-message-without-docker-install.patch https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1691485/+attachment/4878309/+files/0001-fanatic-Prevent-error-message-without-docker-install.patch |
|
| 2017-05-17 16:23:00 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2017-05-23 07:15:34 |
Stefan Bader |
nominated for series |
|
Ubuntu Zesty |
|
| 2017-05-23 07:26:06 |
Stefan Bader |
bug |
|
|
added subscriber Ubuntu SRU developers |
| 2017-05-23 07:32:57 |
Łukasz Zemczak |
bug task added |
|
ubuntu-fan (Ubuntu Zesty) |
|
| 2017-05-23 07:35:48 |
Stefan Bader |
ubuntu-fan (Ubuntu Zesty): importance |
Undecided |
Medium |
|
| 2017-05-23 07:35:48 |
Stefan Bader |
ubuntu-fan (Ubuntu Zesty): status |
New |
Fix Committed |
|
| 2017-05-23 07:36:43 |
Łukasz Zemczak |
description |
Release: 17.04/Zesty
Version: 0.12.2
When disabling fan, the code tries to check whether docker is configured. However that test is attempting to decide which docker version is installed (in order to handle the new network options). This fails but is incorrectly evaluated as docker being configured. And that prevents fan from being de-configured.
Fix: Test for docker being installed and if not return false to the configured check. |
Release: 17.04/Zesty
Version: 0.12.2
When disabling fan, the code tries to check whether docker is configured. However that test is attempting to decide which docker version is installed (in order to handle the new network options). This fails but is incorrectly evaluated as docker being configured. And that prevents fan from being de-configured.
Fix: Test for docker being installed and if not return false to the configured check.
SRU Justification:
Impact: The function which does docker config updates/tests currently does not check for the presence of the docker command itself. And while there are error messages to stderr a call to check for fan being configured for docker accidentally results in returning true.
Fix: Adding a check for the docker command being present early in the function and return an error in that case (which is a false in the is-docker-configured case). Since the function should really always fail if there is no docker present the risk of regressions should be low.
Testcase:
- [docker is not installed]
- fanatic enable-fan ...
- fanatic disable-fan ... |
|
| 2017-05-23 07:53:46 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-05-23 07:53:47 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2017-05-23 07:53:52 |
Łukasz Zemczak |
tags |
patch |
patch verification-needed |
|
| 2017-05-23 19:18:27 |
Launchpad Janitor |
ubuntu-fan (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2017-05-24 10:20:09 |
Stefan Bader |
tags |
patch verification-needed |
patch verification-done |
|
| 2017-05-31 13:07:36 |
Launchpad Janitor |
ubuntu-fan (Ubuntu Zesty): status |
Fix Committed |
Fix Released |
|
| 2017-05-31 13:07:42 |
Andy Whitcroft |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2017-06-07 15:49:46 |
Stefan Bader |
nominated for series |
|
Ubuntu Yakkety |
|
| 2017-06-07 15:49:46 |
Stefan Bader |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-06-09 12:28:57 |
Andy Whitcroft |
bug task added |
|
ubuntu-fan (Ubuntu Xenial) |
|
| 2017-06-09 12:29:08 |
Andy Whitcroft |
bug task added |
|
ubuntu-fan (Ubuntu Yakkety) |
|
| 2017-06-09 12:29:17 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Xenial): status |
New |
In Progress |
|
| 2017-06-09 12:29:19 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Yakkety): status |
New |
In Progress |
|
| 2017-06-09 12:29:22 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2017-06-09 12:29:24 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Yakkety): importance |
Undecided |
Medium |
|
| 2017-06-09 12:29:38 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Xenial): assignee |
|
Stefan Bader (smb) |
|
| 2017-06-09 12:29:47 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Yakkety): assignee |
|
Stefan Bader (smb) |
|
| 2017-06-09 12:29:53 |
Andy Whitcroft |
ubuntu-fan (Ubuntu Zesty): assignee |
|
Stefan Bader (smb) |
|
| 2017-06-09 13:26:46 |
Stefan Bader |
ubuntu-fan (Ubuntu Yakkety): status |
In Progress |
Fix Committed |
|
| 2017-06-09 14:53:07 |
Andy Whitcroft |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-06-09 14:53:13 |
Andy Whitcroft |
tags |
patch verification-done |
patch |
|
| 2017-06-09 14:53:14 |
Andy Whitcroft |
tags |
patch |
patch verification-needed |
|
| 2017-06-13 09:30:17 |
Stefan Bader |
attachment added |
|
autopkgtest.log https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1691485/+attachment/4895113/+files/autopkgtest.log |
|
| 2017-06-13 09:30:46 |
Stefan Bader |
tags |
patch verification-needed |
patch verification-done |
|
| 2017-06-14 15:47:42 |
Łukasz Zemczak |
tags |
patch verification-done |
patch verification-done-yakkety |
|
| 2017-06-29 17:59:04 |
Brian Murray |
ubuntu-fan (Ubuntu Yakkety): status |
Fix Committed |
Incomplete |
|
| 2017-07-04 12:01:23 |
Łukasz Zemczak |
ubuntu-fan (Ubuntu Yakkety): status |
Incomplete |
Fix Committed |
|
| 2017-07-04 12:02:50 |
Launchpad Janitor |
ubuntu-fan (Ubuntu Yakkety): status |
Fix Committed |
Fix Released |
|
