Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

[fossfreedom]

Bug-fix release of budgie-welcome is now available. I am particularly keen to get this release reviewed and incorporated into zesty before the upcoming UI freeze please.

Below are the details...

- https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/zesty-proposed/+sourcepub/7523075/+listing-archive-extra

Changes since last version:

  * bug-fix release (LP: #1669589)
    - replace shortcut key for skippyxd to prevent conflict with chromium
    - inform users to reboot after installing flatpak
    - copyright year and name update for source file budgie-welcome
    - make sure chrome only installable for 64bit installs
    - ensure start page elements align correctly for chinese locale
    - fix package and ppa installs so that material theme is correctly
      installed
    - Update Material designs with missing Noto fonts
    - budgie-welcome source trailing spaces removed
    - recommendations has backports now listed first rather than last

Notes:
lintian -i -I run on .changes file
check-all-the-things has been run

[fossfreedom (fossfreedom)]

I've attached a debdiff for the changes.

Note - the diff looks fairly large but the vast majority of the changes are source file reformatting - spaces replacing tabs, stripped spaces.

See the description for the built package in our zesty-proposed PPA

[Bhavani Shankar (bhavi)]

@David: The diff mostly looks good at a glance but when I see in some places I see like the below

         if systemstate.session_type == 'live':
- app.update_page('.live-session-only', 'show')
+ app.update_page('.live-session-only', 'show')

which seems redundant to me.. it was unintentional I guess by the way I look at it.

I am happy to upload once redundant stuff if any is removed.

[fossfreedom (fossfreedom)]

Hi @bhavi,

  many thanks for the review - much appreciated!

I have had a close look at the diff using "git diff" so I can visualise the issues.

The lines you are referring to have spaces appended to the end of the line (trailing spaces) - so yes the output looks weird but under git diff you can visualise this.

I took the current master branch and copied over the previous version (v0.4.4) and ran it through with cat -A so you can see this - spaces are denoted by "$" chars.

   git diff | cat -A > ../diff-with-nonvalidchars.diff

Sorry about the bother here - we were trying to clean up duff characters bloating the code base.

We could revert back the older codebase and just make the significant changes for v0.4.5 and leave the duff space characters in place. It will take a bit of time - but we can do this if you wish.

[Bhavani Shankar (bhavi)]

NP :) Rest looks good. will upload in a while.

[Bhavani Shankar (bhavi)]

Only one observation :) The License file is extremely verbose :)

[Bhavani Shankar (bhavi)]

Uploaded. Building now on the buildds.

Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-welcome - 0.4.5

---------------
budgie-welcome (0.4.5) zesty; urgency=medium

  * bug-fix release (LP: #1669589)
    - replace shortcut key for skippyxd to prevent conflict with chromium
    - inform users to reboot after installing flatpak
    - copyright year and name update for source file budgie-welcome
    - make sure chrome only installable for 64bit installs
    - ensure start page elements align correctly for chinese locale
    - fix package and ppa installs so that material theme is correctly
      installed
    - Update Material designs with missing Noto fonts
    - budgie-welcome source trailing spaces removed
    - recommendations has backports now listed first rather than last

 -- David Mohammed <email address hidden> Fri, 24 Feb 2017 19:16:55 +0000