Comment 3 for bug 1669589

Revision history for this message
fossfreedom (fossfreedom) wrote :

Hi @bhavi,

  many thanks for the review - much appreciated!

I have had a close look at the diff using "git diff" so I can visualise the issues.

The lines you are referring to have spaces appended to the end of the line (trailing spaces) - so yes the output looks weird but under git diff you can visualise this.

I took the current master branch and copied over the previous version (v0.4.4) and ran it through with cat -A so you can see this - spaces are denoted by "$" chars.

   git diff | cat -A > ../diff-with-nonvalidchars.diff

Sorry about the bother here - we were trying to clean up duff characters bloating the code base.

We could revert back the older codebase and just make the significant changes for v0.4.5 and leave the duff space characters in place. It will take a bit of time - but we can do this if you wish.