[SRU] "When power is critically low" setting does nothing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
One Hundred Papercuts |
Fix Released
|
Medium
|
Unassigned | ||
ubuntu-docs (Ubuntu) |
Fix Released
|
Medium
|
Chris Perry | ||
Xenial |
Won't Fix
|
Undecided
|
Unassigned | ||
Yakkety |
Won't Fix
|
Undecided
|
Unassigned | ||
unity-control-center (Ubuntu) |
Fix Released
|
Medium
|
Will Cooke | ||
Xenial |
Invalid
|
Medium
|
Will Cooke | ||
Yakkety |
Fix Released
|
Medium
|
Will Cooke |
Bug Description
[Impact]
In unity-control-
However - what to do in the event of a critically low power situation is now handled by Upowerd automatically and so making a choice in u-c-c does nothing at all.
As such, leaving that option accessible to users will lead to confusion.
This patch removes the option from the UI.
[Test Case]
On an unpatched machine with a battery (i.e. laptop) open the power panel in u-c-c (Power/Settings menu in the top right corner -> System Settings -> Power. Note that the 2nd option down is "When power is critically low".
Once this update is applied and u-c-c is closed and reopened, this option is no longer present.
[Regression Potential]
There are some deletions from the ui file and some corresponding code deletions from the associated c file (cc-power-panel.c).
It is possible that extra code has been removed that could cause a crash or affect other options in the power panel.
However, the changes are fairly small and easy to review. Nothing looks out of place. Also testing has not shown any problems.
[Other Info]
Verbal (IRC) +1 from design via mpt.
+1 from docs team via mailing list.
Related branches
- Robert Ancell: Approve
- Sebastien Bacher: Pending requested
-
Diff: 104 lines (+1/-61)2 files modifiedpanels/power/cc-power-panel.c (+0/-13)
panels/power/power.ui (+1/-48)
- Gunnar Hjalmarsson: Approve
-
Diff: 124 lines (+33/-41)2 files modifiedubuntu-help/C/accounts-add.page (+22/-22)
ubuntu-help/C/power-lowpower.page (+11/-19)
Changed in unity-control-center (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-control-center (Ubuntu): | |
importance: | Undecided → High |
assignee: | nobody → Will Cooke (willcooke) |
milestone: | none → ubuntu-16.04.1 |
Changed in unity-control-center (Ubuntu Yakkety): | |
milestone: | ubuntu-16.04.1 → ubuntu-16.10 |
Changed in unity-control-center (Ubuntu Xenial): | |
milestone: | none → ubuntu-16.04.1 |
assignee: | nobody → Will Cooke (willcooke) |
importance: | Undecided → High |
status: | New → Confirmed |
summary: |
- "When power is critically low" setting does nothing + [SRU] "When power is critically low" setting does nothing |
no longer affects: | unity-control-center (Ubuntu Z-series) |
Changed in ubuntu-docs (Ubuntu Yakkety): | |
importance: | Medium → Undecided |
status: | Triaged → Won't Fix |
Changed in ubuntu-docs (Ubuntu): | |
assignee: | nobody → Chris Perry (clissold345) |
importance: | Undecided → Medium |
status: | Triaged → Fix Committed |
no longer affects: | ubuntu-docs (Ubuntu Z-series) |
Patch out the "When power is critically low" section of the power ui.