webbrowser-app fails tests with Qt 5.6

[Timo Jyrinki]

Some tests are newly failing with Qt 5.6 on webbrowser-app:

The following tests FAILED:
   2 - tst_QmlTests (Failed)
   9 - tst_TabsModelTests (OTHER_FAULT)
...
 6/25 Test #9: tst_TabsModelTests .......................***Exception: Other 0.28 sec
========= Received signal, dumping stack ==============
========= End of stack trace ==============
...
FAIL! : QmlTests::HistoryViewWide::test_delete_key_at_last_visit_date() Compared values are not the same

https://launchpadlibrarian.net/251526902/buildlog_ubuntu-xenial-amd64.webbrowser-app_0.23+16.04.20160322-0ubuntu2~xenial1~qt560~1_BUILDING.txt.gz

More information about Qt 5.6 at https://wiki.ubuntu.com/Touch/QtTesting

[Olivier Tilloy (osomon)]

IIRC I’ve seen QmlTests::HistoryViewWide::test_delete_key_at_last_visit_date() fail in the same manner with builds of the UITK using the staging branch, with Qt 5.5. Could it be that your build was using the staging branch of the UITK? If so that failure wouldn’t be specific to Qt 5.6.

The other failure on tst_TabsModelTests is more concerning, but the link to the build log doesn’t seem to be correct, that build didn’t even run the tests. Do you have more information about the failures?

If not I’ll install Qt 5.6 in a VM and will investigate the issue.

[Olivier Tilloy (osomon)]

I installed Qt 5.6 in a xenial VM (x86-64) and I’m seeing both failures, plus a third one on tst_FaviconFetcherTests.

[Olivier Tilloy (osomon)]

Backtrace for the segfault in tst_TabsModelTests:

#0 QV4::MemoryManager::allocData (this=0x6ce400, size=size@entry=48, unmanagedSize=unmanagedSize@entry=0)
    at memory/qv4mm.cpp:254
#1 0x00007ffff77cfb4d in QV4::MemoryManager::allocManaged<QV4::MemberData> (unmanagedSize=0, size=<optimized out>,
    this=<optimized out>) at ../../include/QtQml/5.6.0/QtQml/private/../../../../../src/qml/memory/qv4mm_p.h:102
#2 reallocateHelper (old=old@entry=0x0, n=3, e=0x6ce5e0, e=0x6ce5e0) at jsruntime/qv4memberdata.cpp:53
#3 0x00007ffff77cfbd1 in QV4::MemberData::allocate (e=e@entry=0x6ce5e0, n=<optimized out>)
    at jsruntime/qv4memberdata.cpp:64
#4 0x00007ffff782ad0a in QQmlVMEMetaObject::allocateProperties (this=0x785080) at qml/qqmlvmemetaobject.cpp:1126
#5 QQmlVMEMetaObject::propertiesAsMemberData (this=0x785080) at qml/qqmlvmemetaobject.cpp:325
#6 0x00007ffff782b37b in QQmlVMEMetaObject::readPropertyAsString (this=this@entry=0x785080, id=id@entry=1)
    at qml/qqmlvmemetaobject.cpp:457
#7 0x00007ffff782dc8a in QQmlVMEMetaObject::metaCall (this=0x785080, o=<optimized out>, c=QMetaObject::WriteProperty,
    _id=<optimized out>, a=0x7fffffffd480) at qml/qqmlvmemetaobject.cpp:693
#8 0x00007ffff6e2f8b0 in QMetaProperty::write(QObject*, QVariant const&) const ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9 0x00007ffff6e5635f in QObject::setProperty(char const*, QVariant const&) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x0000000000431e1a in TabsModelTests::createTabWithTitle(QString const&) ()
#11 0x0000000000432eca in TabsModelTests::shouldInsertAtCorrectIndex() ()
#12 0x000000000042f9b0 in TabsModelTests::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) ()
#13 0x00007ffff6e2c6e6 in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff6e32101 in QMetaObject::invokeMethod(QObject*, char const*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x00007ffff7fc8716 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5
#16 0x00007ffff7fc93a3 in QTest::qExec(QObject*, int, char**) () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5
#17 0x000000000042f81e in main ()

[Launchpad Janitor (janitor)]

This bug was fixed in the package webbrowser-app - 0.23+16.04.20160408.1-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20160408.1-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Loïc Molinari ]
  * Made AddressBar height scalable with regards to the grid units
    system.

  [ Olivier Tilloy ]
  * Add dep8 tests and instructions to run them in qemu or on a phone.
    Original work by Leo Arias and Vincent Ladeuil. added: debian/tests/
    debian/tests/control debian/tests/touch-session-autopilot
  * Catch ESC key event one level up to ensure that it’s not incorrectly
    bubbled up to the outer component. (LP: #1557016)
  * Customize the contents of the media permission dialog to avoid
    truncated text. (LP: #1554220)
  * Do not write the session to a temporary file when no target file is
    defined.
  * Fix a failing unit test with Qt 5.6. (LP: #1565507)
  * Fix broken webapp container autopilot tests. (LP: #1557019)
  * Fix issues with item selection in the downloads page: do not allow
    selecting multiple files when only one is expected do not allow
    entering delete mode (with a long press on an item) while in picker
    mode (LP: #1534112, #1561575)
  * Fix unit tests when run under an sbuild chroot. (LP: #1567294)
  * Import QQuickShortcut from Qt 5.5 to properly handle window-level
    keyboard shortcuts. We cannot bump the dependency on Qt to 5.5 as
    the stable overlay PPA for devices currently has Qt 5.4.1. (LP:
    #1542224, #1545802, #1537782)
  * Make the autopilot tests more reliable when dragging the bottom
    edge. (LP: #1560109)
  * Remove workaround for bug #1526940 that was fixed in the latest
    release of the UITK. (LP: #1526940)
  * Rename debian packages to follow new QML module naming convention.
    (LP: #1342031)
  * Simplify the implementation of HistoryViewWide quite a bit, and as a
    side effect fix a unit test failure when run against the staging
    branch of the UITK. (LP: #1567337)

 -- Olivier Tilloy <email address hidden> Fri, 08 Apr 2016 17:07:04 +0000