Menu & window icon is not standard thus not themed nor scalable

Bug #152634 reported by Milan Bouchet-Valat
4
Affects Status Importance Assigned to Milestone
system-config-printer (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: system-config-printer

The icon used in "Applications -> Accessories -> Manage printing tasks" and for the printing tasks window is not standard, like the one used in System -> Administration -> Printing, although they are very close. This leads to several issues: the icon is not fitted to the current theme, it's close to the other print icons but not identical, and it's not scalable, thus blurry or small when needing high sizes (Desktop launcher, Avant window navigator...).

So please simply use the standard stock icon for printing (printer.png) unless you have a more original one. ;-)

Revision history for this message
Tim Waugh (twaugh) wrote :

Patch welcome.

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

I changed the icon line to be Icon=printer.png (which is the standard icon for printing). Thus, the old icon is only used for the applet.
One day we could even wonder if it's not good to use this themed icon for the applet too. But that's another question... ;-)

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

I forgot to say: I don't know how to change the window's icon. This should not be difficult either, just checking in the codebase with 'grep' for the name of the old icon and replacing it (though I have no time right now, could you do that?)

Revision history for this message
Tim Waugh (twaugh) wrote :

I've committed a fix for this (revision 1679). It seems to work here, but is not a completely trivial change so should be handled with care.

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

system-config-printer (0.7.77+svn1699-0ubuntu1) hardy; urgency=low

  * New upstream release
     o Subversion snapshot r1699
     o Fix job manager appearing untrunslated (LP: #149572)
     o system-config-printer did not respect the user configuration for the
       appearance of the toolbar (LP: #135844)
     o Use standard icon for menus and system tray, so that they get themable
       and scalable (LP: #152634)
     o Tooltips for the button bar
     o Improvements of layout for IPP and TCP/Socket devices in New Printer
       wizard
  * debian/patches/20_match_more_printers.patch: Removed, fixed upstream.

 -- Till Kamppeter <email address hidden> Thu, 08 Nov 2007 00:53:16 -0700

Changed in system-config-printer:
status: New → Fix Released
Revision history for this message
Luca Cavalli (luca-cavalli) wrote :

You should never use the .png extension for the icon in .desktop files, this will prevent the use of the scalable version when needed. Instead use:
Icon=printer

Revision history for this message
Tim Waugh (twaugh) wrote :

Changed to 'Icon=printer' in SVN.

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

Was the (main) window icon updated to use standard 'printer' one too? Sorry, I can't check that easily. Thanks for your work, anyway.

Revision history for this message
Luca Cavalli (luca-cavalli) wrote :

Looking at the glade file from svn the main window uses the "gtk-print" icon, not the "printer" one.

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

Is that an issue? Which icon is best, 'printer' or 'gtk-print'?

Revision history for this message
Luca Cavalli (luca-cavalli) wrote :

I think that if I install an icon theme, the themed icon will probably be "printer" and since it is also used in notification area I would use the same icon for the window too. Anyway not a big issue :)

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

This appears to have been corrected recently, because on the Gutsy version, the window & tray icon is not themed and is not scalable to 48x48, which causes blur with Avant Window Navigator for example. gtk-print icon seems to be themeable (and of course it's normal). So we can definitely close this bug, and wait for Hardy. ;-)

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

system-config-printer (0.7.78+svn1740-0ubuntu1) hardy; urgency=low

  * New upstream release
     o Subversion snapshot r1740
     o Do not require PNG format for desktop icons (LP: #152634)
     o Applet: Throttle the rate of checking for jobs or error messages when in
       start-up mode. This prevents the applet being a nuisance when a large
       number of CUPS administration operations are performed in a batch.
     o Be more tolerant on failures to obtain printer info from CUPS.
     o Better check for whether the CUPS server is local.
     o Better methods to find default printer.
     o Applet: Allow the tray icon to reappear on the next print job when the
       user has hidden the applet icon with right-click -> "Hide" (LP: #156816).
     o Applet: Hide icon automatically when print job ends (LP: #151360).
  * debian/patches/10_menu_entries.patch: Regenerated.

 -- Till Kamppeter <email address hidden> Thu, 22 Nov 2007 17:02:25 +0000

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.