Desktop Effects settings UI has changed

[Phil Bull]

Binary package hint: ubuntu-docs

The user interface for the configuration of Desktop Effects has changed. References to the new UI should be updated in the documentation.

 1. Press System -> Preferences -> Appearance
 2. 'Desktop Effects' has been renamed to 'Visual Effects'
 3. The options under that tab have changed and a new one has been added

This affects trunk/ubuntu/desktop-effects/C/desktop-effects.xml.

[Phil Bull (philbull)]

Please leave this bug for a mentoring student for the time being. Thanks.

[Joel Goguen (jgoguen)]

I'll take this.

[Joel Goguen (jgoguen)]

Updated "desktop effects" to read "visual effects". The gnome menus entity was also updated for this reason. The options were updated to reflect the new names.

[Joel Goguen (jgoguen)]

Please ignore the previous attachment, I totally forgot about the references to Desktop Effects and the POT files.

[Matthew East (mdke)]

Hi Joel,

On a quick look the first patch looks good to me! You don't need to worry about POT files, these are generated automatically by a program called "xml2pot" - is that what you used? Editing them manually is a bad idea.

I'd suggest working with the earlier attachment.

[Joel Goguen (jgoguen)]

There was more that needed to be added to the first diff, to account for references to the visual effects page. This diff has those included, but not the POT files.

[Phil Bull (philbull)]

The patch looks good, and seems comprehensive. It also validates.

I found a few minor issues, which are nitpicks more than anything:

 * "Open the <application>Visual Effects Preferences</application>"
The application isn't specifically called "Visual Effects Preferences" (the window is called "Appearance Preferences"), so it would probably be better to refer to it as "visual effects preferences", without the capitals and <application> tag.

* "Enable extra Visual Effects"
"Visual Effects" should probably be lower case here. This was also an issue with the unpatched docs (i.e. "Desktop Effects" should have been "desktop effects" in a few cases)

 * "not be able to use Visual effects."
"Visual effects" -> "visual effects"

Thanks for working on this!

[Joel Goguen (jgoguen)]

That last point was my own typo, the original had "desktop effects" :)

Here's the latest patch with those points fixed.

[Phil Bull (philbull)]

Hi Joel,

Thanks for the updated patch. I'll review it at the weekend if no-one beats me to it...

[Phil Bull (philbull)]

Thanks Joel, I've committed most of your patch to ubuntu-hardy, revision 3652 (I removed the changes to the .pot files as we auto-generate those).

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-docs - 8.02.1

---------------
ubuntu-docs (8.02.1) hardy; urgency=low

  * New bzr checkout - loads of text fixes and improvements (LP: #183148,
    LP: #183025, LP: #178064, LP: #160435, LP: #158016, LP: #146794,
    LP: #144795, LP: #185867, LP: #163188, LP: #150167, LP: #148372,
    LP: #144928, LP: #141491, LP: #141444, LP: #138891, LP: #172565,
    LP: #144285, LP: #150641, LP: #176678)
  * First release for hardy

 -- Matthew East <email address hidden> Sat, 16 Feb 2008 18:31:20 +0000