Active windows loses focus after returning from Dash if another "Always on top" window is present
Bug #1446634 reported by
Christopher Townsend
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Christopher Townsend | ||
7.2 |
Fix Committed
|
Medium
|
Christopher Townsend | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Christopher Townsend | ||
Trusty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Active window looses focus after returning from Dash if "Always on top" window like VLC is already running. The focus is given to VLC instead of the window on which HUD was invoke.
This is very similar to bug #1366583.
[Test Case]
1. Open a nautilus window
2. Make it "Always on top"
3. Open a gnome-terminal window
4. Focus it
5. Press super to open the dash
6. Close the dash using Esc
7. Make sure gnome-terminal is focused
[Regression Potential]
The dash fails to give focus to new windows:
1. Open a nautilus window
2. Press super to open the dash
3. Open a new app
4. Make sure the new app window is focused
Related branches
lp:~townsend/unity/fix-dash-exit-always-on-top
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 12 lines (+2/-0)1 file modifieddash/DashController.cpp (+2/-0)
lp:~unity-team/unity/trusty-sru-7.2.6
- Andrea Azzarone (community): Approve
-
Diff: 1554 lines (+547/-141)43 files modifiedCMakeLists.txt (+1/-1)
ChangeLog (+182/-0)
UnityCore/GLibDBusProxy.cpp (+16/-3)
UnityCore/GnomeSessionManager.cpp (+6/-1)
dash/DashController.cpp (+2/-0)
dash/DashController.h (+0/-1)
dash/DashView.cpp (+72/-32)
dash/DashView.h (+3/-3)
dash/PlacesGroup.cpp (+13/-2)
dash/PlacesGroup.h (+1/-0)
dash/ResultView.cpp (+25/-0)
dash/ResultView.h (+6/-4)
dash/ResultViewGrid.cpp (+29/-13)
dash/ScopeView.cpp (+20/-22)
dash/ScopeView.h (+2/-0)
debian/changelog (+51/-0)
decorations/DecoratedWindow.cpp (+5/-0)
decorations/DecoratedWindow.h (+1/-0)
decorations/DecorationsManager.cpp (+5/-1)
hud/HudButton.cpp (+0/-5)
hud/HudController.cpp (+2/-0)
hud/HudController.h (+0/-1)
launcher/DeviceNotificationDisplayImp.cpp (+0/-1)
launcher/LauncherController.cpp (+2/-2)
launcher/LauncherIcon.cpp (+9/-4)
panel/PanelView.cpp (+18/-0)
panel/PanelView.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+16/-2)
plugins/unityshell/unityshell.xml.in (+6/-0)
unity-shared/BGHash.cpp (+5/-2)
unity-shared/CompizUtils.cpp (+0/-3)
unity-shared/OverlayRenderer.cpp (+2/-0)
unity-shared/OverlayScrollView.cpp (+5/-1)
unity-shared/OverlayScrollView.h (+2/-0)
unity-shared/OverlayWindowButtons.cpp (+3/-3)
unity-shared/PlacesOverlayVScrollBar.cpp (+5/-0)
unity-shared/PlacesOverlayVScrollBar.h (+8/-6)
unity-shared/PluginAdapter.cpp (+5/-1)
unity-shared/SearchBar.cpp (+9/-23)
unity-shared/SearchBar.h (+1/-3)
unity-shared/UnitySettings.cpp (+6/-1)
unity-shared/UnitySettings.h (+1/-0)
unity-shared/WindowButtons.cpp (+1/-0)
Changed in unity: | |
status: | New → In Progress |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
importance: | Undecided → Medium |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
Changed in unity: | |
assignee: | nobody → Christopher Townsend (townsend) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Christopher Townsend (townsend) |
Changed in unity: | |
milestone: | none → 7.3.3 |
Changed in unity: | |
status: | In Progress → Fix Committed |
description: | updated |
description: | updated |
Changed in unity (Ubuntu Trusty): | |
status: | New → In Progress |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu Trusty): | |
importance: | Undecided → Low |
importance: | Low → Medium |
To post a comment you must log in.
This bug was fixed in the package unity - 7.3.2+15. 10.20150512- 0ubuntu1
--------------- 15.10.20150512- 0ubuntu1) wily; urgency=medium
unity (7.3.2+
[ Chris Townsend ]
* Add new signal to tell the Launcher to terminate keynav mode and use
that signal when a BFB quicklist item is chosen. (LP: #1052024,
#1444643)
* Add option to enable and disable Unity low graphics mode on the fly
in ccsm or via gsettings. (LP: #1412937)
* Remove code that is no longer needed and broke opening application
spread while in Launcher keynav mode. (LP: #1445082)
* Save the active window when showing the Dash so the correct window
is focused when hiding the Dash. Fixes issue when "Always on Top"
windows are present. (LP: #1446634)
* Save the active window when showing the Hud so the correct window is
focused when hiding the Hud. Fixes issue when "Always on Top"
windows are present. (LP: #1366583)
* Send signal to ensure the Dash will show when entering keynav mode
since the first icon always highlighted is the BFB. (LP: #1444113)
* When looking for the top-most valid window in a VP, also check if
the window is focused if the window is set to Always on Top. This
allows Launcher icon spread to work properly when a window is
minimized an Always on Top exists in the group. (LP: #1131385)
* When using the left arrow to exit a Quicklist, Launcher keynav is
implied and should be active regardless of how the Quicklist was
opened. (LP: #1444626)
[ Eleni Maria Stea ]
* The skydome rendering of the cube plugin was wrong with unity
because transformation matrices set by the unityshell plugin were
left in the opengl matrix stacks affecting other compiz plugins.
Saving the compiz state at the beginning of the unityshell plugin
rendering functions and restoring it at the end of them fixes the
problem. (LP: #1446165)
-- CI Train Bot <email address hidden> Tue, 12 May 2015 13:10:15 +0000