Force high gfx mode with UNITY_LOW_GFX_MODE == 0
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Low
|
Sinclair Yeh | ||
7.2 |
Fix Committed
|
Low
|
Sinclair Yeh | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Sinclair Yeh | ||
Trusty |
Fix Released
|
Low
|
Unassigned |
Bug Description
While discussing bug #1491555, my colleague Brian Paul suggested that in addition to forcing low gfx mode with UNITY_LOW_GFX_MODE = 1, it would also be helpful to force it out of low gfx mode with UNITY_LOW_GFX_MODE = 0.
This way if Unity ends up in low gfx mode unnecessarily due to a wrong renderer string match, e.g. LLVM in the current case, there is a quick workaround to get out of it while a fix works its way through the release process.
The patch (signed-off-by: Sinclair Yeh <email address hidden>) attached adds this capability.
====
[Impact]
Running unity with UNITY_LOW_
[Test Case]
1. In CCSM go in unityshell settings, tick the option "Enable Low Graphics Mode"
2. Launch 'unity' from a terminal and it should be now in low-graphics mode
3. Launch 'UNITY_
[Regression Potential]
None
Related branches
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 20 lines (+6/-1)1 file modifiedplugins/unityshell/src/unityshell.cpp (+6/-1)
- Andrea Azzarone (community): Approve
-
Diff: 1554 lines (+547/-141)43 files modifiedCMakeLists.txt (+1/-1)
ChangeLog (+182/-0)
UnityCore/GLibDBusProxy.cpp (+16/-3)
UnityCore/GnomeSessionManager.cpp (+6/-1)
dash/DashController.cpp (+2/-0)
dash/DashController.h (+0/-1)
dash/DashView.cpp (+72/-32)
dash/DashView.h (+3/-3)
dash/PlacesGroup.cpp (+13/-2)
dash/PlacesGroup.h (+1/-0)
dash/ResultView.cpp (+25/-0)
dash/ResultView.h (+6/-4)
dash/ResultViewGrid.cpp (+29/-13)
dash/ScopeView.cpp (+20/-22)
dash/ScopeView.h (+2/-0)
debian/changelog (+51/-0)
decorations/DecoratedWindow.cpp (+5/-0)
decorations/DecoratedWindow.h (+1/-0)
decorations/DecorationsManager.cpp (+5/-1)
hud/HudButton.cpp (+0/-5)
hud/HudController.cpp (+2/-0)
hud/HudController.h (+0/-1)
launcher/DeviceNotificationDisplayImp.cpp (+0/-1)
launcher/LauncherController.cpp (+2/-2)
launcher/LauncherIcon.cpp (+9/-4)
panel/PanelView.cpp (+18/-0)
panel/PanelView.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+16/-2)
plugins/unityshell/unityshell.xml.in (+6/-0)
unity-shared/BGHash.cpp (+5/-2)
unity-shared/CompizUtils.cpp (+0/-3)
unity-shared/OverlayRenderer.cpp (+2/-0)
unity-shared/OverlayScrollView.cpp (+5/-1)
unity-shared/OverlayScrollView.h (+2/-0)
unity-shared/OverlayWindowButtons.cpp (+3/-3)
unity-shared/PlacesOverlayVScrollBar.cpp (+5/-0)
unity-shared/PlacesOverlayVScrollBar.h (+8/-6)
unity-shared/PluginAdapter.cpp (+5/-1)
unity-shared/SearchBar.cpp (+9/-23)
unity-shared/SearchBar.h (+1/-3)
unity-shared/UnitySettings.cpp (+6/-1)
unity-shared/UnitySettings.h (+1/-0)
unity-shared/WindowButtons.cpp (+1/-0)
Changed in unity: | |
status: | New → In Progress |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
importance: | Undecided → Low |
Changed in unity (Ubuntu): | |
importance: | Undecided → Low |
Changed in unity: | |
milestone: | none → 7.3.3 |
Changed in unity: | |
assignee: | nobody → Sinclair Yeh (sinclair-yeh) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Sinclair Yeh (sinclair-yeh) |
Changed in unity: | |
status: | In Progress → Fix Committed |
description: | updated |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu Trusty): | |
importance: | Undecided → Low |
tags: |
added: verification-donee removed: verification-needed |
tags: |
added: verification-done removed: verification-donee |
Here [1] you can find the MP containing this patch.
[1] https:/ /code.launchpad .net/~azzar1/ unity/lp- 1491913/ +merge/ 270349