Inbox 'reply to' and 'reply all' links be in own columns

[Robert Lyon]

Following on from https://bugs.launchpad.net/mahara/+bug/1385412

For some messages (if not all, as I've not tested fully) in the Inbox the 'subject' is a clickable link that expands the message and shows a 'reply >>' link.

On clicking that link it takes you to the 'Send message' page and pre populates certain fields as well as showing the message you are replying to.

I feel the current functionality of clicking the subject link to find the 'reply >>' and 'reply all' links is a bit cumbersome and Kristina agrees.

We need to take the reply links out of the subject's content and make it new columns for easier access.
I'm for making them new columns with a reply-to and reply-all icons (like what you get in an email client).

So the trick would be to only have them show up on messages that one is allowed to reply to and only have the reply all show up for the messages that have more than two users (including oneself) involved.

[Tobias Zeuch (tobias-zeuch-8)]

I agree in that it would make sense to move the "reply >>" and "reply all" links to separate columns.
Among that I think it would make sense to open the recipient-list and the content simultaneously.

The logic for having the "reply" and "reply all" links only appear on those that you can reply and where there are more than one recipient respectively works, as far as I have tested. So that shouldn't be difficult to apply to the buttons in the extra columns.

I would love to give provide a patch for that. Just one thing: Would you mind me making that a subpatch of https://reviews.mahara.org/#/c/3699/ (the patch for searching the in- and outbox)? They are both scheduled for the next release anyways, right?

[Aaron Wells (u-aaronw)]

Hi Tobias,

I'd prefer to have it as a standalone patch so that it doesn't get held up by the review of the search functionality. (Since presumably this should be a smaller change.

Cheers,
Aaron

[Tobias Zeuch (tobias-zeuch-8)]

Hi Aaron,

That'll mean more stuff to merge for the search patch but I get your point. Thanks by the way for removing the -1 flag on the other patch.

Cheers
Tobias

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/3891

[Eduardo (o-eduardo)]

Full testing method:

1. Log in as Admin
2. Go to Administration → Users → Add users by CSV
3. Uncheck the following:
 | Force password change |
 | Email users about their account |
4. Click “Add users by CSV”
5. Go to Inbox → Compose
6. Fill in the recipients with 2 or more users
7. Fill in Subject with “Testing message”
8. Fill in Message with “Testing message”
9. Click “Send message”
10. Go to Inbox → Go to “Sent”
11. You should see “...” → Passed
12. You should see one arrow link to “Reply all” → Passed
13. Log out as Admin
14. Log in as user “Bob”
15. Go to Inbox
16. You should see “...” → Passed
17. Click “...” → Passed
18. You should see One arrow link to “Reply all” → Passed
19. Click the “Reply all” arrow and you should be see a new message with all recipients → Passed
20. Go to Inbox
21. Click “...”
22. You should see One arrow link to “Reply → Passed
23. Click the “Reply” arrow and you should see a new message replying the recipient → Passed

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3891
Committed: http://gitorious.org/mahara/mahara/commit/b44e024d5f3ae589a42f9a14adfff64d7f4890fc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b44e024d5f3ae589a42f9a14adfff64d7f4890fc
Author: Tobias Zeuch <email address hidden>
Date: Fri Oct 31 13:14:01 2014 +0100

Inbox and outbox: show 'reply' and 'reply all' links in own column

Bug 1387330: Show reply and reply all buttons in a separate column in the inbox
and outbox, like email clients usually do. Also remove the reply-links after
the message text.
The buttons should only appear where applicalbe, e.g. only show a button reply
all when there were multiple recipients and don't show a reply-button for system
messages. Also other links remain in the message text, like links to new pages
in new-page-access notifications.

Change-Id: I938dda6210f4a0a8ab57b56c654cf60931ef7a6a
Signed-off-by: Tobias Zeuch <email address hidden>