ctap-bundle added

[hSenidmobile]

hsenidmobile-ctap bundle added. For install dependencies takes more time.

[Charles Butler (lazypower)]

Greetings hSendimobile - i applied the tag 'not-a-charm' as this did not look like an official charm review request according to the bug. If this is not the case, simply remove the tag and someone will be along shortly to review your work.

Thanks!

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1107-results

[hSenidmobile (ctap)]

Fixed Issues in ctap-bundle

[hSenidmobile (ctap)]

Hi Charles,
Now we have fixed bugs and issues.Now All the four charms are ready to
review again.
   1. hsenidmobile-ctap/bundle
   2. hsenidmobile-doc
   3. hsenidmobile-sampleapp
   4. hsenidmobile-simulator

Thanks for your help.

On Fri, Sep 26, 2014 at 8:37 PM, Charles Butler <
<email address hidden>> wrote:

> Greetings hSendimobile - i applied the tag 'not-a-charm' as this did not
> look like an official charm review request according to the bug. If this
> is not the case, simply remove the tag and someone will be along shortly
> to review your work.
>
> Thanks!
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1374277
>
> Title:
> ctap-bundle added
>
> Status in Juju Charms:
> New
>
> Bug description:
> hsenidmobile-ctap bundle added. For install dependencies takes more
> time.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charms/+bug/1374277/+subscriptions
>

[Whit Morriss (whitmo)]

Thanks for bringing these charm together as a bundle! I am assuming since this ended up in the queue, you would like it included in the charm store.

Running `bundletester` https://pypi.python.org/pypi/bundletester/0.4.0 on the bundle brings up some errors. The amulet tests are failing for "hsenidmobile-ctap-simulator" due to a naming mismatch (devspace-simulator vs. hsenidmobile-ctap-simulator).

As a stylistic point, I would recommend expanding your README to give browsers a bit more information about what CTAP is and how to use the simulator. I would also suggest adding instructions on how to access the api docs once deployed.

Due to broken tests I'm giving this a -1, but fix up the tests and the readme, and it will be close.

Thanks again!

-w

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1248-results

[hSenidmobile (ctap)]

Hi

Now changed sample application in to sample USSD application in the bundle.

Thanks