Comment 5 for bug 1374277

Revision history for this message
Whit Morriss (whitmo) wrote :

Thanks for bringing these charm together as a bundle! I am assuming since this ended up in the queue, you would like it included in the charm store.

Running `bundletester` https://pypi.python.org/pypi/bundletester/0.4.0 on the bundle brings up some errors. The amulet tests are failing for "hsenidmobile-ctap-simulator" due to a naming mismatch (devspace-simulator vs. hsenidmobile-ctap-simulator).

As a stylistic point, I would recommend expanding your README to give browsers a bit more information about what CTAP is and how to use the simulator. I would also suggest adding instructions on how to access the api docs once deployed.

Due to broken tests I'm giving this a -1, but fix up the tests and the readme, and it will be close.

Thanks again!

-w